helpers.php ➔ get_client_ip() - Code Metrics - renyang9876/yentwechat - Measure and Improve Code Quality continuously with Scrutinizer

helpers.php ➔ get_client_ip() A
last analyzed 2017-06-19 12:09 UTC

↳ Parent: Project

Complexity

Conditions	4
Paths	6

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
eloc	6
nc	6
nop	0
dl	0
loc	11
rs	9.2
c	0
b	0
f	0

<?php

namespace YEntWeChat\Payment;

/**
 * Generate a signature.
 *
 * @param array  $attributes
 * @param string $key
 * @param string $encryptMethod
 *
 * @return string
 */
function generate_sign(array $attributes, $key, $encryptMethod = 'md5')
{
    ksort($attributes);

    $attributes['key'] = $key;

    return strtoupper(call_user_func_array($encryptMethod, [urldecode(http_build_query($attributes))]));
}

/**
 * Get client ip.
 *
 * @return string
 */
function get_client_ip()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    if (!empty($_SERVER['REMOTE_ADDR'])) {
        $ip = $_SERVER['REMOTE_ADDR'];
    } else {
        // for php-cli(phpunit etc.)
        $ip = defined('PHPUNIT_RUNNING') ? '127.0.0.1' : gethostbyname(gethostname());
    }

    return filter_var($ip, FILTER_VALIDATE_IP) ?: '127.0.0.1';
}

/**
 * Get current server ip.
 *
 * @return string
 */
function get_server_ip()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
{
    if (!empty($_SERVER['SERVER_ADDR'])) {
        $ip = $_SERVER['SERVER_ADDR'];
    } elseif (!empty($_SERVER['SERVER_NAME'])) {
        $ip = gethostbyname($_SERVER['SERVER_NAME']);
    } else {
        // for php-cli(phpunit etc.)
        $ip = defined('PHPUNIT_RUNNING') ? '127.0.0.1' : gethostbyname(gethostname());
    }

    return filter_var($ip, FILTER_VALIDATE_IP) ?: '127.0.0.1';
}


1			<?php
2
3			namespace YEntWeChat\Payment;
4
5			/**
6			* Generate a signature.
7			*
8			* @param array $attributes
9			* @param string $key
10			* @param string $encryptMethod
11			*
12			* @return string
13			*/
14			function generate_sign(array $attributes, $key, $encryptMethod = 'md5')
15			{
16			ksort($attributes);
17
18			$attributes['key'] = $key;
19
20			return strtoupper(call_user_func_array($encryptMethod, [urldecode(http_build_query($attributes))]));
21			}
22
23			/**
24			* Get client ip.
25			*
26			* @return string
27			*/
28			function get_client_ip()
			0 ignored issues – show Coding Style introduced 2017-06-19 11:32 UTC by Report Bug Copy Issue Report `get_client_ip` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
29			{
30			if (!empty($_SERVER['REMOTE_ADDR'])) {
31			$ip = $_SERVER['REMOTE_ADDR'];
32			} else {
33			// for php-cli(phpunit etc.)
34			$ip = defined('PHPUNIT_RUNNING') ? '127.0.0.1' : gethostbyname(gethostname());
35			}
36
37			return filter_var($ip, FILTER_VALIDATE_IP) ?: '127.0.0.1';
38			}
39
40			/**
41			* Get current server ip.
42			*
43			* @return string
44			*/
45			function get_server_ip()
			0 ignored issues – show Coding Style introduced 2017-06-19 11:32 UTC by Report Bug Copy Issue Report `get_server_ip` uses the super-global variable `$_SERVER` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
46			{
47			if (!empty($_SERVER['SERVER_ADDR'])) {
48			$ip = $_SERVER['SERVER_ADDR'];
49			} elseif (!empty($_SERVER['SERVER_NAME'])) {
50			$ip = gethostbyname($_SERVER['SERVER_NAME']);
51			} else {
52			// for php-cli(phpunit etc.)
53			$ip = defined('PHPUNIT_RUNNING') ? '127.0.0.1' : gethostbyname(gethostname());
54			}
55
56			return filter_var($ip, FILTER_VALIDATE_IP) ?: '127.0.0.1';
57			}
58

renyang9876 / yentwechat

helpers.php ➔ get_client_ip() A last analyzed 2017-06-19 12:09 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

helpers.php ➔ get_client_ip() A
last analyzed 2017-06-19 12:09 UTC