Notify::__construct() - Code Metrics - renyang9876/yentwechat - Measure and Improve Code Quality continuously with Scrutinizer

Notify::__construct() A
last analyzed 2017-06-19 12:09 UTC

↳ Parent: Notify

Complexity

Conditions	2
Paths	2

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	3
nc	2
nop	2
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0

<?php

namespace YEntWeChat\Payment;

use YEntWeChat\Core\Exceptions\FaultException;
use YEntWeChat\Support\Collection;
use YEntWeChat\Support\XML;
use Symfony\Component\HttpFoundation\Request;

/**
 * Class Notify.
 */
class Notify
{
    /**
     * Merchant instance.
     *
     * @var \EntWeChat\Payment\Merchant
     */
    protected $merchant;

    /**
     * Request instance.
     *
     * @var \Symfony\Component\HttpFoundation\Request
     */
    protected $request;

    /**
     * Payment notify (extract from XML).
     *
     * @var Collection
     */
    protected $notify;

    /**
     * Constructor.
     *
     * @param Merchant $merchant
     * @param Request  $request
     */
    public function __construct(Merchant $merchant, Request $request = null)
    {
        $this->merchant = $merchant;

        $this->request = $request ?: Request::createFromGlobals();
    }

    /**
     * Validate the request params.
     *
     * @return bool
     */
    public function isValid()
    {
        $localSign = generate_sign($this->getNotify()->except('sign')->all(), $this->merchant->key, 'md5');

        return $localSign === $this->getNotify()->get('sign');
    }

    /**
     * Return the notify body from request.
     *
     * @throws \EntWeChat\Core\Exceptions\FaultException
     *
     * @return \EntWeChat\Support\Collection
     */
    public function getNotify()
    {
        if (!empty($this->notify)) {
            return $this->notify;
        }
        try {
            $xml = XML::parse(strval($this->request->getContent()));
        } catch (\Throwable $t) {

            throw new FaultException('Invalid request XML: '.$t->getMessage(), 400);
        } catch (\Exception $e) {
            throw new FaultException('Invalid request XML: '.$e->getMessage(), 400);
        }

        if (!is_array($xml) || empty($xml)) {
            throw new FaultException('Invalid request XML.', 400);
        }

        return $this->notify = new Collection($xml);
    }
}


1			<?php
2
3			namespace YEntWeChat\Payment;
4
5			use YEntWeChat\Core\Exceptions\FaultException;
6			use YEntWeChat\Support\Collection;
7			use YEntWeChat\Support\XML;
8			use Symfony\Component\HttpFoundation\Request;
9
10			/**
11			* Class Notify.
12			*/
13			class Notify
14			{
15			/**
16			* Merchant instance.
17			*
18			* @var \EntWeChat\Payment\Merchant
19			*/
20			protected $merchant;
21
22			/**
23			* Request instance.
24			*
25			* @var \Symfony\Component\HttpFoundation\Request
26			*/
27			protected $request;
28
29			/**
30			* Payment notify (extract from XML).
31			*
32			* @var Collection
33			*/
34			protected $notify;
35
36			/**
37			* Constructor.
38			*
39			* @param Merchant $merchant
40			* @param Request $request
41			*/
42			public function __construct(Merchant $merchant, Request $request = null)
43			{
44			$this->merchant = $merchant;
			0 ignored issues – show Documentation Bug introduced 2017-06-19 11:32 UTC by Report Bug Copy Issue Report It seems like `$merchant` of type `object<YEntWeChat\Payment\Merchant>` is incompatible with the declared type `object<EntWeChat\Payment\Merchant>` of property `$merchant`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
45			$this->request = $request ?: Request::createFromGlobals();
46			}
47
48			/**
49			* Validate the request params.
50			*
51			* @return bool
52			*/
53			public function isValid()
54			{
55			$localSign = generate_sign($this->getNotify()->except('sign')->all(), $this->merchant->key, 'md5');
56
57			return $localSign === $this->getNotify()->get('sign');
58			}
59
60			/**
61			* Return the notify body from request.
62			*
63			* @throws \EntWeChat\Core\Exceptions\FaultException
64			*
65			* @return \EntWeChat\Support\Collection
66			*/
67			public function getNotify()
68			{
69			if (!empty($this->notify)) {
70			return $this->notify;
71			}
72			try {
73			$xml = XML::parse(strval($this->request->getContent()));
74			} catch (\Throwable $t) {
			0 ignored issues – show Bug introduced 2017-06-19 11:32 UTC by Report Bug Copy Issue Report The class `Throwable` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
75			throw new FaultException('Invalid request XML: '.$t->getMessage(), 400);
76			} catch (\Exception $e) {
77			throw new FaultException('Invalid request XML: '.$e->getMessage(), 400);
78			}
79
80			if (!is_array($xml) \|\| empty($xml)) {
81			throw new FaultException('Invalid request XML.', 400);
82			}
83
84			return $this->notify = new Collection($xml);
85			}
86			}
87

renyang9876 / yentwechat

Notify::__construct() A last analyzed 2017-06-19 12:09 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Notify::__construct() A
last analyzed 2017-06-19 12:09 UTC