YEntWeChat\Staff\MessageBuilder

Complexity

Total Complexity

10

Size/Duplication

Total Lines	151
Duplicated Lines	21.19 %

Coupling/Cohesion

Components	2
Dependencies	4

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	message()	10	10	2
A	by()	0	9	1
A	to()	0	9	1
A	send()	22	22	3
A	__get()	0	6	2

<?php

namespace YEntWeChat\Staff;

use YEntWeChat\Core\Exceptions\InvalidArgumentException;
use YEntWeChat\Core\Exceptions\RuntimeException;
use YEntWeChat\Message\AbstractMessage;
use YEntWeChat\Message\Raw as RawMessage;
use YEntWeChat\Message\Text;

/**
 * Class MessageBuilder.
 */
class MessageBuilder
{
    /**
     * Message to send.
     *
     * @var \EntWeChat\Message\AbstractMessage;
     */
    protected $message;

    /**
     * Message receiver.
     *
     * @var array
     */
    protected $to;

    /**
     * Message sender.
     *
     * @var array
     */
    protected $by;

    /**
     * Staff instance.
     *
     * @var \EntWeChat\Staff\Staff
     */
    protected $staff;

    /**
     * User types.
     *
     * @var array
     */
    private $userTypes = [

The property $userTypes is not used and could be removed.

        Staff::USER_TYPE_STAFF,
        Staff::USER_TYPE_USERID,
        Staff::USER_TYPE_OPENID,
    ];

    /**
     * MessageBuilder constructor.
     *
     * @param \EntWeChat\Staff\Staff $staff
     */
    public function __construct(Staff $staff)
    {
        $this->staff = $staff;

It seems like $staff of type object<YEntWeChat\Staff\Staff> is incompatible with the declared type object<EntWeChat\Staff\Staff> of property $staff.

    }

    /**
     * Set message to send.
     *
     * @param string|AbstractMessage $message
     *
     * @throws InvalidArgumentException
     *
     * @return MessageBuilder
     */
    public function message($message)

This method seems to be duplicated in your project.

    {
        if (is_string($message)) {
            $message = new Text(['content' => $message]);
        }

        $this->message = $message;

        return $this;
    }

    /**
     * Set staff account to send message.
     *
     * @param string $type
     * @param string $id
     *
     * @return MessageBuilder
     */
    public function by($type, $id)
    {
        $this->account = [

The property account does not exist. Did you maybe forget to declare it?

            'type' => $type,
            'id'   => $id,
        ];

        return $this;
    }

    /**
     * Set target user open id.
     *
     * @param string $type
     * @param string $id
     *
     * @return MessageBuilder
     */
    public function to($type, $id)
    {
        $this->to = [
            'type' => $type,
            'id'   => $id,
        ];

        return $this;
    }

    /**
     * Send the message.
     *
     * @throws RuntimeException
     *
     * @return bool
     */
    public function send()

This method seems to be duplicated in your project.

    {
        if (empty($this->message)) {
            throw new RuntimeException('No message to send.');
        }

        $transformer = new Transformer();

        if ($this->message instanceof RawMessage) {
            $message = $this->message->get('content');
        } else {
            $content = $transformer->transform($this->message);
            $message = [
                'sender'   => $this->by,
                'receiver' => $this->to,
            ];

            $message = array_merge($message, $content);
        }

        return $this->staff->send($message);
    }

    /**
     * Return property.
     *
     * @param $property
     *
     * @return mixed
     */
    public function __get($property)
    {
        if (property_exists($this, $property)) {
            return $this->$property;
        }
    }
}