Issues in UserIssueController.php (master) - Issues in master - renatomarinho/laravel-gitscrum - Measure and Improve Code Quality continuously with Scrutinizer

Issues (336)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Http/Controllers/UserIssueController.php (11 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * GitScrum v0.1.
 *
 * @author  Renato Marinho <[email protected]>
 * @license http://opensource.org/licenses/GPL-3.0 GPLv3
 */

namespace GitScrum\Http\Controllers;

use Illuminate\Http\Request;
use GitScrum\Models\Issue;
use GitScrum\Models\User;

class UserIssueController extends Controller
{
    /**
     * Display a listing of the resource.
     *
     * @return \Illuminate\Http\Response
     */
    public function index($username, $slug_type = null)
    {
        $issues = Issue::join('sprints', 'issues.sprint_id', '=', 'sprints.id')
            ->join('issues_has_users', 'issues_has_users.issue_id', '=', 'issues.id')
            ->join('users', 'users.id', '=', 'issues_has_users.user_id')
            ->join('issue_types', 'issues.issue_type_id', '=', 'issue_types.id')
            ->where('users.username', $username);

        if (!is_null($slug_type)) {
            $issues = $issues->where('issue_types.slug', $slug_type);
        }

        $issues = $issues->orderby('issues.position', 'ASC')
            ->select('issues.*')->paginate(env('APP_PAGINATE'));

        $user = User::where('username', $username)
            ->where('provider', Auth::user()->provider)
            ->first();

        return view('user_issues.index')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with('issues', $issues)
            ->with('user', $user);
    }

    /**
     * Show the form for creating a new resource.
     *
     * @return \Illuminate\Http\Response

     */
    public function create()
    {
    }

    /**
     * Store a newly created resource in storage.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\Response

     */
    public function store(Request $request)

    {
    }

    /**
     * Display the specified resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response

     */
    public function show($id)

    {
    }

    /**
     * Show the form for editing the specified resource.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response

     */
    public function edit($id)

    {
    }

    /**
     * Update the specified resource in storage.
     *
     * @param \Illuminate\Http\Request $request
     * @param int                      $id
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return \Illuminate\Http\Response
     */
    public function update(Request $request, $slug)
    {
        $members = $request->input('members');

        $issue = Issue::slug($slug)
            ->firstOrFail();

        $issue->users()->sync($members);

        if (!$request->ajax()) {
            return redirect()->back()->with('success', trans('Updated successfully'));
        }
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response

     */
    public function destroy($id)

    {
    }
}


1			<?php
2			/**
3			* GitScrum v0.1.
4			*
5			* @author Renato Marinho <[email protected]>
6			* @license http://opensource.org/licenses/GPL-3.0 GPLv3
7			*/
8
9			namespace GitScrum\Http\Controllers;
10
11			use Illuminate\Http\Request;
12			use GitScrum\Models\Issue;
13			use GitScrum\Models\User;
14
15			class UserIssueController extends Controller
16			{
17			/**
18			* Display a listing of the resource.
19			*
20			* @return \Illuminate\Http\Response
21			*/
22			public function index($username, $slug_type = null)
23			{
24			$issues = Issue::join('sprints', 'issues.sprint_id', '=', 'sprints.id')
25			->join('issues_has_users', 'issues_has_users.issue_id', '=', 'issues.id')
26			->join('users', 'users.id', '=', 'issues_has_users.user_id')
27			->join('issue_types', 'issues.issue_type_id', '=', 'issue_types.id')
28			->where('users.username', $username);
29
30			if (!is_null($slug_type)) {
31			$issues = $issues->where('issue_types.slug', $slug_type);
32			}
33
34			$issues = $issues->orderby('issues.position', 'ASC')
35			->select('issues.*')->paginate(env('APP_PAGINATE'));
36
37			$user = User::where('username', $username)
38			->where('provider', Auth::user()->provider)
39			->first();
40
41			return view('user_issues.index')
			0 ignored issues – show Bug introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
42			->with('issues', $issues)
43			->with('user', $user);
44			}
45
46			/**
47			* Show the form for creating a new resource.
48			*
49			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2016-12-22 01:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `\Illuminate\Http\Response\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
50			*/
51			public function create()
52			{
53			}
54
55			/**
56			* Store a newly created resource in storage.
57			*
58			* @param \Illuminate\Http\Request $request
59			*
60			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2016-12-22 01:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `\Illuminate\Http\Response\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
61			*/
62			public function store(Request $request)
			0 ignored issues – show Unused Code introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
63			{
64			}
65
66			/**
67			* Display the specified resource.
68			*
69			* @param int $id
70			*
71			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2016-12-22 01:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `\Illuminate\Http\Response\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
72			*/
73			public function show($id)
			0 ignored issues – show Unused Code introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
74			{
75			}
76
77			/**
78			* Show the form for editing the specified resource.
79			*
80			* @param int $id
81			*
82			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2016-12-22 01:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `\Illuminate\Http\Response\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
83			*/
84			public function edit($id)
			0 ignored issues – show Unused Code introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
85			{
86			}
87
88			/**
89			* Update the specified resource in storage.
90			*
91			* @param \Illuminate\Http\Request $request
92			* @param int $id
			0 ignored issues – show Bug introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$id`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
93			*
94			* @return \Illuminate\Http\Response
95			*/
96			public function update(Request $request, $slug)
97			{
98			$members = $request->input('members');
99
100			$issue = Issue::slug($slug)
101			->firstOrFail();
102
103			$issue->users()->sync($members);
104
105			if (!$request->ajax()) {
106			return redirect()->back()->with('success', trans('Updated successfully'));
107			}
108			}
109
110			/**
111			* Remove the specified resource from storage.
112			*
113			* @param int $id
114			*
115			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2016-12-22 01:14 UTC by Report Bug Copy Issue Report Show Similar Issues like this Should the return type not be `\Illuminate\Http\Response\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
116			*/
117			public function destroy($id)
			0 ignored issues – show Unused Code introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$id` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
118			{
119			}
120			}
121

renatomarinho / laravel-gitscrum

Issues (336)

Security Analysis not enabled

app/Http/Controllers/UserIssueController.php (11 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like