Issues in IssueController.php (master) - Issues in master - renatomarinho/laravel-gitscrum - Measure and Improve Code Quality continuously with Scrutinizer

Issues (336)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Http/Controllers/IssueController.php (13 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * GitScrum v0.1.
 *
 * @author  Renato Marinho <[email protected]>
 * @license http://opensource.org/licenses/GPL-3.0 GPLv3
 */

namespace GitScrum\Http\Controllers;

use Illuminate\Http\Request;
use GitScrum\Http\Requests\IssueRequest;
use GitScrum\Models\Sprint;
use GitScrum\Models\UserStory;
use GitScrum\Models\Issue;
use GitScrum\Models\Organization;
use GitScrum\Models\IssueType;
use GitScrum\Models\ConfigStatus;
use GitScrum\Models\ConfigIssueEffort;
use Carbon\Carbon;
use Auth;

class IssueController extends Controller
{
    public function index($slug)

    {
        if ($slug) {
            $sprint = Sprint::slug($slug)
                ->with('issues.user')
                ->with('issues.users')
                ->with('issues.commits')
                ->with('issues.statuses')
                ->with('issues.status')
                ->with('issues.comments')
                ->with('issues.attachments')
                ->with('issues.type')
                ->with('issues.productBacklog')
                ->with('issues.sprint')
                ->with('issues.configEffort')
                ->first();

            $issues = $sprint->issues;
        } else {
            $sprint = null;
            $issues = Auth::user()->issues()
                ->with('user')
                ->with('users')
                ->with('commits')
                ->with('statuses')
                ->with('status')
                ->with('comments')
                ->with('attachments')
                ->with('type')
                ->with('productBacklog')
                ->with('sprint')
                ->with('configEffort')
                ->get();
        }

        $issues = $issues->sortBy('position')->groupBy('config_status_id');

        $configStatus = ConfigStatus::type('issue')->get();

        if (!is_null($sprint) && !count($sprint)) {
            return redirect()->route('sprints.index');
        }

        return view('issues.index')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with('sprint', $sprint)
            ->with('issues', $issues)
            ->with('configStatus', $configStatus);
    }

    public function create($slug_sprint = null, $slug_user_story = null, $parent_id = null)

    {
        $issue_types = IssueType::where('enabled', 1)
            ->orderby('position', 'ASC')
            ->get();

        $issue_efforts = ConfigIssueEffort::where('enabled', 1)
            ->orderby('position', 'ASC')
            ->get();

        $userStory = $productBacklogs = null;

        if ((is_null($slug_sprint) || !$slug_sprint) && $slug_user_story) {
            $userStory = UserStory::slug($slug_user_story)->first();
            $productBacklogs = Auth::user()->productBacklogs($userStory->product_backlog_id);
            $usersByOrganization = Organization::find($userStory->productBacklog->organization_id)->users;
        } elseif ($slug_sprint) {
            $usersByOrganization = Organization::find(Sprint::slug($slug_sprint)->first()
                ->productBacklog->organization_id)->users;
        } else {
            $issue = Issue::find($parent_id);
            $productBacklogs = $issue->product_backlog_id;
            $usersByOrganization = Organization::find($issue->productBacklog->organization_id)->users;
        }

        return view('issues.create')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with('productBacklogs', $productBacklogs)
            ->with('userStory', $userStory)
            ->with('slug', $slug_sprint)
            ->with('parent_id', $parent_id)
            ->with('issue_types', $issue_types)
            ->with('issue_efforts', $issue_efforts)
            ->with('usersByOrganization', $usersByOrganization)
            ->with('action', 'Create');
    }

    public function store(IssueRequest $request)
    {
        $issue = Issue::create($request->all());

        if (is_array($request->members)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $issue->users()->sync($request->members);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        return redirect()->route('issues.show', ['slug' => $issue->slug])
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->with('success', trans('Congratulations! The Issue has been created with successfully'));
    }

    public function show($slug)

    {
        $issue = Issue::slug($slug)
            ->with('sprint')
            ->with('type')
            ->with('configEffort')
            ->with('labels')
            ->first();

        $usersByOrganization = Organization::find($issue->productBacklog->organization_id)->users;

        return view('issues.show')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with('issue', $issue)
            ->with('usersByOrganization', $usersByOrganization);
    }

    public function edit($slug)

    {
        $issue = Issue::slug($slug)->first();

        $issue_types = IssueType::where('enabled', 1)
            ->orderby('position', 'ASC')
            ->get();

        $issue_efforts = ConfigIssueEffort::where('enabled', 1)
            ->orderby('position', 'ASC')
            ->get();

        $usersByOrganization = Organization::find($issue->productBacklog->organization_id)->users;

        return view('issues.edit')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with('productBacklogs', $issue->productBacklog->id)
            ->with('userStory', $issue->userStory)
            ->with('slug', isset($issue->sprint->slug) ? $issue->sprint->slug : null)
            ->with('issue_types', $issue_types)
            ->with('issue_efforts', $issue_efforts)
            ->with('usersByOrganization', $usersByOrganization)
            ->with('issue', $issue)
            ->with('action', 'Edit');
    }

    public function update(IssueRequest $request, $slug)
    {
        $issue = Issue::slug($slug)->first();
        $issue->update($request->all());

        if (is_array($request->members)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $issue->users()->sync($request->members);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        return back()
            ->with('success', trans('Congratulations! The Issue has been edited with successfully'));
    }

    public function statusUpdate(Request $request, $slug = null, int $status = 0)
    {
        if (!isset($request->status_id)) {
            $request->status_id = $status;
        }
        $status = ConfigStatus::find($request->status_id);
        $save = function ($issue, $position = null) use ($request, $status) {
            $issue->config_status_id = $request->status_id;

            if (!is_null($status->is_closed) && is_null($issue->closed_at)) {
                $issue->closed_user_id = Auth::id();
                $issue->closed_at = Carbon::now();
            } elseif (is_null($status->is_closed)) {
                $issue->closed_user_id = null;
                $issue->closed_at = null;
            }

            if ($position) {
                $issue->position = $position;
            }

            return $issue->save();
        };

        if ($request->ajax()) {
            $position = 1;
            try {
                foreach (json_decode($request->json) as $id) {
                    $issue = Issue::find($id);
                    $save($issue, $position);
                    ++$position;
                }

                return response()->json([
                    'success' => true,
                ]);
            } catch (\Exception $e) {
                return response()->json([
                    'success' => false,
                ]);
            }
        } else {
            $issue = Issue::slug($slug)
                ->firstOrFail();
            $save($issue);

            return back()->with('success', trans('Updated successfully'));
        }
    }

    public function destroy(Request $request)
    {
        $issue = Issue::slug($request->slug)->firstOrFail();

        if (isset($issue->userStory)) {
            $redirect = redirect()->route('user_stories.show', ['slug' => $issue->userStory->slug]);
        } else {
            $redirect = redirect()->route('sprints.show', ['slug' => $issue->sprint->slug]);
        }

        $issue->delete();

        return $redirect;
    }
}


Issues (336)

Security Analysis not enabled

app/Http/Controllers/IssueController.php (13 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2			/**
3			* GitScrum v0.1.
4			*
5			* @author Renato Marinho <[email protected]>
6			* @license http://opensource.org/licenses/GPL-3.0 GPLv3
7			*/
8
9			namespace GitScrum\Http\Controllers;
10
11			use Illuminate\Http\Request;
12			use GitScrum\Http\Requests\IssueRequest;
13			use GitScrum\Models\Sprint;
14			use GitScrum\Models\UserStory;
15			use GitScrum\Models\Issue;
16			use GitScrum\Models\Organization;
17			use GitScrum\Models\IssueType;
18			use GitScrum\Models\ConfigStatus;
19			use GitScrum\Models\ConfigIssueEffort;
20			use Carbon\Carbon;
21			use Auth;
22
23			class IssueController extends Controller
24			{
25			public function index($slug)
			0 ignored issues – show Documentation introduced 2017-01-01 16:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
26			{
27			if ($slug) {
28			$sprint = Sprint::slug($slug)
29			->with('issues.user')
30			->with('issues.users')
31			->with('issues.commits')
32			->with('issues.statuses')
33			->with('issues.status')
34			->with('issues.comments')
35			->with('issues.attachments')
36			->with('issues.type')
37			->with('issues.productBacklog')
38			->with('issues.sprint')
39			->with('issues.configEffort')
40			->first();
41
42			$issues = $sprint->issues;
43			} else {
44			$sprint = null;
45			$issues = Auth::user()->issues()
46			->with('user')
47			->with('users')
48			->with('commits')
49			->with('statuses')
50			->with('status')
51			->with('comments')
52			->with('attachments')
53			->with('type')
54			->with('productBacklog')
55			->with('sprint')
56			->with('configEffort')
57			->get();
58			}
59
60			$issues = $issues->sortBy('position')->groupBy('config_status_id');
61
62			$configStatus = ConfigStatus::type('issue')->get();
63
64			if (!is_null($sprint) && !count($sprint)) {
65			return redirect()->route('sprints.index');
66			}
67
68			return view('issues.index')
			0 ignored issues – show Bug introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
69			->with('sprint', $sprint)
70			->with('issues', $issues)
71			->with('configStatus', $configStatus);
72			}
73
74			public function create($slug_sprint = null, $slug_user_story = null, $parent_id = null)
			0 ignored issues – show Documentation introduced 2017-01-01 16:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
75			{
76			$issue_types = IssueType::where('enabled', 1)
77			->orderby('position', 'ASC')
78			->get();
79
80			$issue_efforts = ConfigIssueEffort::where('enabled', 1)
81			->orderby('position', 'ASC')
82			->get();
83
84			$userStory = $productBacklogs = null;
85
86			if ((is_null($slug_sprint) \|\| !$slug_sprint) && $slug_user_story) {
87			$userStory = UserStory::slug($slug_user_story)->first();
88			$productBacklogs = Auth::user()->productBacklogs($userStory->product_backlog_id);
89			$usersByOrganization = Organization::find($userStory->productBacklog->organization_id)->users;
90			} elseif ($slug_sprint) {
91			$usersByOrganization = Organization::find(Sprint::slug($slug_sprint)->first()
92			->productBacklog->organization_id)->users;
93			} else {
94			$issue = Issue::find($parent_id);
95			$productBacklogs = $issue->product_backlog_id;
96			$usersByOrganization = Organization::find($issue->productBacklog->organization_id)->users;
97			}
98
99			return view('issues.create')
			0 ignored issues – show Bug introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
100			->with('productBacklogs', $productBacklogs)
101			->with('userStory', $userStory)
102			->with('slug', $slug_sprint)
103			->with('parent_id', $parent_id)
104			->with('issue_types', $issue_types)
105			->with('issue_efforts', $issue_efforts)
106			->with('usersByOrganization', $usersByOrganization)
107			->with('action', 'Create');
108			}
109
110			public function store(IssueRequest $request)
111			{
112			$issue = Issue::create($request->all());
113
114			if (is_array($request->members)) {
			0 ignored issues – show Documentation introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `members` does not exist on `object<GitScrum\Http\Requests\IssueRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
115			$issue->users()->sync($request->members);
			0 ignored issues – show Documentation introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `members` does not exist on `object<GitScrum\Http\Requests\IssueRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
116			}
117
118			return redirect()->route('issues.show', ['slug' => $issue->slug])
			0 ignored issues – show Documentation introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `slug` does not exist on `object<GitScrum\Models\Issue>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
119			->with('success', trans('Congratulations! The Issue has been created with successfully'));
120			}
121
122			public function show($slug)
			0 ignored issues – show Documentation introduced 2017-01-01 16:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
123			{
124			$issue = Issue::slug($slug)
125			->with('sprint')
126			->with('type')
127			->with('configEffort')
128			->with('labels')
129			->first();
130
131			$usersByOrganization = Organization::find($issue->productBacklog->organization_id)->users;
132
133			return view('issues.show')
			0 ignored issues – show Bug introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
134			->with('issue', $issue)
135			->with('usersByOrganization', $usersByOrganization);
136			}
137
138			public function edit($slug)
			0 ignored issues – show Documentation introduced 2017-01-01 16:07 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
139			{
140			$issue = Issue::slug($slug)->first();
141
142			$issue_types = IssueType::where('enabled', 1)
143			->orderby('position', 'ASC')
144			->get();
145
146			$issue_efforts = ConfigIssueEffort::where('enabled', 1)
147			->orderby('position', 'ASC')
148			->get();
149
150			$usersByOrganization = Organization::find($issue->productBacklog->organization_id)->users;
151
152			return view('issues.edit')
			0 ignored issues – show Bug introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
153			->with('productBacklogs', $issue->productBacklog->id)
154			->with('userStory', $issue->userStory)
155			->with('slug', isset($issue->sprint->slug) ? $issue->sprint->slug : null)
156			->with('issue_types', $issue_types)
157			->with('issue_efforts', $issue_efforts)
158			->with('usersByOrganization', $usersByOrganization)
159			->with('issue', $issue)
160			->with('action', 'Edit');
161			}
162
163			public function update(IssueRequest $request, $slug)
164			{
165			$issue = Issue::slug($slug)->first();
166			$issue->update($request->all());
167
168			if (is_array($request->members)) {
			0 ignored issues – show Documentation introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `members` does not exist on `object<GitScrum\Http\Requests\IssueRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
169			$issue->users()->sync($request->members);
			0 ignored issues – show Documentation introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `members` does not exist on `object<GitScrum\Http\Requests\IssueRequest>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
170			}
171
172			return back()
173			->with('success', trans('Congratulations! The Issue has been edited with successfully'));
174			}
175
176			public function statusUpdate(Request $request, $slug = null, int $status = 0)
177			{
178			if (!isset($request->status_id)) {
179			$request->status_id = $status;
180			}
181			$status = ConfigStatus::find($request->status_id);
182			$save = function ($issue, $position = null) use ($request, $status) {
183			$issue->config_status_id = $request->status_id;
184
185			if (!is_null($status->is_closed) && is_null($issue->closed_at)) {
186			$issue->closed_user_id = Auth::id();
187			$issue->closed_at = Carbon::now();
188			} elseif (is_null($status->is_closed)) {
189			$issue->closed_user_id = null;
190			$issue->closed_at = null;
191			}
192
193			if ($position) {
194			$issue->position = $position;
195			}
196
197			return $issue->save();
198			};
199
200			if ($request->ajax()) {
201			$position = 1;
202			try {
203			foreach (json_decode($request->json) as $id) {
204			$issue = Issue::find($id);
205			$save($issue, $position);
206			++$position;
207			}
208
209			return response()->json([
210			'success' => true,
211			]);
212			} catch (\Exception $e) {
213			return response()->json([
214			'success' => false,
215			]);
216			}
217			} else {
218			$issue = Issue::slug($slug)
219			->firstOrFail();
220			$save($issue);
221
222			return back()->with('success', trans('Updated successfully'));
223			}
224			}
225
226			public function destroy(Request $request)
227			{
228			$issue = Issue::slug($request->slug)->firstOrFail();
229
230			if (isset($issue->userStory)) {
231			$redirect = redirect()->route('user_stories.show', ['slug' => $issue->userStory->slug]);
232			} else {
233			$redirect = redirect()->route('sprints.show', ['slug' => $issue->sprint->slug]);
234			}
235
236			$issue->delete();
237
238			return $redirect;
239			}
240			}
241

renatomarinho / laravel-gitscrum

Issues (336)

Security Analysis not enabled

app/Http/Controllers/IssueController.php (13 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like