WizardController - Code Metrics - Inspection of "Wizard to add/update repositories / some small fix..." - renatomarinho/laravel-gitscrum - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 39dbfd...23dd4b )

by Renato

created 2016-12-02 02:49 UTC

WizardController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
wmc	4
lcom	0
cbo	2
dl	0
loc	29
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	step1()	0	10	1
A	step2()	0	15	3

<?php

namespace GitScrum\Http\Controllers;

use Illuminate\Http\Request;
use GitScrum\Models\ProductBacklog;


class WizardController extends Controller
{
    public function step1()

    {
        $repositories = app('GithubClass')->getRepositories();

        \Session::put('GithubRepositories', $repositories);

        return view('wizard.step1')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with('repositories', $repositories)
            ->with('columns', ['checkbox', 'repository', 'organization']);
    }

    public function step2(Request $request)

    {
        $repositories = \Session::get('GithubRepositories')->whereIn('github_id', $request->repos);
        foreach ($repositories as $repository) {
            try{
                ProductBacklog::create(get_object_vars($repository));
            } catch (\Illuminate\Database\QueryException $e) {

            }
        }

        return view('wizard.step2')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with('repositories', $repositories)
            ->with('columns', ['repository', 'organization']);

    }
}


Push — master ( 39dbfd...23dd4b )

WizardController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Available Fixes

1			<?php
2
3			namespace GitScrum\Http\Controllers;
4
5			use Illuminate\Http\Request;
6			use GitScrum\Models\ProductBacklog;
7
8
9			class WizardController extends Controller
10			{
11			public function step1()
			0 ignored issues – show Documentation introduced 2016-12-02 02:52 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
12			{
13			$repositories = app('GithubClass')->getRepositories();
14
15			\Session::put('GithubRepositories', $repositories);
16
17			return view('wizard.step1')
			0 ignored issues – show Bug introduced 2016-12-02 02:52 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
18			->with('repositories', $repositories)
19			->with('columns', ['checkbox', 'repository', 'organization']);
20			}
21
22			public function step2(Request $request)
			0 ignored issues – show Documentation introduced 2016-12-02 02:52 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
23			{
24			$repositories = \Session::get('GithubRepositories')->whereIn('github_id', $request->repos);
25			foreach ($repositories as $repository) {
26			try{
27			ProductBacklog::create(get_object_vars($repository));
28			} catch (\Illuminate\Database\QueryException $e) {
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-12-02 02:52 UTC by Report Bug Copy Issue Report Consider adding a comment why this CATCH block is empty. Loading history...
29			}
30			}
31
32			return view('wizard.step2')
			0 ignored issues – show Bug introduced 2016-12-02 02:52 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
33			->with('repositories', $repositories)
34			->with('columns', ['repository', 'organization']);
35
36			}
37			}
38

renatomarinho / laravel-gitscrum

Push — master ( 39dbfd...23dd4b )

WizardController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like