for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
/**
* GitScrum v0.1.
*
* @author Renato Marinho <[email protected]>
* @license http://opensource.org/licenses/GPL-3.0 GPLv3
*/
namespace GitScrum\Http\Middleware;
use Closure;
use GitScrum\Models\Sprint;
class GlobalActivities
{
* Handle an incoming request.
* @param \Illuminate\Http\Request $request
* @param \Closure $next
* @return mixed
public function handle($request, Closure $next)
$sprint = Sprint::slug($request->slug)
$sprint
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
$myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; }
Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.
$myVar
$higher
->with('issues.statuses')
->first();
//view()->share('globalActivities', $sprint->activities());
return $next($request);
}
renatomarinho /
laravel-gitscrum
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.