UserStoryController::show() - Code Metrics - renatomarinho/laravel-gitscrum - Measure and Improve Code Quality continuously with Scrutinizer

UserStoryController::show() A
last analyzed 2017-01-12 17:42 UTC

↳ Parent: UserStoryController

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0
cc	1
eloc	6
nc	1
nop	1

<?php
/**
 * GitScrum v0.1.
 *
 * @author  Renato Marinho <[email protected]>
 * @license http://opensource.org/licenses/GPL-3.0 GPLv3
 */

namespace GitScrum\Http\Controllers;

use Illuminate\Http\Request;
use GitScrum\Http\Requests\UserStoryRequest;
use GitScrum\Models\UserStory;
use GitScrum\Models\ConfigPriority;
use GitScrum\Models\ProductBacklog;
use GitScrum\Classes\Helper;
use Auth;

class UserStoryController extends Controller
{
    public function index(Request $request)

    {
        $userStories = Helper::lengthAwarePaginator(Auth::user()->userStories(), $request->page);
        return view('user_stories.index')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with('userStories', $userStories);
    }

    public function create($slug_product_backlog = null)

    {
        $productBacklog_id = null;

        if (!is_null($slug_product_backlog)) {
            $productBacklog_id = ProductBacklog::slug($slug_product_backlog)->first()->id;
        }

        $priorities = ConfigPriority::where('enabled', 1)
            ->orderby('position', 'ASC')->get();

        return view('user_stories.create')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with('productBacklogs', Auth::user()->productBacklogs())
            ->with('productBacklog_id', $productBacklog_id)
            ->with('priorities', $priorities)
            ->with('action', 'Create');
    }

    public function store(UserStoryRequest $request)
    {
        $userStory = UserStory::create($request->all());

        return redirect()->route('user_stories.show', ['slug' => $userStory->slug])
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->with('success', trans('Congratulations! The User Story has been created with successfully'));
    }

    public function show($slug)

    {
        $userStory = UserStory::slug($slug)
            ->with('labels')
            ->first();

        return view('user_stories.show')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with('userStory', $userStory);
    }

    public function edit($slug)

    {
        $userStory = UserStory::slug($slug)->first();

        $priorities = ConfigPriority::where('enabled', 1)
            ->orderby('position', 'ASC')->get();

        return view('user_stories.edit')
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->with('productBacklogs', Auth::user()->productBacklogs())
            ->with('userStory', $userStory)
            ->with('productBacklog_id', $userStory->product_backlog_id)
            ->with('priorities', $priorities)
            ->with('action', 'Edit');
    }

    public function update(UserStoryRequest $request, $slug)
    {
        $userStory = UserStory::slug($slug)->first();
        $userStory->update($request->all());

        return back()
            ->with('success', trans('Congratulations! The User Story has been edited with successfully'));
    }

    public function destroy(Request $request)
    {
        $userStory = UserStory::slug($request->slug)->firstOrFail();
        $userStory->delete();

        return redirect()->route('product_backlogs.index');
    }
}


1			<?php
2			/**
3			* GitScrum v0.1.
4			*
5			* @author Renato Marinho <[email protected]>
6			* @license http://opensource.org/licenses/GPL-3.0 GPLv3
7			*/
8
9			namespace GitScrum\Http\Controllers;
10
11			use Illuminate\Http\Request;
12			use GitScrum\Http\Requests\UserStoryRequest;
13			use GitScrum\Models\UserStory;
14			use GitScrum\Models\ConfigPriority;
15			use GitScrum\Models\ProductBacklog;
16			use GitScrum\Classes\Helper;
17			use Auth;
18
19			class UserStoryController extends Controller
20			{
21			public function index(Request $request)
			0 ignored issues – show Documentation introduced 2017-01-10 20:09 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
22			{
23			$userStories = Helper::lengthAwarePaginator(Auth::user()->userStories(), $request->page);
24			return view('user_stories.index')
			0 ignored issues – show Bug introduced 2017-01-10 20:09 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
25			->with('userStories', $userStories);
26			}
27
28			public function create($slug_product_backlog = null)
			0 ignored issues – show Documentation introduced 2017-01-02 19:28 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
29			{
30			$productBacklog_id = null;
31
32			if (!is_null($slug_product_backlog)) {
33			$productBacklog_id = ProductBacklog::slug($slug_product_backlog)->first()->id;
34			}
35
36			$priorities = ConfigPriority::where('enabled', 1)
37			->orderby('position', 'ASC')->get();
38
39			return view('user_stories.create')
			0 ignored issues – show Bug introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
40			->with('productBacklogs', Auth::user()->productBacklogs())
41			->with('productBacklog_id', $productBacklog_id)
42			->with('priorities', $priorities)
43			->with('action', 'Create');
44			}
45
46			public function store(UserStoryRequest $request)
47			{
48			$userStory = UserStory::create($request->all());
49
50			return redirect()->route('user_stories.show', ['slug' => $userStory->slug])
			0 ignored issues – show Documentation introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report The property `slug` does not exist on `object<GitScrum\Models\UserStory>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
51			->with('success', trans('Congratulations! The User Story has been created with successfully'));
52			}
53
54			public function show($slug)
			0 ignored issues – show Documentation introduced 2017-01-02 19:28 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
55			{
56			$userStory = UserStory::slug($slug)
57			->with('labels')
58			->first();
59
60			return view('user_stories.show')
			0 ignored issues – show Bug introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
61			->with('userStory', $userStory);
62			}
63
64			public function edit($slug)
			0 ignored issues – show Documentation introduced 2017-01-02 19:28 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
65			{
66			$userStory = UserStory::slug($slug)->first();
67
68			$priorities = ConfigPriority::where('enabled', 1)
69			->orderby('position', 'ASC')->get();
70
71			return view('user_stories.edit')
			0 ignored issues – show Bug introduced 2016-11-26 09:47 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
72			->with('productBacklogs', Auth::user()->productBacklogs())
73			->with('userStory', $userStory)
74			->with('productBacklog_id', $userStory->product_backlog_id)
75			->with('priorities', $priorities)
76			->with('action', 'Edit');
77			}
78
79			public function update(UserStoryRequest $request, $slug)
80			{
81			$userStory = UserStory::slug($slug)->first();
82			$userStory->update($request->all());
83
84			return back()
85			->with('success', trans('Congratulations! The User Story has been edited with successfully'));
86			}
87
88			public function destroy(Request $request)
89			{
90			$userStory = UserStory::slug($request->slug)->firstOrFail();
91			$userStory->delete();
92
93			return redirect()->route('product_backlogs.index');
94			}
95			}
96

renatomarinho / laravel-gitscrum

UserStoryController::show() A last analyzed 2017-01-12 17:42 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

UserStoryController::show() A
last analyzed 2017-01-12 17:42 UTC