remotelyliving / php-dns

src/Observability/Traits/Profileable.php

<?php

namespace RemotelyLiving\PHPDNS\Observability\Traits;

use RemotelyLiving\PHPDNS\Observability\Performance\Profile;
use RemotelyLiving\PHPDNS\Observability\Performance\ProfileFactory;

trait Profileable
{
    private ?ProfileFactory $profileFactory = null;

    public function createProfile(string $transactionName): Profile
    {
        return $this->getProfileFactory()->create($transactionName);
    }

    public function setProfileFactory(ProfileFactory $profileFactory): void
    {
        $this->profileFactory = $profileFactory;
    }

    private function getProfileFactory(): ProfileFactory
    {
        if ($this->profileFactory === null) {
            $this->profileFactory = new ProfileFactory();
        }

        return $this->profileFactory;

The expression return $this->profileFactory could return the type null which is incompatible with the type-hinted return RemotelyLiving\PHPDNS\Observability\Performance\ProfileFactory. Consider adding an additional type-check to rule them out.

    }
}