RemotelyLiving\PHPDNS\Mappers\GoogleDNS::toDNSRecord()

Complexity

Conditions	5
Paths	16

Size

Total Lines	18
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function toDNSRecord(): DNSRecordInterface
    {
        $type = DNSRecordType::createFromInt((int) $this->fields['type']);
        $IPAddress = (isset($this->fields[self::DATA]) && IPAddress::isValid($this->fields[self::DATA]))
            ? $this->fields[self::DATA]
            : null;

        $value = (isset($this->fields[self::DATA]) && !$IPAddress)
            ? str_ireplace('"', '', (string)$this->fields[self::DATA])
            : null;

        return DNSRecord::createFromPrimitives(
            (string)$type,
            $this->fields['name'],
            $this->fields['TTL'],
            $IPAddress,
            'IN',
            $value

It seems like $value can also be of type array; however, parameter $data of RemotelyLiving\PHPDNS\Entities\DNSRecord::createFromPrimitives() does only seem to accept null|string, maybe add an additional type check?

        );