Issues in ReserveRoom.php (master) - Issues in master - remotelyliving/php-command-bus - Measure and Improve Code Quality continuously with Scrutinizer

Issues (5)

tests/Stubs/Handlers/ReserveRoom.php (1 issue)

Labels

Best Practice 1
Bug 1

Severity

Major 1

<?php

declare(strict_types=1);

namespace RemotelyLiving\PHPCommandBus\Tests\Stubs\Handlers;

use RemotelyLiving\PHPCommandBus\Interfaces;
use RemotelyLiving\PHPCommandBus\Tests\Stubs\Commands;
use RemotelyLiving\PHPCommandBus\Tests\Stubs\Events;

class ReserveRoom implements Interfaces\Handler
{
    public function handle(object $command, Interfaces\CommandBus $bus)
    {
        \assert(($command instanceof Commands\ReserveRoom), 'Command is instance of ReserveRoom');

        yield new Events\RoomWasReserved();
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace RemotelyLiving\PHPCommandBus\Tests\Stubs\Handlers;
6
7			use RemotelyLiving\PHPCommandBus\Interfaces;
8			use RemotelyLiving\PHPCommandBus\Tests\Stubs\Commands;
9			use RemotelyLiving\PHPCommandBus\Tests\Stubs\Events;
10
11			class ReserveRoom implements Interfaces\Handler
12			{
13			public function handle(object $command, Interfaces\CommandBus $bus)
14			{
15			\assert(($command instanceof Commands\ReserveRoom), 'Command is instance of ReserveRoom');
16
17			yield new Events\RoomWasReserved();
			0 ignored issues – show Bug Best Practice introduced 2020-05-16 20:44 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `yield new RemotelyLiving...vents\RoomWasReserved()` returns the type `Generator` which is incompatible with the return type mandated by `RemotelyLiving\PHPComman...faces\Handler::handle()` of `iterable\|null`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
18			}
19			}
20

remotelyliving / php-command-bus

Issues (5)

tests/Stubs/Handlers/ReserveRoom.php (1 issue)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like