remotelyliving / doorkeeper

src/Rules/AbstractRule.php

<?php

declare(strict_types=1);

namespace RemotelyLiving\Doorkeeper\Rules;

use RemotelyLiving\Doorkeeper\Identification;
use RemotelyLiving\Doorkeeper\RequestorInterface;

abstract class AbstractRule implements RuleInterface
{
    /**
     * @var \RemotelyLiving\Doorkeeper\Rules\RuleInterface[]
     */
    private $prerequisites = [];

    final public function addPrerequisite(RuleInterface $rule): void
    {
        $this->prerequisites[] = $rule;
    }

    final public function hasPrerequisites(): bool
    {
        return (bool) $this->prerequisites;
    }

    final public function getPrerequisites(): iterable
    {
        return $this->prerequisites;
    }

    public function getValue()
    {
        return null;
    }

    final public function canBeSatisfied(RequestorInterface $requestor = null): bool
    {
        if ($this->hasPrerequisites()) {
            foreach ($this->prerequisites as $prerequisite) {
                if (!$prerequisite->canBeSatisfied($requestor)) {
                    return false;
                }
            }
        }

        return $this->childCanBeSatisfied($requestor);
    }

    public function jsonSerialize(): array
    {
        return [
            'type' => static::class,
            'value' => $this->getValue(),

Are you sure the usage of $this->getValue() targeting RemotelyLiving\Doorkeeper\Rules\AbstractRule::getValue() seems to always return null.

            'prerequisites' => $this->prerequisites,
        ];
    }

    protected function requestorHasMatchingId(
        RequestorInterface $requestor = null,
        Identification\IdentificationInterface $identification
    ): bool {
        if (!$requestor) {
            return false;
        }

        return $requestor->hasIdentification($identification);
    }

    abstract protected function childCanBeSatisfied(RequestorInterface $requestor = null): bool;
}