AbstractIdentification::__construct() - Code Metrics - Inspection of "Use PHP 7.4 Syntax, Cleanup" - remotelyliving/doorkeeper - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1)

by Christian

created 2020-05-02 22:00 UTC

AbstractIdentification::__construct() A

↳ Parent: AbstractIdentification

Complexity

Conditions	3
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	3
eloc	6
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	11
rs	10

<?php

declare(strict_types=1);

namespace RemotelyLiving\Doorkeeper\Identification;

abstract class AbstractIdentification implements IdentificationInterface
{
    /**
     * @var string|int
     */
    private $identifier;

    private string $identityHash;

    private string $type;

    /**
     * @param string|int $identifier
     */
    final public function __construct($identifier)
    {
        if (!is_scalar($identifier) || is_bool($identifier)) {

            throw new \InvalidArgumentException('Identifier must be a scalar, alpha numeric value');
        }

        $this->validate($identifier);

        $this->identifier = $identifier;
        $this->type = get_class($this);
        $this->identityHash = self::createIdentityHash($this);
    }

    final public function getIdentifier()
    {
        return $this->identifier;
    }

    final public function getType(): string
    {
        return $this->type;
    }

    final public function equals(IdentificationInterface $identity): bool
    {
        return $this->identityHash === self::createIdentityHash($identity);
    }

    /**
     * @param string|int|float $value
     */
    abstract protected function validate($value): void;

    private static function createIdentityHash(IdentificationInterface $identification): string
    {
        return md5($identification->getType() . (string)$identification->getIdentifier());
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace RemotelyLiving\Doorkeeper\Identification;
6
7			abstract class AbstractIdentification implements IdentificationInterface
8			{
9			/**
10			* @var string\|int
11			*/
12			private $identifier;
13
14			private string $identityHash;
15
16			private string $type;
17
18			/**
19			* @param string\|int $identifier
20			*/
21			final public function __construct($identifier)
22			{
23			if (!is_scalar($identifier) \|\| is_bool($identifier)) {
			0 ignored issues – show introduced 2020-05-02 22:02 UTC by Report Bug Copy Issue Report The condition `is_scalar($identifier)` is always `true`. Loading history... introduced 2020-05-02 22:02 UTC by Report Bug Copy Issue Report The condition `is_bool($identifier)` is always `false`. Loading history...
24			throw new \InvalidArgumentException('Identifier must be a scalar, alpha numeric value');
25			}
26
27			$this->validate($identifier);
28
29			$this->identifier = $identifier;
30			$this->type = get_class($this);
31			$this->identityHash = self::createIdentityHash($this);
32			}
33
34			final public function getIdentifier()
35			{
36			return $this->identifier;
37			}
38
39			final public function getType(): string
40			{
41			return $this->type;
42			}
43
44			final public function equals(IdentificationInterface $identity): bool
45			{
46			return $this->identityHash === self::createIdentityHash($identity);
47			}
48
49			/**
50			* @param string\|int\|float $value
51			*/
52			abstract protected function validate($value): void;
53
54			private static function createIdentityHash(IdentificationInterface $identification): string
55			{
56			return md5($identification->getType() . (string)$identification->getIdentifier());
57			}
58			}
59

remotelyliving / doorkeeper

Pull Request — master (#1)

AbstractIdentification::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like