| Conditions | 14 |
| Paths | 3 |
| Total Lines | 59 |
| Code Lines | 45 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 83 | public function xor(RangeSet $rangeSet, RangeSet $anotherRangeSet): RangeSet |
||
| 84 | { |
||
| 85 | $ranges = $rangeSet->getRanges(); |
||
| 86 | $otherRanges = $anotherRangeSet->getRanges(); |
||
| 87 | $index = 0; |
||
| 88 | $anotherIndex = 0; |
||
| 89 | $newRangeList = []; |
||
| 90 | /** @var Range $rangeBuffer */ |
||
| 91 | $rangeBuffer = null; |
||
| 92 | while (true) { |
||
| 93 | $range = $ranges[$index] ?? null; |
||
| 94 | $anotherRange = $otherRanges[$anotherIndex] ?? null; |
||
| 95 | |||
| 96 | if (isset($range)) { |
||
| 97 | if (isset($anotherRange) && $range->getStart() > $anotherRange->getStart()) { |
||
| 98 | $pickedRange = $anotherRange; |
||
| 99 | $anotherIndex++; |
||
| 100 | } else { |
||
| 101 | $pickedRange = $range; |
||
| 102 | $index++; |
||
| 103 | } |
||
| 104 | } elseif (isset($anotherRange)) { |
||
| 105 | $pickedRange = $anotherRange; |
||
| 106 | $anotherIndex++; |
||
| 107 | } else { |
||
| 108 | if (isset($rangeBuffer)) { |
||
| 109 | $newRangeList[] = $rangeBuffer; |
||
| 110 | } |
||
| 111 | break; |
||
| 112 | } |
||
| 113 | |||
| 114 | if (isset($rangeBuffer)) { |
||
| 115 | if ($rangeBuffer->intersects($pickedRange)) { |
||
| 116 | if ($rangeBuffer->startsBeforeStartOf($pickedRange)) { |
||
| 117 | $newRangeList[] = $rangeBuffer->copyBeforeStartOf($pickedRange); |
||
| 118 | $rangeBuffer = $rangeBuffer->copyAfterStartOf($pickedRange); |
||
| 119 | } elseif ($pickedRange->startsBeforeStartOf($rangeBuffer)) { |
||
| 120 | $newRangeList[] = $pickedRange->copyBeforeStartOf($rangeBuffer); |
||
| 121 | $rangeBuffer = $pickedRange->copyAfterStartOf($rangeBuffer); |
||
| 122 | } |
||
| 123 | if ($rangeBuffer->endsBeforeFinishOf($pickedRange)) { |
||
| 124 | $rangeBuffer = $pickedRange->copyAfterFinishOf($rangeBuffer); |
||
| 125 | } elseif ($pickedRange->endsBeforeFinishOf($rangeBuffer)) { |
||
| 126 | $rangeBuffer = $rangeBuffer->copyAfterFinishOf($pickedRange); |
||
| 127 | } else { |
||
| 128 | $rangeBuffer = null; |
||
| 129 | } |
||
| 130 | continue; |
||
| 131 | } |
||
| 132 | if ($pickedRange->follows($rangeBuffer)) { |
||
| 133 | $rangeBuffer = $rangeBuffer->copyBeforeFinishOf($pickedRange); |
||
| 134 | continue; |
||
| 135 | } |
||
| 136 | $newRangeList[] = $rangeBuffer; |
||
| 137 | } |
||
| 138 | $rangeBuffer = $pickedRange; |
||
| 139 | } |
||
| 140 | |||
| 141 | return RangeSet::loadUnsafe(...$newRangeList); |
||
| 142 | } |
||
| 144 |