| Conditions | 31 |
| Paths | 31 |
| Total Lines | 56 |
| Code Lines | 50 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 23 | public function applyActions(Symbol $symbol, Token $token): void |
||
| 24 | { |
||
| 25 | $this->setContext($symbol, $token); |
||
| 26 | |||
| 27 | switch ($symbol->getSymbolId()) { |
||
| 28 | case SymbolType::T_DIGIT_ZERO: |
||
| 29 | case SymbolType::T_DIGIT_OCT: |
||
| 30 | $this |
||
| 31 | ->copyTokenAttribute('s.code', TokenAttribute::CODE) |
||
| 32 | ->copyTokenAttribute('s.oct_digit', TokenAttribute::DIGIT) |
||
| 33 | ->copyTokenAttribute('s.dec_digit', TokenAttribute::DIGIT) |
||
| 34 | ->copyTokenAttribute('s.hex_digit', TokenAttribute::DIGIT); |
||
| 35 | break; |
||
| 36 | |||
| 37 | case SymbolType::T_DIGIT_DEC: |
||
| 38 | $this |
||
| 39 | ->copyTokenAttribute('s.code', TokenAttribute::CODE) |
||
| 40 | ->copyTokenAttribute('s.dec_digit', TokenAttribute::DIGIT) |
||
| 41 | ->copyTokenAttribute('s.hex_digit', TokenAttribute::DIGIT); |
||
| 42 | break; |
||
| 43 | |||
| 44 | case SymbolType::T_SMALL_C: |
||
| 45 | case SymbolType::T_OTHER_HEX_LETTER: |
||
| 46 | $this |
||
| 47 | ->copyTokenAttribute('s.code', TokenAttribute::CODE) |
||
| 48 | ->copyTokenAttribute('s.hex_digit', TokenAttribute::DIGIT); |
||
| 49 | break; |
||
| 50 | |||
| 51 | case SymbolType::T_COMMA: |
||
| 52 | case SymbolType::T_HYPHEN: |
||
| 53 | case SymbolType::T_CAPITAL_P: |
||
| 54 | case SymbolType::T_RIGHT_SQUARE_BRACKET: |
||
| 55 | case SymbolType::T_SMALL_O: |
||
| 56 | case SymbolType::T_SMALL_P: |
||
| 57 | case SymbolType::T_SMALL_U: |
||
| 58 | case SymbolType::T_SMALL_X: |
||
| 59 | case SymbolType::T_RIGHT_CURLY_BRACKET: |
||
| 60 | case SymbolType::T_CTL_ASCII: |
||
| 61 | case SymbolType::T_PRINTABLE_ASCII_OTHER: |
||
| 62 | case SymbolType::T_NOT_ASCII: |
||
| 63 | case SymbolType::T_DOLLAR: |
||
| 64 | case SymbolType::T_LEFT_BRACKET: |
||
| 65 | case SymbolType::T_RIGHT_BRACKET: |
||
| 66 | case SymbolType::T_STAR: |
||
| 67 | case SymbolType::T_PLUS: |
||
| 68 | case SymbolType::T_QUESTION: |
||
| 69 | case SymbolType::T_LEFT_SQUARE_BRACKET: |
||
| 70 | case SymbolType::T_BACKSLASH: |
||
| 71 | case SymbolType::T_CIRCUMFLEX: |
||
| 72 | case SymbolType::T_LEFT_CURLY_BRACKET: |
||
| 73 | case SymbolType::T_VERTICAL_LINE: |
||
| 74 | case SymbolType::T_DOT: |
||
| 75 | case SymbolType::T_OTHER_ASCII_LETTER: |
||
| 76 | $this |
||
| 77 | ->copyTokenAttribute('s.code', TokenAttribute::CODE); |
||
| 78 | break; |
||
| 79 | } |
||
| 136 |