Remorhaz\JSON\Path\Runtime\Aggregator\MinAggregator

Complexity

Total Complexity

4

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	findElementIndex()	0	5	2
A	aggregateNumericData()	0	9	2

<?php
declare(strict_types=1);

namespace Remorhaz\JSON\Path\Runtime\Aggregator;

use Remorhaz\JSON\Data\Value\ScalarValueInterface;
use Remorhaz\JSON\Data\Value\ValueInterface;
use function array_search;
use function min;

final class MinAggregator extends UniqueNumericAggregator
{

    protected function aggregateNumericData(array $dataList, ScalarValueInterface ...$elements): ?ValueInterface
    {
        $elementIndex = $this->findElementIndex($dataList);
        if (isset($elementIndex, $elements[$elementIndex])) {
            return $elements[$elementIndex];
        }

        // @codeCoverageIgnoreStart
        throw new Exception\MaxElementNotFoundException($dataList, $elements);
        // @codeCoverageIgnoreEnd
    }

    private function findElementIndex(array $dataList): ?int
    {
        $elementIndex = array_search(min($dataList), $dataList, true);

        return false === $elementIndex ? null : $elementIndex;

The expression return false === $elementIndex ? null : $elementIndex could return the type string which is incompatible with the type-hinted return integer|null. Consider adding an additional type-check to rule them out.

    }
}