TwitterExtendedEntity::create()   B
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 34
Code Lines 28

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 17
CRAP Score 1

Importance

Changes 0
Metric Value
dl 0
loc 34
c 0
b 0
f 0
ccs 17
cts 17
cp 1
rs 8.8571
cc 1
eloc 28
nc 1
nop 12
crap 1

How to fix   Many Parameters   

Many Parameters

Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.

There are several approaches to avoid long parameter lists:

1
<?php
2
3
namespace Twitter\Object;
4
5
class TwitterExtendedEntity extends AbstractTwitterMedia
6
{
7
    /**
8
     * @var string
9
     */
10
    private $videoInfo;
11
12
    /**
13
     * @var int
14
     */
15
    private $durationMillis;
16
17
    /**
18
     * @var TwitterVariantMedia[]
19
     */
20
    private $variants;
21
22
    /**
23
     * Constructor.
24
     */
25 9
    public function __construct()
26
    {
27 9
    }
28
29
    /**
30
     * @return int
31
     */
32 9
    public function getDurationMillis()
33
    {
34 9
        return $this->durationMillis;
35
    }
36
37
    /**
38
     * @return TwitterVariantMedia[]
39
     */
40 9
    public function getVariants()
41
    {
42 9
        return $this->variants;
43
    }
44
45
    /**
46
     * @return string
47
     */
48 9
    public function getVideoInfo()
49
    {
50 9
        return $this->videoInfo;
51
    }
52
53
    /**
54
     * Static constructor.
55
     *
56
     * @param int                   $id
57
     * @param string                $mediaUrl
58
     * @param string                $mediaUrlHttps
59
     * @param string                $url
60
     * @param string                $displayUrl
61
     * @param string                $expandedUrl
62
     * @param TwitterMediaSize[]    $sizes
63
     * @param string                $type
64
     * @param string                $videoInfo
65
     * @param int                   $durationMillis
66
     * @param TwitterVariantMedia[] $variants
67
     * @param TwitterEntityIndices  $indices
68
     *
69
     * @return TwitterExtendedEntity
70
     */
71 9
    public static function create(
72
        $id = null,
73
        $mediaUrl = null,
74
        $mediaUrlHttps = null,
75
        $url = null,
76
        $displayUrl = null,
77
        $expandedUrl = null,
78
        array $sizes = [],
79
        $type = null,
80
        $videoInfo = null,
81
        $durationMillis = null,
82
        array $variants = [],
83
        TwitterEntityIndices $indices = null
84
    ) {
85 9
        $obj = new self();
86
87 9
        $obj->initTwitterMedia(
88 9
            $id,
89 9
            $mediaUrl,
90 9
            $mediaUrlHttps,
91 9
            $url,
92 9
            $displayUrl,
93 9
            $expandedUrl,
94 9
            $sizes,
95 9
            $type,
96 3
            $indices
97 6
        );
98
99 9
        $obj->durationMillis = $durationMillis;
100 9
        $obj->variants = $variants;
101 9
        $obj->videoInfo = $videoInfo;
102
103 9
        return $obj;
104
    }
105
}
106