CommandNameExtractor::canExtractName() - Code Metrics - Inspection of "added name extractors" - remi-san/serializer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( cefffc...119892 )

by Rémi

created 2016-05-26 18:13 UTC

CommandNameExtractor::canExtractName() A

↳ Parent: CommandNameExtractor

Complexity

Conditions	2
Paths	2

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	4
ccs	0
cts	2
cp	0
rs	10
cc	2
eloc	2
nc	2
nop	1
crap	6

<?php

namespace RemiSan\Serializer\NameExtractor\Tactician;

use League\Tactician\Plugins\NamedCommand\NamedCommand;
use RemiSan\Serializer\SerializableClassNameExtractor;

class CommandNameExtractor implements SerializableClassNameExtractor
{
    /**
     * @param  string $class
     * @return string
     */
    public function extractName($class)
    {
        if (! $this->canExtractName($class)) {
            throw new \InvalidArgumentException();
        }

        return $class::NAME;
    }

    /**
     * @param  string $class
     * @return bool
     */
    public function canExtractName($class)
    {
        return is_subclass_of($class, NamedCommand::class) && defined($class::NAME);

    }
}


1			<?php
2
3			namespace RemiSan\Serializer\NameExtractor\Tactician;
4
5			use League\Tactician\Plugins\NamedCommand\NamedCommand;
6			use RemiSan\Serializer\SerializableClassNameExtractor;
7
8			class CommandNameExtractor implements SerializableClassNameExtractor
9			{
10			/**
11			* @param string $class
12			* @return string
13			*/
14			public function extractName($class)
15			{
16			if (! $this->canExtractName($class)) {
17			throw new \InvalidArgumentException();
18			}
19
20			return $class::NAME;
21			}
22
23			/**
24			* @param string $class
25			* @return bool
26			*/
27			public function canExtractName($class)
28			{
29			return is_subclass_of($class, NamedCommand::class) && defined($class::NAME);
			0 ignored issues – show Bug introduced 2016-05-26 18:17 UTC by Report Bug Copy Issue Report Due to PHP Bug #53727, `is_subclass_of` might return inconsistent results on some PHP versions if `\League\Tactician\Plugin...and\NamedCommand::class` can be an interface. If so, you could instead use `ReflectionClass::implementsInterface`. Loading history...
30			}
31			}
32

remi-san / serializer

GitHub Access Token became invalid

Push — master ( cefffc...119892 )

CommandNameExtractor::canExtractName() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like