MessageFactory::buildMessage() - Code Metrics - Inspection of "refactored message cration" - remi-san/mini-game-message-app - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ee19ca...fc64c3 )

by Rémi

created 2016-06-06 19:49 UTC

MessageFactory::buildMessage() A

↳ Parent: MessageFactory

Complexity

Conditions	4
Paths	3

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	16
ccs	8
cts	8
cp	1
rs	9.2
cc	4
eloc	8
nc	3
nop	3
crap	4

<?php

namespace MiniGameMessageApp\Message;

use MessageApp\Message\DefaultMessage;
use MessageApp\User\ApplicationUser;
use MessageApp\User\UndefinedApplicationUser;

class MessageFactory
{
    /**
     * @var MessageTextExtractor
     */
    private $extractor;

    /**
     * Constructor.
     *
     * @param MessageTextExtractor $extractor
     */
    public function __construct(MessageTextExtractor $extractor)
    {
        $this->extractor = $extractor;
    }

    /**
     * @param  ApplicationUser[] $users
     * @param  object            $object
     * @param  string            $language
     * @return DefaultMessage
     */
    public function buildMessage(array $users, $object, $language = null)
    {
        $filteredUsers = self::filterUsers($users);

        if (count($filteredUsers) === 0) {
            return null;
        }

        $messageText = $this->extractor->extractMessage($object, ($language) ? : self::getLanguage($filteredUsers));

        if ($messageText === null) {
            return null;
        }

        return new DefaultMessage($filteredUsers, $messageText);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    /**
     * @param  ApplicationUser[] $users
     * @return ApplicationUser[]
     */
    private static function filterUsers(array $users)
    {
        return array_values(
            array_unique(
                array_filter($users, function (ApplicationUser $user = null) {
                    return $user !== null && !$user instanceof UndefinedApplicationUser;
                })
            )
        );
    }

    /**
     * @param  ApplicationUser[] $users
     * @return string
     */
    private static function getLanguage(array $users)
    {
        return $users[0]->getPreferredLanguage();
    }
}


1		<?php
2
3		namespace MiniGameMessageApp\Message;
4
5		use MessageApp\Message\DefaultMessage;
6		use MessageApp\User\ApplicationUser;
7		use MessageApp\User\UndefinedApplicationUser;
8
9		class MessageFactory
10		{
11		/**
12		* @var MessageTextExtractor
13		*/
14		private $extractor;
15
16		/**
17		* Constructor.
18		*
19		* @param MessageTextExtractor $extractor
20		*/
21	18	public function __construct(MessageTextExtractor $extractor)
22		{
23	18	$this->extractor = $extractor;
24	18	}
25
26		/**
27		* @param ApplicationUser[] $users
28		* @param object $object
29		* @param string $language
30		* @return DefaultMessage
31		*/
32	18	public function buildMessage(array $users, $object, $language = null)
33		{
34	18	$filteredUsers = self::filterUsers($users);
35
36	18	if (count($filteredUsers) === 0) {
37	9	return null;
38		}
39
40	9	$messageText = $this->extractor->extractMessage($object, ($language) ? : self::getLanguage($filteredUsers));
41
42	9	if ($messageText === null) {
43	3	return null;
44		}
45
46	6	return new DefaultMessage($filteredUsers, $messageText);
		0 ignored issues – show Documentation introduced 2016-06-06 19:53 UTC by Report Bug Copy Issue Report `$filteredUsers` is of type `array<integer,object<Mes...\User\ApplicationUser>>`, but the function expects a `object<MessageApp\User\ApplicationUser>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
47		}
48
49		/**
50		* @param ApplicationUser[] $users
51		* @return ApplicationUser[]
52		*/
53	18	private static function filterUsers(array $users)
54		{
55	18	return array_values(
56	12	array_unique(
57	18	array_filter($users, function (ApplicationUser $user = null) {
58	15	return $user !== null && !$user instanceof UndefinedApplicationUser;
59	18	})
60	12	)
61	12	);
62		}
63
64		/**
65		* @param ApplicationUser[] $users
66		* @return string
67		*/
68	3	private static function getLanguage(array $users)
69		{
70	3	return $users[0]->getPreferredLanguage();
71		}
72		}
73

remi-san / mini-game-message-app

Push — master ( ee19ca...fc64c3 )

MessageFactory::buildMessage() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like