MessageFactory::buildMessage() - Code Metrics - Inspection of "moved classes from mini-game-message-app" - remi-san/message-app - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b21c9c...b94996 )

by Rémi

created 2016-06-06 20:12 UTC

MessageFactory::buildMessage() A

↳ Parent: MessageFactory

Complexity

Conditions	4
Paths	3

Size

Total Lines	16
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	16
ccs	8
cts	8
cp	1
rs	9.2
cc	4
eloc	8
nc	3
nop	3
crap	4

<?php

namespace MessageApp\Message;

use MessageApp\User\ApplicationUser;
use MessageApp\User\UndefinedApplicationUser;

class MessageFactory
{
    /**
     * @var MessageTextExtractor
     */
    private $extractor;

    /**
     * Constructor.
     *
     * @param MessageTextExtractor $extractor
     */
    public function __construct(MessageTextExtractor $extractor)
    {
        $this->extractor = $extractor;
    }

    /**
     * @param  ApplicationUser[] $users
     * @param  object            $object
     * @param  string            $language
     * @return DefaultMessage
     */
    public function buildMessage(array $users, $object, $language = null)
    {
        $filteredUsers = self::filterUsers($users);

        if (count($filteredUsers) === 0) {
            return null;
        }

        $messageText = $this->extractor->extractMessage($object, ($language) ? : self::getLanguage($filteredUsers));

        if ($messageText === null) {
            return null;
        }

        return new DefaultMessage($filteredUsers, $messageText);
    }

    /**
     * @param  ApplicationUser[] $users
     * @return ApplicationUser[]
     */
    private static function filterUsers(array $users)
    {
        return array_values(
            array_unique(
                array_filter($users, function (ApplicationUser $user = null) {
                    return $user !== null && !$user instanceof UndefinedApplicationUser;
                })
            )
        );
    }

    /**
     * @param  ApplicationUser[] $users
     * @return string
     */
    private static function getLanguage(array $users)
    {
        return $users[0]->getPreferredLanguage();
    }
}


1		<?php
2
3		namespace MessageApp\Message;
4
5		use MessageApp\User\ApplicationUser;
6		use MessageApp\User\UndefinedApplicationUser;
7
8		class MessageFactory
9		{
10		/**
11		* @var MessageTextExtractor
12		*/
13		private $extractor;
14
15		/**
16		* Constructor.
17		*
18		* @param MessageTextExtractor $extractor
19		*/
20	18	public function __construct(MessageTextExtractor $extractor)
21		{
22	18	$this->extractor = $extractor;
23	18	}
24
25		/**
26		* @param ApplicationUser[] $users
27		* @param object $object
28		* @param string $language
29		* @return DefaultMessage
30		*/
31	18	public function buildMessage(array $users, $object, $language = null)
32		{
33	18	$filteredUsers = self::filterUsers($users);
34
35	18	if (count($filteredUsers) === 0) {
36	9	return null;
37		}
38
39	9	$messageText = $this->extractor->extractMessage($object, ($language) ? : self::getLanguage($filteredUsers));
40
41	9	if ($messageText === null) {
42	3	return null;
43		}
44
45	6	return new DefaultMessage($filteredUsers, $messageText);
46		}
47
48		/**
49		* @param ApplicationUser[] $users
50		* @return ApplicationUser[]
51		*/
52	18	private static function filterUsers(array $users)
53		{
54	18	return array_values(
55	12	array_unique(
56	18	array_filter($users, function (ApplicationUser $user = null) {
57	15	return $user !== null && !$user instanceof UndefinedApplicationUser;
58	18	})
59	12	)
60	12	);
61		}
62
63		/**
64		* @param ApplicationUser[] $users
65		* @return string
66		*/
67	3	private static function getLanguage(array $users)
68		{
69	3	return $users[0]->getPreferredLanguage();
70		}
71		}
72

remi-san / message-app

Push — master ( b21c9c...b94996 )

MessageFactory::buildMessage() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like