RedisConnection::getDrift() - Code Metrics - Inspection of "Implementation of connection abstraction" - remi-san/lock - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 650429...b2d98c )

by Rémi

created 2016-08-31 13:24 UTC

RedisConnection::getDrift() A

↳ Parent: RedisConnection

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	10
ccs	3
cts	3
cp	1
rs	9.4285
cc	2
eloc	3
nc	2
nop	1
crap	2

<?php

namespace RemiSan\Lock\Connection;

use RemiSan\Lock\Connection;
use RemiSan\Lock\Lock;

class RedisConnection implements Connection
{
    /** @var float */
    const CLOCK_DRIFT_FACTOR = 0.01;
    
    /** @var int */
    const REDIS_EXPIRES_PRECISION = 2;

    /** @var \Redis */
    private $redis;

    /**
     * RedisConnection constructor.
     *
     * @param \Redis $redis
     */
    public function __construct(\Redis $redis)
    {
        if (! $redis->isConnected()) {
            throw new \InvalidArgumentException('The Redis instance must be connected.');
        }
        $this->redis = $redis;
    }
    /**
     * @inheritDoc
     */
    public function set(Lock $lock, $ttl = null)
    {
        $options = ['NX'];

        if ($ttl) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $options['PX'] = (int) $ttl;
        }

        return (bool) $this->redis->set($lock->getResource(), (string) $lock->getToken(), $options);
    }

    /**
     * @inheritDoc
     */
    public function exists($resource)
    {
        return (bool) $this->redis->get($resource);
    }

    /**
     * @inheritDoc
     */
    public function delete(Lock $lock)
    {
        $script = '
            if redis.call("GET", KEYS[1]) == ARGV[1] then
                return redis.call("DEL", KEYS[1])
            else
                return 0
            end
        ';

        return (bool) $this->redis->evaluate(
            $script,
            [$lock->getResource(), (string) $lock->getToken()],
            1
        );
    }

    /**
     * @inheritDoc
     */
    public function getDrift($ttl)
    {
        // Add 2 milliseconds to the drift to account for Redis expires
        // precision, which is 1 millisecond, plus 1 millisecond min drift
        // for small TTLs.
        
        $minDrift = ($ttl) ? (int) ceil($ttl * self::CLOCK_DRIFT_FACTOR) : 0;

        return $minDrift + self::REDIS_EXPIRES_PRECISION;
    }
}


1		<?php
2
3		namespace RemiSan\Lock\Connection;
4
5		use RemiSan\Lock\Connection;
6		use RemiSan\Lock\Lock;
7
8		class RedisConnection implements Connection
9		{
10		/** @var float */
11		const CLOCK_DRIFT_FACTOR = 0.01;
12
13		/** @var int */
14		const REDIS_EXPIRES_PRECISION = 2;
15
16		/** @var \Redis */
17		private $redis;
18
19		/**
20		* RedisConnection constructor.
21		*
22		* @param \Redis $redis
23		*/
24	24	public function __construct(\Redis $redis)
25		{
26	24	if (! $redis->isConnected()) {
27	3	throw new \InvalidArgumentException('The Redis instance must be connected.');
28		}
29	24	$this->redis = $redis;
30	24	}
31		/**
32		* @inheritDoc
33		*/
34	6	public function set(Lock $lock, $ttl = null)
35		{
36	6	$options = ['NX'];
37
38	6	if ($ttl) {
		0 ignored issues – show Bug Best Practice introduced 2016-08-31 13:26 UTC by Report Bug Copy Issue Report The expression `$ttl` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
39	3	$options['PX'] = (int) $ttl;
40	2	}
41
42	6	return (bool) $this->redis->set($lock->getResource(), (string) $lock->getToken(), $options);
43		}
44
45		/**
46		* @inheritDoc
47		*/
48	6	public function exists($resource)
49		{
50	6	return (bool) $this->redis->get($resource);
51		}
52
53		/**
54		* @inheritDoc
55		*/
56	6	public function delete(Lock $lock)
57		{
58		$script = '
59		if redis.call("GET", KEYS[1]) == ARGV[1] then
60		return redis.call("DEL", KEYS[1])
61		else
62		return 0
63		end
64	6	';
65
66	6	return (bool) $this->redis->evaluate(
67	4	$script,
68	6	[$lock->getResource(), (string) $lock->getToken()],
69	2	1
70	4	);
71		}
72
73		/**
74		* @inheritDoc
75		*/
76	3	public function getDrift($ttl)
77		{
78		// Add 2 milliseconds to the drift to account for Redis expires
79		// precision, which is 1 millisecond, plus 1 millisecond min drift
80		// for small TTLs.
81
82	3	$minDrift = ($ttl) ? (int) ceil($ttl * self::CLOCK_DRIFT_FACTOR) : 0;
83
84	3	return $minDrift + self::REDIS_EXPIRES_PRECISION;
85		}
86		}
87

remi-san / lock

GitHub Access Token became invalid

Push — master ( 650429...b2d98c )

RedisConnection::getDrift() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like