RecursiveSerializer::deserialize() - Code Metrics - remi-san/broadway-tools - Measure and Improve Code Quality continuously with Scrutinizer

RecursiveSerializer::deserialize() A
last analyzed 2019-07-11 08:16 UTC

↳ Parent: RecursiveSerializer

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	1

<?php

namespace Broadway\Tools\Metadata\Serializer;

use Broadway\Serializer\SerializationException;
use Broadway\Serializer\Serializer as BroadwaySerializer;
use RemiSan\Serializer\Serializer;

class RecursiveSerializer implements BroadwaySerializer
{
    /**
     * @var Serializer
     */
    private $serializer;
    /**
     * Constructor.
     *
     * @param Serializer $serializer
     */
    public function __construct(Serializer $serializer)
    {
        $this->serializer = $serializer;
    }

    /**
     * @param $object
     * @throws SerializationException
     * @return array
     */
    public function serialize($object)
    {
        return $this->serializer->serialize($object);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * @param array $serializedObject
     * @throws SerializationException
     * @return mixed
     */
    public function deserialize(array $serializedObject)
    {
        return $this->serializer->deserialize($serializedObject);
    }
}


1		<?php
2
3		namespace Broadway\Tools\Metadata\Serializer;
4
5		use Broadway\Serializer\SerializationException;
6		use Broadway\Serializer\Serializer as BroadwaySerializer;
7		use RemiSan\Serializer\Serializer;
8
9		class RecursiveSerializer implements BroadwaySerializer
10		{
11		/**
12		* @var Serializer
13		*/
14		private $serializer;
15		/**
16		* Constructor.
17		*
18		* @param Serializer $serializer
19		*/
20	6	public function __construct(Serializer $serializer)
21		{
22	6	$this->serializer = $serializer;
23	6	}
24
25		/**
26		* @param $object
27		* @throws SerializationException
28		* @return array
29		*/
30	3	public function serialize($object)
31		{
32	3	return $this->serializer->serialize($object);
		0 ignored issues – show Bug Best Practice introduced 2017-03-22 21:26 UTC by Report Bug Copy Issue Report The return type of `return $this->serializer->serialize($object);` (`array\|integer\|double\|string\|null\|boolean`) is incompatible with the return type declared by the interface `Broadway\Serializer\Serializer::serialize` of type `array`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
33		}
34
35		/**
36		* @param array $serializedObject
37		* @throws SerializationException
38		* @return mixed
39		*/
40	3	public function deserialize(array $serializedObject)
41		{
42	3	return $this->serializer->deserialize($serializedObject);
43		}
44		}
45

remi-san / broadway-tools

GitHub Access Token became invalid

RecursiveSerializer::deserialize() A last analyzed 2019-07-11 08:16 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

RecursiveSerializer::deserialize() A
last analyzed 2019-07-11 08:16 UTC