MessageTransformer::includeThread() - Code Metrics - reliqarts/mardin - Measure and Improve Code Quality continuously with Scrutinizer

MessageTransformer::includeThread() A
last analyzed 2018-08-03 18:37 UTC

↳ Parent: MessageTransformer

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	10
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace ReliQArts\Mardin\Transformers;

use Carbon\Carbon;
use ReliQArts\Mardin\Contracts\Thread;
use League\Fractal\TransformerAbstract;
use ReliQArts\Mardin\Contracts\Message;
use ReliQArts\Mardin\Helpers\StringHelper;
use ReliQArts\Mardin\Contracts\UserTransformer;

class MessageTransformer extends TransformerAbstract
{
    /**
     * List of resources available to include.
     *
     * @var array
     */
    protected $availableIncludes = [
        'thread',
    ];

    /**
     * List of resources to automatically include.
     *
     * @var array
     */
    protected $defaultIncludes = [
        'sender',
    ];

    /**
     * Transform the data.
     * @return array API suitable information.
     */
    public function transform(Message $message)
    {
        return [
            'id' => (int) $message->id,
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            'thread_id' => $message->thread_id,
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            'thread_url' => route('show-message', ['id' => $message->thread->id]),
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            'sender_id' => $message->user_id,
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            'sender_name' => $message->user->name,
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            'body' => $message->body,
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            'deleted' => $message->deleted_at,
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            'created_at' => StringHelper::date(Carbon::createFromFormat('Y-n-j G:i:s', $message->created_at)),
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            'created_at_raw' => $message->created_at,
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            'updated_at' => $message->updated_at ? StringHelper::date(Carbon::createFromFormat('Y-n-j G:i:s', $message->updated_at)) : 'N/A',
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            'updated_at_raw' => $message->updated_at,
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
        ];
    }

    /**
     * Include Sender.
     *
     * @param Message $message
     * @return \League\Fractal\Resource\Item

     */
    public function includeSender(Message $message)
    {
        $userTransformer = app()->make(UserTransformer::class);
        if ($user = $message->user) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            return $this->item($user, $userTransformer);
        }
    }

    /**
     * Include Thread.
     *
     * @param Message $message
     * @return \League\Fractal\Resource\Item

     */
    public function includeThread(Message $message)
    {
        if ($thread = $message->thread) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
            return $this->item($thread, new ThreadTransformer);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
    }
}


1			<?php
2
3			namespace ReliQArts\Mardin\Transformers;
4
5			use Carbon\Carbon;
6			use ReliQArts\Mardin\Contracts\Thread;
7			use League\Fractal\TransformerAbstract;
8			use ReliQArts\Mardin\Contracts\Message;
9			use ReliQArts\Mardin\Helpers\StringHelper;
10			use ReliQArts\Mardin\Contracts\UserTransformer;
11
12			class MessageTransformer extends TransformerAbstract
13			{
14			/**
15			* List of resources available to include.
16			*
17			* @var array
18			*/
19			protected $availableIncludes = [
20			'thread',
21			];
22
23			/**
24			* List of resources to automatically include.
25			*
26			* @var array
27			*/
28			protected $defaultIncludes = [
29			'sender',
30			];
31
32			/**
33			* Transform the data.
34			* @return array API suitable information.
35			*/
36			public function transform(Message $message)
37			{
38			return [
39			'id' => (int) $message->id,
			0 ignored issues – show Bug introduced 2017-04-12 04:49 UTC by Report Bug Copy Issue Report Accessing `id` on the interface `ReliQArts\Mardin\Contracts\Message` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
40			'thread_id' => $message->thread_id,
			0 ignored issues – show Bug introduced 2017-04-12 04:49 UTC by Report Bug Copy Issue Report Accessing `thread_id` on the interface `ReliQArts\Mardin\Contracts\Message` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
41			'thread_url' => route('show-message', ['id' => $message->thread->id]),
			0 ignored issues – show Bug introduced 2017-04-12 04:49 UTC by Report Bug Copy Issue Report Accessing `thread` on the interface `ReliQArts\Mardin\Contracts\Message` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
42			'sender_id' => $message->user_id,
			0 ignored issues – show Bug introduced 2017-04-12 04:49 UTC by Report Bug Copy Issue Report Accessing `user_id` on the interface `ReliQArts\Mardin\Contracts\Message` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
43			'sender_name' => $message->user->name,
			0 ignored issues – show Bug introduced 2017-04-12 04:49 UTC by Report Bug Copy Issue Report Accessing `user` on the interface `ReliQArts\Mardin\Contracts\Message` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
44			'body' => $message->body,
			0 ignored issues – show Bug introduced 2017-04-12 04:49 UTC by Report Bug Copy Issue Report Accessing `body` on the interface `ReliQArts\Mardin\Contracts\Message` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
45			'deleted' => $message->deleted_at,
			0 ignored issues – show Bug introduced 2017-04-12 04:49 UTC by Report Bug Copy Issue Report Accessing `deleted_at` on the interface `ReliQArts\Mardin\Contracts\Message` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
46			'created_at' => StringHelper::date(Carbon::createFromFormat('Y-n-j G:i:s', $message->created_at)),
			0 ignored issues – show Bug introduced 2017-04-12 04:49 UTC by Report Bug Copy Issue Report Accessing `created_at` on the interface `ReliQArts\Mardin\Contracts\Message` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
47			'created_at_raw' => $message->created_at,
			0 ignored issues – show Bug introduced 2017-04-12 04:49 UTC by Report Bug Copy Issue Report Accessing `created_at` on the interface `ReliQArts\Mardin\Contracts\Message` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
48			'updated_at' => $message->updated_at ? StringHelper::date(Carbon::createFromFormat('Y-n-j G:i:s', $message->updated_at)) : 'N/A',
			0 ignored issues – show Bug introduced 2017-04-12 04:49 UTC by Report Bug Copy Issue Report Accessing `updated_at` on the interface `ReliQArts\Mardin\Contracts\Message` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Coding Style introduced 2017-04-12 04:49 UTC by Report Bug Copy Issue Report This line exceeds maximum limit of 120 characters; contains 141 characters Overly long lines are hard to read on any screen. Most code styles therefor impose a maximum limit on the number of characters in a line. Loading history...
49			'updated_at_raw' => $message->updated_at,
			0 ignored issues – show Bug introduced 2017-04-12 04:49 UTC by Report Bug Copy Issue Report Accessing `updated_at` on the interface `ReliQArts\Mardin\Contracts\Message` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
50			];
51			}
52
53			/**
54			* Include Sender.
55			*
56			* @param Message $message
57			* @return \League\Fractal\Resource\Item
			0 ignored issues – show Documentation introduced 2017-04-12 04:49 UTC by Report Bug Copy Issue Report Should the return type not be `\League\Fractal\Resource\Item\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
58			*/
59			public function includeSender(Message $message)
60			{
61			$userTransformer = app()->make(UserTransformer::class);
62			if ($user = $message->user) {
			0 ignored issues – show Bug introduced 2017-04-12 04:49 UTC by Report Bug Copy Issue Report Accessing `user` on the interface `ReliQArts\Mardin\Contracts\Message` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
63			return $this->item($user, $userTransformer);
64			}
65			}
66
67			/**
68			* Include Thread.
69			*
70			* @param Message $message
71			* @return \League\Fractal\Resource\Item
			0 ignored issues – show Documentation introduced 2017-04-12 04:49 UTC by Report Bug Copy Issue Report Should the return type not be `\League\Fractal\Resource\Item\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
72			*/
73			public function includeThread(Message $message)
74			{
75			if ($thread = $message->thread) {
			0 ignored issues – show Bug introduced 2017-04-12 04:49 UTC by Report Bug Copy Issue Report Accessing `thread` on the interface `ReliQArts\Mardin\Contracts\Message` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
76			return $this->item($thread, new ThreadTransformer);
			0 ignored issues – show Documentation introduced 2017-04-12 04:49 UTC by Report Bug Copy Issue Report `new \ReliQArts\Mardin\Tr...ers\ThreadTransformer()` is of type `object<ReliQArts\Mardin\...mers\ThreadTransformer>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
77			}
78			}
79			}
80

reliqarts / mardin

MessageTransformer::includeThread() A last analyzed 2018-08-03 18:37 UTC

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

MessageTransformer::includeThread() A
last analyzed 2018-08-03 18:37 UTC