reliqarts / laravel-docweaver

src/Console/Command/Publish.php

<?php

declare(strict_types=1);

namespace ReliqArts\Docweaver\Console\Command;

use Carbon\Carbon;
use ReliqArts\Docweaver\Exception\InvalidDirectory;

class Publish extends SingleProductCommand
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'docweaver:publish
                            {product? : Product name}
                            {source? : Product repository}
                            {--y|y : Whether to skip confirmation}
                            ';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Publish documentation for product';

    /**
     * Execute the console command.
     *
     * @throws InvalidDirectory
     */
    public function handle(): void
    {
        $productName = $this->argument('product');
        $productSource = $this->argument('source');
        $skipConfirmation = $this->option('y');
        $confirmationMessage = sprintf(
            "This command will attempt to pull documentation for product (%s) from %s}. \n"
            . 'Please ensure your internet connection is stable. Ready?',
            $productName,

It seems like $productName can also be of type string[]; however, parameter $args of sprintf() does only seem to accept string, maybe add an additional type check?

            $productSource
        );

        $this->comment(PHP_EOL
            . "<info>♣♣♣</info> Docweaver DocumentationPublisher \n"
            . 'Help is here, try: php artisan docweaver:publish --help');

        if ($skipConfirmation || $this->confirm($confirmationMessage)) {
            $this->info("Publishing {$productName}.\nT: " . Carbon::now()->toCookieString() . '----------');

            $result = $this->publisher->publish($productName, $productSource, $this);

It seems like $productSource can also be of type null and string[]; however, parameter $source of ReliqArts\Docweaver\Contract\Documentation\Publisher::publish() does only seem to accept string, maybe add an additional type check?

It seems like $productName can also be of type null and string[]; however, parameter $productName of ReliqArts\Docweaver\Contract\Documentation\Publisher::publish() does only seem to accept string, maybe add an additional type check?

            $this->displayResult($result);
        }
    }
}