GitCommandRunner::clone() - Code Metrics - Inspection of "Merge branch 'release/2.0.0-beta'" - reliqarts/laravel-docweaver - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9003e7...f2c4d3 )

by ReliQ

created 2019-03-15 13:32 UTC

GitCommandRunner::clone() A

↳ Parent: GitCommandRunner

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	3

<?php

declare(strict_types=1);

namespace ReliQArts\Docweaver\Services;

use ReliQArts\Docweaver\Contracts\VCSCommandRunner;
use Symfony\Component\Process\Exception\ProcessFailedException;
use Symfony\Component\Process\Process;

final class GitCommandRunner implements VCSCommandRunner
{
    /**
     * @param string $source
     * @param string $branch
     * @param string $workingDirectory
     */
    public function clone(string $source, string $branch, string $workingDirectory): void
    {
        $clone = new Process(sprintf('git clone --branch %s "%s" %s', $branch, $source, $branch), $workingDirectory);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $clone->mustRun();
    }

    /**
     * @param string $workingDirectory
     *
     * @throws ProcessFailedException
     *
     * @return array
     */
    public function getTags(string $workingDirectory): array
    {
        $listTags = new Process('git tag -l', $workingDirectory);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $listTags->mustRun();

        if ($splitTags = preg_split("/[\n\r]/", $listTags->getOutput())) {
            return array_filter(array_map('trim', $splitTags));
        }

        return [];
    }

    /**
     * @param string $workingDirectory
     *
     * @throws ProcessFailedException
     */
    public function pull(string $workingDirectory): void
    {
        $pull = new Process('git pull', $workingDirectory);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $pull->mustRun();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace ReliQArts\Docweaver\Services;
6
7			use ReliQArts\Docweaver\Contracts\VCSCommandRunner;
8			use Symfony\Component\Process\Exception\ProcessFailedException;
9			use Symfony\Component\Process\Process;
10
11			final class GitCommandRunner implements VCSCommandRunner
12			{
13			/**
14			* @param string $source
15			* @param string $branch
16			* @param string $workingDirectory
17			*/
18			public function clone(string $source, string $branch, string $workingDirectory): void
19			{
20			$clone = new Process(sprintf('git clone --branch %s "%s" %s', $branch, $source, $branch), $workingDirectory);
			0 ignored issues – show Documentation introduced 2019-03-11 22:12 UTC by Report Bug Copy Issue Report `sprintf('git clone --bra...anch, $source, $branch)` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
21			$clone->mustRun();
22			}
23
24			/**
25			* @param string $workingDirectory
26			*
27			* @throws ProcessFailedException
28			*
29			* @return array
30			*/
31			public function getTags(string $workingDirectory): array
32			{
33			$listTags = new Process('git tag -l', $workingDirectory);
			0 ignored issues – show Documentation introduced 2019-03-11 22:12 UTC by Report Bug Copy Issue Report `'git tag -l'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
34			$listTags->mustRun();
35
36			if ($splitTags = preg_split("/[\n\r]/", $listTags->getOutput())) {
37			return array_filter(array_map('trim', $splitTags));
38			}
39
40			return [];
41			}
42
43			/**
44			* @param string $workingDirectory
45			*
46			* @throws ProcessFailedException
47			*/
48			public function pull(string $workingDirectory): void
49			{
50			$pull = new Process('git pull', $workingDirectory);
			0 ignored issues – show Documentation introduced 2019-03-11 22:12 UTC by Report Bug Copy Issue Report `'git pull'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
51			$pull->mustRun();
52			}
53			}
54

reliqarts / laravel-docweaver

Push — master ( 9003e7...f2c4d3 )

GitCommandRunner::clone() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like