PhpProfiler\Inspector\Output\TraceFormatter\Compat\CompatCallTraceFormatter

Complexity

Total Complexity

5

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getInstance()	0	6	2
A	format()	0	7	2
A	__construct()	0	3	1

<?php

/**
 * This file is part of the reliforp/reli-prof package.
 *
 * (c) sji <sji@sj-i.dev>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Reli\Inspector\Output\TraceFormatter\Compat;

use Reli\Inspector\Output\TraceFormatter\CallTraceFormatter;
use Reli\Lib\PhpProcessReader\CallTrace;

use function join;

final class CompatCallTraceFormatter implements CallTraceFormatter
{
    private static ?self $cache;

    public function __construct(
        private CompatCallFrameFormatter $call_frame_formatter,
    ) {
    }

    public static function getInstance(): self
    {
        if (!isset(self::$cache)) {
            self::$cache = new self(new CompatCallFrameFormatter());
        }
        return self::$cache;

The expression return self::cache could return the type null which is incompatible with the type-hinted return Reli\Inspector\Output\TraceFormatter\Compat\CompatCallTraceFormatter. Consider adding an additional type-check to rule them out.

    }

    public function format(CallTrace $call_trace): string
    {
        $frames = [];
        foreach ($call_trace->call_frames as $call_frame) {
            $frames[] = $this->call_frame_formatter->format($call_frame);
        }
        return join(PHP_EOL, $frames);
    }
}