Reli\Lib\PhpProcessReader\PhpZendMemoryManagerChunkFinder::findAddress()

Complexity

Conditions	6
Paths	4

Size

Total Lines	30
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function findAddress(
        int $pid,
        string $php_version,
        MemoryReaderInterface $memory_reader,
    ): int {
        $zend_type_reader = $this->zend_type_reader_creator->create($php_version);
        $memory_map = $this->process_memory_map_creator->getProcessMemoryMap($pid);
        $process_memory_area = $memory_map->findByNameRegex('\[anon:zend_alloc\]');
        foreach ($process_memory_area as $area) {
            $begin = hexdec($area->begin);
            $end = hexdec($area->end);
            for ($p = $begin; $p < $end; $p += 0x200000) {
                $zend_mm_chunk_buffer = $memory_reader->read(
                    $pid,
                    $p,

It seems like $p can also be of type double; however, parameter $remote_address of Reli\Lib\Process\MemoryReader\MemoryReaderInterface::read() does only seem to accept integer, maybe add an additional type check?

                    $zend_type_reader->sizeOf('zend_mm_chunk'),
                );
                $zend_mm_chunk = $zend_type_reader->readAs('zend_mm_chunk', $zend_mm_chunk_buffer);
                $heap_address = \FFI::cast('long', $zend_mm_chunk->casted->heap)->cdata;
                [$offset,] = $zend_type_reader->getOffsetAndSizeOfMember('zend_mm_chunk', 'heap_slot');
                if (
                    $heap_address === $p + $offset
                    and $zend_mm_chunk->casted->num === 0
                    and $zend_mm_chunk->casted->heap_slot->size > 0
                ) {
                    return $p;

The expression return $p could return the type double which is incompatible with the type-hinted return integer. Consider adding an additional type-check to rule them out.

                }
            }
        }
        return hexdec($process_memory_area[0]->begin);

The expression return hexdec($process_memory_area[0]->begin) could return the type double which is incompatible with the type-hinted return integer. Consider adding an additional type-check to rule them out.

    }
}