Reith\ToyRobot\CommandHandler\RobotMover

Complexity

Total Complexity

6

Size/Duplication

Total Lines	82
Duplicated Lines	24.39 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

92.86%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	handleTurningLeft()	10	10	1
A	handleTurningRight()	0	10	1
A	handleMoveForward()	10	10	1
A	getRobot()	0	12	2

<?php

/**
 * (c) 2018 Douglas Reith.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Reith\ToyRobot\CommandHandler;

use MathPHP\LinearAlgebra\Vector;
use Psr\Log\LoggerInterface;
use Reith\ToyRobot\Domain\Robot\RobotRepositoryInterface;
use Reith\ToyRobot\Domain\Robot\Robot;

use Reith\ToyRobot\Messaging\Annotation\Subscribe;
use Reith\ToyRobot\Messaging\Command\TurnLeft;
use Reith\ToyRobot\Messaging\Command\TurnRight;
use Reith\ToyRobot\Messaging\Command\MoveForward;

final class RobotMover
{
    private $repository;

    private $logger;

    /**
     * @param RobotRepositoryInterface $repository
     * @param LoggerInterface          $logger
     */
    public function __construct(
        RobotRepositoryInterface $repository,
        LoggerInterface $logger
    ) {
        $this->repository = $repository;
        $this->logger = $logger;
    }

    /**
     * @Subscribe
     *
     * @param TurnLeft $command
     */
    public function handleTurningLeft(TurnLeft $command): void

The parameter $command is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $robot = $this->getRobot();

        $robot->left();

        $this->repository->save($robot);

        $this->logger->info('Robot turned left');
    }

    /**
     * @Subscribe
     *
     * @param TurnRight $command
     */
    public function handleTurningRight(TurnRight $command): void

The parameter $command is not used and could be removed.

    {
        $robot = $this->getRobot();

        $robot->right();

        $this->repository->save($robot);

        $this->logger->info('Robot turned right');
    }

    /**
     * @Subscribe
     *
     * @param MoveForward $command
     */
    public function handleMoveForward(MoveForward $command): void

The parameter $command is not used and could be removed.

This method seems to be duplicated in your project.

    {
        $robot = $this->getRobot();

        $robot->move();

        $this->repository->save($robot);

        $this->logger->info('Robot moved forward');
    }

    /**
     * @return Robot
     */
    private function getRobot(): Robot
    {
        $robot = $this->repository->load();

        if (!($robot instanceof Robot)) {
            throw new \RuntimeException(
                'Robot cannot be found. Please PLACE the robot first.'
            );
        }

        return $robot;
    }
}