RobotPlacerTest::willHandlePlaceRobot() - Code Metrics - Inspection of "Added the busses and handlers and wired them up" - reithbot/toyrobot-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c54dd1...7d6afc )

by Douglas

created 2018-04-17 04:33 UTC

RobotPlacerTest::willHandlePlaceRobot() A

↳ Parent: RobotPlacerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	0

<?php
/**
 * (c) 2018 Douglas Reith.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Reith\ToyRobot\CommandHandler;

use PHPUnit\Framework\TestCase;
use Reith\ToyRobot\Messaging\Command\PlaceRobot;
use Reith\ToyRobot\Domain\Space\Table;
use Reith\ToyRobot\Domain\Robot\RobotRepositoryInterface;

class RobotPlacerTest extends TestCase
{
    /**
     * @test
     */
    public function willHandlePlaceRobot()
    {
        $table = Table::create(10);
        $mockRepo = self::createMock(RobotRepositoryInterface::class);
        $robotPlacer = new RobotPlacer($table, $mockRepo);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        self::assertInstanceOf(RobotPlacer::class, $robotPlacer);

        $command = new PlaceRobot([0, 1], 'N');

        $mockRepo->expects($this->once())->method('save');

        $robotPlacer->handlePlaceRobot($command);
    }
}


1			<?php
2			/**
3			* (c) 2018 Douglas Reith.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace Reith\ToyRobot\CommandHandler;
11
12			use PHPUnit\Framework\TestCase;
13			use Reith\ToyRobot\Messaging\Command\PlaceRobot;
14			use Reith\ToyRobot\Domain\Space\Table;
15			use Reith\ToyRobot\Domain\Robot\RobotRepositoryInterface;
16
17			class RobotPlacerTest extends TestCase
18			{
19			/**
20			* @test
21			*/
22			public function willHandlePlaceRobot()
23			{
24			$table = Table::create(10);
25			$mockRepo = self::createMock(RobotRepositoryInterface::class);
26			$robotPlacer = new RobotPlacer($table, $mockRepo);
			0 ignored issues – show Documentation introduced 2018-04-17 04:36 UTC by Report Bug Copy Issue Report `$mockRepo` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Reith\ToyRobot\Do...botRepositoryInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
27
28			self::assertInstanceOf(RobotPlacer::class, $robotPlacer);
29
30			$command = new PlaceRobot([0, 1], 'N');
31
32			$mockRepo->expects($this->once())->method('save');
33
34			$robotPlacer->handlePlaceRobot($command);
35			}
36			}
37

reithbot / toyrobot-php

Push — master ( c54dd1...7d6afc )

RobotPlacerTest::willHandlePlaceRobot() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like