RobotReporterTest::willHandlePlaceRobot() - Code Metrics - Inspection of "Made some fixes and created an in memory store for..." - reithbot/toyrobot-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8184b0...a4b4a5 )

by Douglas

created 2018-04-18 04:05 UTC

RobotReporterTest::willHandlePlaceRobot() A

↳ Parent: RobotReporterTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	20
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	20
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	12
nc	1
nop	0

<?php
/**
 * (c) 2018 Douglas Reith.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Reith\ToyRobot\QueryHandler;

use PHPUnit\Framework\TestCase;
use Psr\Log\LoggerInterface;
use Reith\ToyRobot\Messaging\Query\RobotReport;
use Reith\ToyRobot\Domain\Space\Table;
use Reith\ToyRobot\Domain\Robot\RobotRepositoryInterface;

class RobotReporterTest extends TestCase
{
    /**
     * @test
     */
    public function willHandlePlaceRobot()
    {
        $mockRepo = self::createMock(RobotRepositoryInterface::class);
        $mockLogger = self::createMock(LoggerInterface::class);
        $robotReporter = new RobotReporter($mockRepo, $mockLogger);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        self::assertInstanceOf(RobotReporter::class, $robotReporter);

        $query = new RobotReport();

        $robot = Table::create(3)->placeRobot();

        $mockRepo->expects($this->once())
            ->method('load')
            ->willReturn($robot);

        $result = $robotReporter->handleReport($query);

        self::assertSame('0,0,E', $result);
    }
}


1			<?php
2			/**
3			* (c) 2018 Douglas Reith.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace Reith\ToyRobot\QueryHandler;
11
12			use PHPUnit\Framework\TestCase;
13			use Psr\Log\LoggerInterface;
14			use Reith\ToyRobot\Messaging\Query\RobotReport;
15			use Reith\ToyRobot\Domain\Space\Table;
16			use Reith\ToyRobot\Domain\Robot\RobotRepositoryInterface;
17
18			class RobotReporterTest extends TestCase
19			{
20			/**
21			* @test
22			*/
23			public function willHandlePlaceRobot()
24			{
25			$mockRepo = self::createMock(RobotRepositoryInterface::class);
26			$mockLogger = self::createMock(LoggerInterface::class);
27			$robotReporter = new RobotReporter($mockRepo, $mockLogger);
			0 ignored issues – show Documentation introduced 2018-04-18 04:07 UTC by Report Bug Copy Issue Report `$mockRepo` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Reith\ToyRobot\Do...botRepositoryInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2018-04-18 04:07 UTC by Report Bug Copy Issue Report `$mockLogger` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Log\LoggerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
28
29			self::assertInstanceOf(RobotReporter::class, $robotReporter);
30
31			$query = new RobotReport();
32
33			$robot = Table::create(3)->placeRobot();
34
35			$mockRepo->expects($this->once())
36			->method('load')
37			->willReturn($robot);
38
39			$result = $robotReporter->handleReport($query);
40
41			self::assertSame('0,0,E', $result);
42			}
43			}
44

reithbot / toyrobot-php

Push — master ( 8184b0...a4b4a5 )

RobotReporterTest::willHandlePlaceRobot() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like