RobotPlacerTest::willHandlePlaceRobot() - Code Metrics - Inspection of "Made some fixes and created an in memory store for..." - reithbot/toyrobot-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8184b0...a4b4a5 )

by Douglas

created 2018-04-18 04:05 UTC

RobotPlacerTest::willHandlePlaceRobot() B

↳ Parent: RobotPlacerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	29
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	29
rs	8.8571
c	0
b	0
f	0
cc	1
eloc	17
nc	1
nop	0

<?php
/**
 * (c) 2018 Douglas Reith.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */
declare(strict_types=1);

namespace Reith\ToyRobot\CommandHandler;

use PHPUnit\Framework\TestCase;
use Psr\Log\LoggerInterface;
use Reith\ToyRobot\Messaging\Command\PlaceRobot;
use Reith\ToyRobot\Domain\Space\Table;
use Reith\ToyRobot\Domain\Robot\RobotRepositoryInterface;
use Reith\ToyRobot\Domain\Robot\Robot;

class RobotPlacerTest extends TestCase
{
    /**
     * @test
     */
    public function willHandlePlaceRobot()
    {
        $table = Table::create(10);
        $mockRepo = self::createMock(RobotRepositoryInterface::class);
        $mockLogger = self::createMock(LoggerInterface::class);
        $robotPlacer = new RobotPlacer($table, $mockRepo, $mockLogger);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        self::assertInstanceOf(RobotPlacer::class, $robotPlacer);

        $command = new PlaceRobot([1, 4], 'W');

        $localRobot = null;

        $mockRepo->expects($this->once())
            ->method('save')
            ->with(
                $this->callback(function (Robot $robot) use (&$localRobot) {
                    $localRobot = $robot;

                    return true;
                })
            );

        $robotPlacer->handlePlaceRobot($command);

        self::assertInstanceOf(Robot::class, $localRobot);

        self::assertSame('1,4,W', $localRobot->getReportAsString());

    }
}


1			<?php
2			/**
3			* (c) 2018 Douglas Reith.
4			*
5			* For the full copyright and license information, please view the LICENSE
6			* file that was distributed with this source code.
7			*/
8			declare(strict_types=1);
9
10			namespace Reith\ToyRobot\CommandHandler;
11
12			use PHPUnit\Framework\TestCase;
13			use Psr\Log\LoggerInterface;
14			use Reith\ToyRobot\Messaging\Command\PlaceRobot;
15			use Reith\ToyRobot\Domain\Space\Table;
16			use Reith\ToyRobot\Domain\Robot\RobotRepositoryInterface;
17			use Reith\ToyRobot\Domain\Robot\Robot;
18
19			class RobotPlacerTest extends TestCase
20			{
21			/**
22			* @test
23			*/
24			public function willHandlePlaceRobot()
25			{
26			$table = Table::create(10);
27			$mockRepo = self::createMock(RobotRepositoryInterface::class);
28			$mockLogger = self::createMock(LoggerInterface::class);
29			$robotPlacer = new RobotPlacer($table, $mockRepo, $mockLogger);
			0 ignored issues – show Documentation introduced 2018-04-17 13:49 UTC by Report Bug Copy Issue Report `$mockRepo` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Reith\ToyRobot\Do...botRepositoryInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2018-04-17 13:49 UTC by Report Bug Copy Issue Report `$mockLogger` is of type `object<PHPUnit\Framework\MockObject\MockObject>`, but the function expects a `object<Psr\Log\LoggerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
30
31			self::assertInstanceOf(RobotPlacer::class, $robotPlacer);
32
33			$command = new PlaceRobot([1, 4], 'W');
34
35			$localRobot = null;
36
37			$mockRepo->expects($this->once())
38			->method('save')
39			->with(
40			$this->callback(function (Robot $robot) use (&$localRobot) {
41			$localRobot = $robot;
42
43			return true;
44			})
45			);
46
47			$robotPlacer->handlePlaceRobot($command);
48
49			self::assertInstanceOf(Robot::class, $localRobot);
50
51			self::assertSame('1,4,W', $localRobot->getReportAsString());
			0 ignored issues – show Bug introduced 2018-04-18 04:07 UTC by Report Bug Copy Issue Report The method `getReportAsString` cannot be called on `$localRobot` (of type `null`). Methods can only be called on objects. This check looks for methods being called on variables that have been inferred to never be objects. Loading history...
52			}
53			}
54

reithbot / toyrobot-php

Push — master ( 8184b0...a4b4a5 )

RobotPlacerTest::willHandlePlaceRobot() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like