AbstractManifestLoader::load() - Code Metrics - Inspection of "Host documentation at ReadTheDocs" - regularjack/frontend-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#26)

by Paulo Rodrigues

created 2017-04-02 17:49 UTC

AbstractManifestLoader::load() A

↳ Parent: AbstractManifestLoader

Complexity

Conditions	3
Paths	3

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	3.7085

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0
ccs	4
cts	7
cp	0.5714
cc	3
eloc	7
nc	3
nop	0
crap	3.7085

<?php

namespace Rj\FrontendBundle\Manifest\Loader;

use Rj\FrontendBundle\Manifest\Manifest;

abstract class AbstractManifestLoader implements ManifestLoaderInterface
{
    private $path;
    private $rootKey;

    abstract protected function parse($path);

    public function __construct($path, $rootKey = null)
    {
        if (!is_file($path)) {
            throw new \InvalidArgumentException("The manifest file '$path' could not be found");
// Instead of
$x = "foo $bar $baz";

// Better use either
$x = "foo " . $bar . " " . $baz;
$x = sprintf("foo %s %s", $bar, $baz);
        }

        $this->path = $path;
        $this->rootKey = $rootKey;
    }

    /**
     * {@inheritdoc}
     */
    public function load()
    {
        $entries = $this->parse($this->path);

        if (!empty($this->rootKey)) {
            if (!isset($entries[$this->rootKey])) {
                throw new \InvalidArgumentException('Manifest file contains no '.$this->rootKey.' key');
            }

            $entries = $entries[$this->rootKey];
        }

        return new Manifest($entries);
    }

    /**
     * {@inheritdoc}
     */
    public function getPath()
    {
        return $this->path;
    }
}


1		<?php
2
3		namespace Rj\FrontendBundle\Manifest\Loader;
4
5		use Rj\FrontendBundle\Manifest\Manifest;
6
7		abstract class AbstractManifestLoader implements ManifestLoaderInterface
8		{
9		private $path;
10		private $rootKey;
11
12		abstract protected function parse($path);
13
14	3	public function __construct($path, $rootKey = null)
15		{
16	3	if (!is_file($path)) {
17		throw new \InvalidArgumentException("The manifest file '$path' could not be found");
		0 ignored issues – show Coding Style Best Practice introduced 2016-01-01 19:29 UTC by Report Bug Copy Issue Report As per coding-style, please use concatenation or `sprintf` for the variable `$path` instead of interpolation. It is generally a best practice as it is often more readable to use concatenation instead of interpolation for variables inside strings. // Instead of $x = "foo $bar $baz"; // Better use either $x = "foo " . $bar . " " . $baz; $x = sprintf("foo %s %s", $bar, $baz); Loading history...
18		}
19
20	3	$this->path = $path;
21	3	$this->rootKey = $rootKey;
22	3	}
23
24		/**
25		* {@inheritdoc}
26		*/
27	3	public function load()
28		{
29	3	$entries = $this->parse($this->path);
30
31	3	if (!empty($this->rootKey)) {
32		if (!isset($entries[$this->rootKey])) {
33		throw new \InvalidArgumentException('Manifest file contains no '.$this->rootKey.' key');
34		}
35
36		$entries = $entries[$this->rootKey];
37		}
38
39	3	return new Manifest($entries);
40		}
41
42		/**
43		* {@inheritdoc}
44		*/
45	3	public function getPath()
46		{
47	3	return $this->path;
48		}
49		}
50

regularjack / frontend-bundle

Pull Request — master (#26)

AbstractManifestLoader::load() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like