LancamentoVendasController - Code Metrics - Inspection of "Client pdv" - reginaldojunior/winners - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#80)

by Reginaldo

created 2017-07-08 21:46 UTC

LancamentoVendasController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	62
Duplicated Lines	69.35 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
dl	43
loc	62
rs	10
c	0
b	0
f	0
wmc	3
lcom	0
cbo	1

3 Methods

Rating	Name	Duplication	Size	Complexity
A	salvar_lancamento()	0	13	1
A	cancelar()	22	22	1
A	aprovar()	21	21	1

How to fix Duplicated Code

<?php

class LancamentoVendasController extends AppController {

	public function salvar_lancamento($id_venda, $dados, $valor_total, $id_usuario) {
		$lancamento['venda_id']   = $id_venda;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
		$lancamento['valor'] = $valor_total;
		$lancamento['valor_pago'] = $valor_total;
		$lancamento['data_pgt']   = date('Y-m-d');
		$lancamento['ativo']	  = 1;
		$lancamento['usuario_id'] = $id_usuario;
		$lancamento['forma_pagamento'] = $dados['forma_pagamento'];

		$this->LancamentoVenda->save($lancamento);

		return true;
 	}

 	public function cancelar($id_venda, $id_cliente) {

 		$response = $this->LancamentoVenda->find('first', array(
    			'conditions' => array(
    				'LancamentoVenda.venda_id' => $id_venda
    			)
    		)
    	);

 		$this->LancamentoVenda->id = $response['LancamentoVenda']['id'];

 		$this->LancamentoVenda->save(
 			['valor_pago' => 0]
 		);

 		echo json_encode(
 			[
 				'valor' => $response['LancamentoVenda']['valor']
 			]
 		);
 		exit;


 	}

 	public function aprovar($id_venda, $id_cliente) {

 		$response = $this->LancamentoVenda->find('first', array(
    			'conditions' => array(
    				'LancamentoVenda.venda_id' => $id_venda
    			)
    		)
    	);

 		$this->LancamentoVenda->id = $response['LancamentoVenda']['id'];

 		$this->LancamentoVenda->save(
 			['valor_pago' => $response['LancamentoVenda']['valor']]
 		);
 		
 		echo json_encode(
 			[
 				'valor' => $response['LancamentoVenda']['valor']
 			]
 		);
 		exit;

 	}

}

1		<?php
2
3		class LancamentoVendasController extends AppController {
4
5		public function salvar_lancamento($id_venda, $dados, $valor_total, $id_usuario) {
6		$lancamento['venda_id'] = $id_venda;
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-01-10 14:19 UTC by Report Bug Copy Issue Report `$lancamento` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$lancamento = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
7		$lancamento['valor'] = $valor_total;
8		$lancamento['valor_pago'] = $valor_total;
9		$lancamento['data_pgt'] = date('Y-m-d');
10		$lancamento['ativo'] = 1;
11		$lancamento['usuario_id'] = $id_usuario;
12		$lancamento['forma_pagamento'] = $dados['forma_pagamento'];
13
14		$this->LancamentoVenda->save($lancamento);
15
16		return true;
17		}
18
19	View Code Duplication	public function cancelar($id_venda, $id_cliente) {
		0 ignored issues – show Unused Code introduced 2017-07-08 22:06 UTC by Report Bug Copy Issue Report The parameter `$id_cliente` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
20		$response = $this->LancamentoVenda->find('first', array(
21		'conditions' => array(
22		'LancamentoVenda.venda_id' => $id_venda
23		)
24		)
25		);
26
27		$this->LancamentoVenda->id = $response['LancamentoVenda']['id'];
28
29		$this->LancamentoVenda->save(
30		['valor_pago' => 0]
31		);
32
33		echo json_encode(
34		[
35		'valor' => $response['LancamentoVenda']['valor']
36		]
37		);
38		exit;
		0 ignored issues – show Coding Style Compatibility introduced 2017-07-08 22:06 UTC by Report Bug Copy Issue Report The method `cancelar()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
39
40		}
41
42	View Code Duplication	public function aprovar($id_venda, $id_cliente) {
		0 ignored issues – show Unused Code introduced 2017-07-08 22:06 UTC by Report Bug Copy Issue Report The parameter `$id_cliente` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
43		$response = $this->LancamentoVenda->find('first', array(
44		'conditions' => array(
45		'LancamentoVenda.venda_id' => $id_venda
46		)
47		)
48		);
49
50		$this->LancamentoVenda->id = $response['LancamentoVenda']['id'];
51
52		$this->LancamentoVenda->save(
53		['valor_pago' => $response['LancamentoVenda']['valor']]
54		);
55
56		echo json_encode(
57		[
58		'valor' => $response['LancamentoVenda']['valor']
59		]
60		);
61		exit;
		0 ignored issues – show Coding Style Compatibility introduced 2017-07-08 22:06 UTC by Report Bug Copy Issue Report The method `aprovar()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
62		}
63
64		}

reginaldojunior / winners

Pull Request — master (#80)

LancamentoVendasController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like