Inspection of "Development" - reginaldojunior/winners - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#54)

by Reginaldo

created 2015-11-21 13:06 UTC

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch

@@ -1,16 +1,16 @@
 block discarded – undo
 <?php
 /**
- * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
- * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
- *
- * Licensed under The MIT License
- * Redistributions of files must retain the above copyright notice.
- *
- * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
- * @link          http://cakephp.org CakePHP(tm) Project
- * @license       http://www.opensource.org/licenses/mit-license.php MIT License
- *
- */
+	 * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
+	 * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+	 *
+	 * Licensed under The MIT License
+	 * Redistributions of files must retain the above copyright notice.
+	 *
+	 * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+	 * @link          http://cakephp.org CakePHP(tm) Project
+	 * @license       http://www.opensource.org/licenses/mit-license.php MIT License
+	 *
+	 */
 
 App::uses('DebugPanel', 'DebugKit.Lib');
 

Please login to merge, or discard this patch.

Plugin/DebugKit/Lib/Panel/HistoryPanel.php 2 patches

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -1,15 +1,15 @@
 block discarded – undo
 <?php
 /**
- * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
- * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
- *
- * Licensed under The MIT License
- * Redistributions of files must retain the above copyright notice.
- *
- * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
- * @link          http://cakephp.org CakePHP(tm) Project
- * @license       http://www.opensource.org/licenses/mit-license.php MIT License
- */
+	 * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
+	 * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+	 *
+	 * Licensed under The MIT License
+	 * Redistributions of files must retain the above copyright notice.
+	 *
+	 * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+	 * @link          http://cakephp.org CakePHP(tm) Project
+	 * @license       http://www.opensource.org/licenses/mit-license.php MIT License
+	 */
 
 App::uses('DebugPanel', 'DebugKit.Lib');
 

Please login to merge, or discard this patch.

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -48,13 +48,13 @@  discard block
 block discarded – undo
 		$cacheKey = $controller->Toolbar->cacheKey;
 		$toolbarHistory = Cache::read($cacheKey, 'debug_kit');
 		$historyStates = array();
-		if (is_array($toolbarHistory) && !empty($toolbarHistory)) {
+		if (is_array($toolbarHistory) && ! empty($toolbarHistory)) {
 			$prefix = array();
-			if (!empty($controller->request->params['prefix'])) {
+			if ( ! empty($controller->request->params['prefix'])) {
 				$prefix[$controller->request->params['prefix']] = false;
 			}
 			foreach ($toolbarHistory as $i => $state) {
-				if (!isset($state['request']['content']['url'])) {
+				if ( ! isset($state['request']['content']['url'])) {
 					continue;
 				}
 				$title = $state['request']['content']['url'];
@@ -62,8 +62,8 @@  discard block
 block discarded – undo
 				if (isset($query['url'])) {
 					unset($query['url']);
 				}
-				if (!empty($query)) {
-					$title .= '?' . urldecode(http_build_query($query));
+				if ( ! empty($query)) {
+					$title .= '?'.urldecode(http_build_query($query));
 				}
 				$historyStates[] = array(
 					'title' => $title,

Please login to merge, or discard this patch.

Plugin/DebugKit/Lib/Panel/LogPanel.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -1,15 +1,15 @@
 block discarded – undo
 <?php
 /**
- * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
- * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
- *
- * Licensed under The MIT License
- * Redistributions of files must retain the above copyright notice.
- *
- * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
- * @link          http://cakephp.org CakePHP(tm) Project
- * @license       http://www.opensource.org/licenses/mit-license.php MIT License
- */
+	 * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
+	 * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+	 *
+	 * Licensed under The MIT License
+	 * Redistributions of files must retain the above copyright notice.
+	 *
+	 * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+	 * @link          http://cakephp.org CakePHP(tm) Project
+	 * @license       http://www.opensource.org/licenses/mit-license.php MIT License
+	 */
 
 App::uses('DebugPanel', 'DebugKit.Lib');
 

Please login to merge, or discard this patch.

Plugin/DebugKit/Lib/Panel/RequestPanel.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -1,15 +1,15 @@
 block discarded – undo
 <?php
 /**
- * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
- * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
- *
- * Licensed under The MIT License
- * Redistributions of files must retain the above copyright notice.
- *
- * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
- * @link          http://cakephp.org CakePHP(tm) Project
- * @license       http://www.opensource.org/licenses/mit-license.php MIT License
- */
+	 * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
+	 * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+	 *
+	 * Licensed under The MIT License
+	 * Redistributions of files must retain the above copyright notice.
+	 *
+	 * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+	 * @link          http://cakephp.org CakePHP(tm) Project
+	 * @license       http://www.opensource.org/licenses/mit-license.php MIT License
+	 */
 
 App::uses('DebugPanel', 'DebugKit.Lib');
 

Please login to merge, or discard this patch.

Plugin/DebugKit/Lib/Panel/SqlLogPanel.php 2 patches

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -1,15 +1,15 @@
 block discarded – undo
 <?php
 /**
- * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
- * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
- *
- * Licensed under The MIT License
- * Redistributions of files must retain the above copyright notice.
- *
- * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
- * @link          http://cakephp.org CakePHP(tm) Project
- * @license       http://www.opensource.org/licenses/mit-license.php MIT License
- */
+	 * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
+	 * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+	 *
+	 * Licensed under The MIT License
+	 * Redistributions of files must retain the above copyright notice.
+	 *
+	 * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+	 * @link          http://cakephp.org CakePHP(tm) Project
+	 * @license       http://www.opensource.org/licenses/mit-license.php MIT License
+	 */
 
 App::uses('DebugPanel', 'DebugKit.Lib');
 

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -34,7 +34,7 @@  discard block
 block discarded – undo
  * @return array
  */
 	public function beforeRender(Controller $controller) {
-		if (!class_exists('ConnectionManager')) {
+		if ( ! class_exists('ConnectionManager')) {
 			return array();
 		}
 		$connections = array();
@@ -45,7 +45,7 @@  discard block
 block discarded – undo
 			$db = ConnectionManager::getDataSource($configName);
 			if (
 				(empty($db->config['driver']) && empty($db->config['datasource'])) ||
-				!method_exists($db, 'getLog')
+				! method_exists($db, 'getLog')
 			) {
 				continue;
 			}

Please login to merge, or discard this patch.

Plugin/DebugKit/Lib/Panel/TimerPanel.php 2 patches

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -1,15 +1,15 @@
 block discarded – undo
 <?php
 /**
- * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
- * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
- *
- * Licensed under The MIT License
- * Redistributions of files must retain the above copyright notice.
- *
- * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
- * @link          http://cakephp.org CakePHP(tm) Project
- * @license       http://www.opensource.org/licenses/mit-license.php MIT License
- */
+	 * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
+	 * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+	 *
+	 * Licensed under The MIT License
+	 * Redistributions of files must retain the above copyright notice.
+	 *
+	 * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+	 * @link          http://cakephp.org CakePHP(tm) Project
+	 * @license       http://www.opensource.org/licenses/mit-license.php MIT License
+	 */
 
 App::uses('DebugPanel', 'DebugKit.Lib');
 

Please login to merge, or discard this patch.

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -26,10 +26,10 @@
 block discarded – undo
  * @return void
  */
 	public function startup(Controller $controller) {
-		if (!in_array('Number', array_keys(HelperCollection::normalizeObjectArray($controller->helpers)))) {
+		if ( ! in_array('Number', array_keys(HelperCollection::normalizeObjectArray($controller->helpers)))) {
 			$controller->helpers[] = 'Number';
 		}
-		if (!in_array('SimpleGraph', array_keys(HelperCollection::normalizeObjectArray($controller->helpers)))) {
+		if ( ! in_array('SimpleGraph', array_keys(HelperCollection::normalizeObjectArray($controller->helpers)))) {
 			$controller->helpers[] = 'DebugKit.SimpleGraph';
 		}
 	}

Please login to merge, or discard this patch.

Plugin/DebugKit/Lib/Panel/VariablesPanel.php 1 patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

@@ -1,15 +1,15 @@
 block discarded – undo
 <?php
 /**
- * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
- * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
- *
- * Licensed under The MIT License
- * Redistributions of files must retain the above copyright notice.
- *
- * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
- * @link          http://cakephp.org CakePHP(tm) Project
- * @license       http://www.opensource.org/licenses/mit-license.php MIT License
- */
+	 * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
+	 * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+	 *
+	 * Licensed under The MIT License
+	 * Redistributions of files must retain the above copyright notice.
+	 *
+	 * @copyright     Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
+	 * @link          http://cakephp.org CakePHP(tm) Project
+	 * @license       http://www.opensource.org/licenses/mit-license.php MIT License
+	 */
 
 App::uses('DebugPanel', 'DebugKit.Lib');
 

Please login to merge, or discard this patch.

Plugin/DebugKit/Model/ToolbarAccess.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -35,7 +35,7 @@
 block discarded – undo
 
 		$return = array();
 		if (preg_match('/(Mysql|Postgres)$/', $datasource)) {
-			$explained = $db->query('EXPLAIN ' . $query);
+			$explained = $db->query('EXPLAIN '.$query);
 			if (preg_match('/Postgres$/', $datasource)) {
 				$queryPlan = array();
 				foreach ($explained as $postgreValue) {

Please login to merge, or discard this patch.

Plugin/DebugKit/Test/Case/AllDebugKitTest.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -16,7 +16,7 @@
 block discarded – undo
  * @license       http://www.opensource.org/licenses/mit-license.php MIT License
  */
 
-require_once dirname(__FILE__) . DS . 'DebugkitGroupTestCase.php';
+require_once dirname(__FILE__).DS.'DebugkitGroupTestCase.php';
 
 /**
  * DebugKitViewTestSuite class

Please login to merge, or discard this patch.

		@@ -48,13 +48,13 @@ discard block
		block discarded – undo
48	48	$cacheKey = $controller->Toolbar->cacheKey;
49	49	$toolbarHistory = Cache::read($cacheKey, 'debug_kit');
50	50	$historyStates = array();
51		- if (is_array($toolbarHistory) && !empty($toolbarHistory)) {
	51	+ if (is_array($toolbarHistory) && ! empty($toolbarHistory)) {
52	52	$prefix = array();
53		- if (!empty($controller->request->params['prefix'])) {
	53	+ if ( ! empty($controller->request->params['prefix'])) {
54	54	$prefix[$controller->request->params['prefix']] = false;
55	55	}
56	56	foreach ($toolbarHistory as $i => $state) {
57		- if (!isset($state['request']['content']['url'])) {
	57	+ if ( ! isset($state['request']['content']['url'])) {
58	58	continue;
59	59	}
60	60	$title = $state['request']['content']['url'];
		@@ -62,8 +62,8 @@ discard block
		block discarded – undo
62	62	if (isset($query['url'])) {
63	63	unset($query['url']);
64	64	}
65		- if (!empty($query)) {
66		- $title .= '?' . urldecode(http_build_query($query));
	65	+ if ( ! empty($query)) {
	66	+ $title .= '?'.urldecode(http_build_query($query));
67	67	}
68	68	$historyStates[] = array(
69	69	'title' => $title,

		@@ -35,7 +35,7 @@
		block discarded – undo
35	35
36	36	$return = array();
37	37	if (preg_match('/(Mysql\|Postgres)$/', $datasource)) {
38		- $explained = $db->query('EXPLAIN ' . $query);
	38	+ $explained = $db->query('EXPLAIN '.$query);
39	39	if (preg_match('/Postgres$/', $datasource)) {
40	40	$queryPlan = array();
41	41	foreach ($explained as $postgreValue) {

		@@ -1,16 +1,16 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
4		- * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
5		- *
6		- * Licensed under The MIT License
7		- * Redistributions of files must retain the above copyright notice.
8		- *
9		- * @copyright Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
10		- * @link http://cakephp.org CakePHP(tm) Project
11		- * @license http://www.opensource.org/licenses/mit-license.php MIT License
12		- *
13		- */
	3	+ * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
	4	+ * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
	5	+ *
	6	+ * Licensed under The MIT License
	7	+ * Redistributions of files must retain the above copyright notice.
	8	+ *
	9	+ * @copyright Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
	10	+ * @link http://cakephp.org CakePHP(tm) Project
	11	+ * @license http://www.opensource.org/licenses/mit-license.php MIT License
	12	+ *
	13	+ */
14	14
15	15	App::uses('DebugPanel', 'DebugKit.Lib');
16	16

		@@ -1,15 +1,15 @@
		block discarded – undo
1	1	<?php
2	2	/**
3		- * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
4		- * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
5		- *
6		- * Licensed under The MIT License
7		- * Redistributions of files must retain the above copyright notice.
8		- *
9		- * @copyright Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
10		- * @link http://cakephp.org CakePHP(tm) Project
11		- * @license http://www.opensource.org/licenses/mit-license.php MIT License
12		- */
	3	+ * CakePHP(tm) : Rapid Development Framework (http://cakephp.org)
	4	+ * Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
	5	+ *
	6	+ * Licensed under The MIT License
	7	+ * Redistributions of files must retain the above copyright notice.
	8	+ *
	9	+ * @copyright Copyright (c) Cake Software Foundation, Inc. (http://cakefoundation.org)
	10	+ * @link http://cakephp.org CakePHP(tm) Project
	11	+ * @license http://www.opensource.org/licenses/mit-license.php MIT License
	12	+ */
13	13
14	14	App::uses('DebugPanel', 'DebugKit.Lib');
15	15

		@@ -34,7 +34,7 @@ discard block
		block discarded – undo
34	34	* @return array
35	35	*/
36	36	public function beforeRender(Controller $controller) {
37		- if (!class_exists('ConnectionManager')) {
	37	+ if ( ! class_exists('ConnectionManager')) {
38	38	return array();
39	39	}
40	40	$connections = array();
		@@ -45,7 +45,7 @@ discard block
		block discarded – undo
45	45	$db = ConnectionManager::getDataSource($configName);
46	46	if (
47	47	(empty($db->config['driver']) && empty($db->config['datasource'])) \|\|
48		- !method_exists($db, 'getLog')
	48	+ ! method_exists($db, 'getLog')
49	49	) {
50	50	continue;
51	51	}

		@@ -26,10 +26,10 @@
		block discarded – undo
26	26	* @return void
27	27	*/
28	28	public function startup(Controller $controller) {
29		- if (!in_array('Number', array_keys(HelperCollection::normalizeObjectArray($controller->helpers)))) {
	29	+ if ( ! in_array('Number', array_keys(HelperCollection::normalizeObjectArray($controller->helpers)))) {
30	30	$controller->helpers[] = 'Number';
31	31	}
32		- if (!in_array('SimpleGraph', array_keys(HelperCollection::normalizeObjectArray($controller->helpers)))) {
	32	+ if ( ! in_array('SimpleGraph', array_keys(HelperCollection::normalizeObjectArray($controller->helpers)))) {
33	33	$controller->helpers[] = 'DebugKit.SimpleGraph';
34	34	}
35	35	}

		@@ -16,7 +16,7 @@
		block discarded – undo
16	16	* @license http://www.opensource.org/licenses/mit-license.php MIT License
17	17	*/
18	18
19		-require_once dirname(__FILE__) . DS . 'DebugkitGroupTestCase.php';
	19	+require_once dirname(__FILE__).DS.'DebugkitGroupTestCase.php';
20	20
21	21	/**
22	22	* DebugKitViewTestSuite class

reginaldojunior / winners

Pull Request — master (#54)

Category

Indentation +11 added lines, -11 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +10 added lines, -10 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch