OrcamentoController::pegar_venda_como_html() - Code Metrics - reginaldojunior/winners - Measure and Improve Code Quality continuously with Scrutinizer

OrcamentoController::pegar_venda_como_html() B
last analyzed 2017-12-09 17:38 UTC

↳ Parent: OrcamentoController

Complexity

Conditions	2
Paths	2

Size

Total Lines	76
Code Lines	64

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	64
nc	2
nop	2
dl	0
loc	76
rs	8.9667
c	0
b	0
f	0

How to fix Long Method

<?php

require_once(ROOT . DS . 'vendor' . DS . 'autoload.php');

use Dompdf\Dompdf;

class OrcamentoController extends AppController 
{

	public function listar_cadastros()
	{
		$this->layout = 'wadmin';

		$this->loadModel('Venda');

		$this->set('vendas', $this->Venda->find('all',
				array('conditions' =>
					array(
						'ativo' => 1,
						'id_usuario' => $this->instancia,
						'orcamento' => 1
					)
				)
			)
		);
	}

	public function excluir_cadastro($vendaId)
	{
		$this->layout = 'ajax';

		$this->loadModel('Venda');

		$dados['ativo'] = 0;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
		$dados['id_usuario'] = $this->instancia;
		$dados['id'] = $vendaId;

		echo json_encode($this->Venda->save($dados));

		exit;

	}

	public function salvar_orcamento()
	{
		$this->layout = 'wadmin';
	}

	public function pdf($vendaId)
	{
		$this->loadModel('Venda');
		$this->loadModel('VendaItensProduto');

		$dompdf = new Dompdf();

		$dadosVenda = $this->Venda->find('all', 
			array('conditions' =>
				array(
					'Venda.id' => $vendaId
				)
			)
		);

		$produtosVenda = $this->VendaItensProduto->find('all',
			array('conditions' => 
				array(
					'VendaItensProduto.venda_id' => $vendaId
				)
			)
		);

		$html = $this->pegar_venda_como_html($dadosVenda, $produtosVenda);

		$dompdf->loadHtml($html);

		$dompdf->set_paper('a4');


		$dompdf->render();

		$dompdf->stream();

		exit;

	}

	public function pegar_venda_como_html($dadosVenda, $produtosVenda)
	{
		$html = '';
		$html .= '<html>';
		$html .= '<head>';
		$html .= '	<title></title>';
		$html .= '</head>';
		$html .= '<body>';
		$html .= '';
		$html .= '	<table style="background-color: #cacaca;"  width="100%" valign="center" align="center">';
		$html .= '		<tr align="center">';
		$html .= '			<td>';
		$html .= '				<h2>Orçamento Pedido #' . $dadosVenda[0]['Venda']['id'] . '</h2>';
		$html .= '			</td>';
		$html .= '		</tr> ';
		$html .= '	</table>';
		$html .= '	<br>';
		$html .= '	<table width="100%" valign="center" align="center">';
		$html .= '		<tr  style="background-color: #ccc;">';
		$html .= '			<td>Total: </td>';
		$html .= '			<td>R$ ' . number_format($dadosVenda[0]['Venda']['valor'], 2, ',', '.') . '</td>';
		$html .= '		</tr>';
		$html .= '		<tr  style="background-color: #ccc;">';
		$html .= '			<td>Valor a Pagar: </td>';
		$html .= '			<td>R$ ' . number_format($dadosVenda[0]['Venda']['valor'], 2, ',', '.') . '</td>';
		$html .= '		</tr>';
		$html .= '	</table>';
		$html .= '	<br>';
		$html .= '	<table  width="100%" valign="center" align="center">';
		$html .= '		<tr style="background-color: #cacaca;" align="center">';
		$html .= '			<td>';
		$html .= '				<h2>Produtos</h2>';
		$html .= '			</td>';
		$html .= '		</tr> ';
		$html .= '	</table>';
		$html .= '	<br>';
		$html .= '	<table  width="100%" valign="center" align="center">';
		$html .= '		<tr>';
		$html .= '			<td>';
		$html .= '				<table width="100%" valign="center" align="center">';
		$html .= '					<tr style="background-color: #cacaca;">';
		$html .= '						<td>Nome Produto</td>';
		$html .= '						<td>Quantidade</td>';
		$html .= '						<td>Valor</td>';
		$html .= '					</tr>';
		$html .= '';
		$desconto = 0;
		foreach ($produtosVenda as $i => $produto) {
			$produtoInfos = $this->getInfoProdutos($produto['VendaItensProduto']['produto_id']);
			
			$total = $produtoInfos['Produto']['preco'] * $produto['VendaItensProduto']['quantidade_produto'];
			$total = number_format($total, 2, ',', '.');

			$html .= '					<tr>';
			$html .= '						<td>' . $produtoInfos['Produto']['nome'] . '</td>';
			$html .= '						<td>' . $produto['VendaItensProduto']['quantidade_produto'] . '</td>';
			$html .= '						<td>R$ ' . $total . '</td>';
			$html .= '					</tr>';
		}
		$html .= '				</table>';
		$html .= '			</td>';
		$html .= '		</tr>';
		$html .= '	</table>';
		$html .= '	<br>';
/*		$html .= '	<table width="100%" valign="center" align="center">';
		$html .= '		<tr  style="background-color: #ccc;">';
		$html .= '			<td>Total: </td>';
		$html .= '			<td>R$ ' . number_format($desconto, 2, ',', '.') . '</td>';
		$html .= '		</tr>';
		$html .= '	</table>'; */
		$html .= '';
		$html .= '</body>';
		$html .= '</html>';

		return $html;
	}

	public function getInfoProdutos($produtoId)
	{
		$this->loadModel('Produto');

		$response = $this->Produto->find('first', 
			array('conditions' => array(
					'Produto.id' => $produtoId
				)
			)
		);

		return $response;
	}

}

1			<?php
2
3			require_once(ROOT . DS . 'vendor' . DS . 'autoload.php');
4
5			use Dompdf\Dompdf;
6
7			class OrcamentoController extends AppController
8			{
9
10			public function listar_cadastros()
11			{
12			$this->layout = 'wadmin';
13
14			$this->loadModel('Venda');
15
16			$this->set('vendas', $this->Venda->find('all',
17			array('conditions' =>
18			array(
19			'ativo' => 1,
20			'id_usuario' => $this->instancia,
21			'orcamento' => 1
22			)
23			)
24			)
25			);
26			}
27
28			public function excluir_cadastro($vendaId)
29			{
30			$this->layout = 'ajax';
31
32			$this->loadModel('Venda');
33
34			$dados['ativo'] = 0;
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-08-09 00:42 UTC by Report Bug Copy Issue Report `$dados` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$dados = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
35			$dados['id_usuario'] = $this->instancia;
36			$dados['id'] = $vendaId;
37
38			echo json_encode($this->Venda->save($dados));
39
40			exit;
			0 ignored issues – show Coding Style Compatibility introduced 2016-08-09 00:42 UTC by Report Bug Copy Issue Report The method `excluir_cadastro()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
41			}
42
43			public function salvar_orcamento()
44			{
45			$this->layout = 'wadmin';
46			}
47
48			public function pdf($vendaId)
49			{
50			$this->loadModel('Venda');
51			$this->loadModel('VendaItensProduto');
52
53			$dompdf = new Dompdf();
54
55			$dadosVenda = $this->Venda->find('all',
56			array('conditions' =>
57			array(
58			'Venda.id' => $vendaId
59			)
60			)
61			);
62
63			$produtosVenda = $this->VendaItensProduto->find('all',
64			array('conditions' =>
65			array(
66			'VendaItensProduto.venda_id' => $vendaId
67			)
68			)
69			);
70
71			$html = $this->pegar_venda_como_html($dadosVenda, $produtosVenda);
72
73			$dompdf->loadHtml($html);
74
75			$dompdf->set_paper('a4');
			0 ignored issues – show Deprecated Code introduced 2016-11-27 14:45 UTC by Report Bug Copy Issue Report The method `Dompdf\Dompdf::set_paper()` has been deprecated. This method has been deprecated. Loading history...
76
77			$dompdf->render();
78
79			$dompdf->stream();
80
81			exit;
			0 ignored issues – show Coding Style Compatibility introduced 2016-07-30 19:58 UTC by Report Bug Copy Issue Report The method `pdf()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
82			}
83
84			public function pegar_venda_como_html($dadosVenda, $produtosVenda)
85			{
86			$html = '';
87			$html .= '<html>';
88			$html .= '<head>';
89			$html .= ' <title></title>';
90			$html .= '</head>';
91			$html .= '<body>';
92			$html .= '';
93			$html .= ' <table style="background-color: #cacaca;" width="100%" valign="center" align="center">';
94			$html .= ' <tr align="center">';
95			$html .= ' <td>';
96			$html .= ' <h2>Orçamento Pedido #' . $dadosVenda[0]['Venda']['id'] . '</h2>';
97			$html .= ' </td>';
98			$html .= ' </tr> ';
99			$html .= ' </table>';
100			$html .= ' <br>';
101			$html .= ' <table width="100%" valign="center" align="center">';
102			$html .= ' <tr style="background-color: #ccc;">';
103			$html .= ' <td>Total: </td>';
104			$html .= ' <td>R$ ' . number_format($dadosVenda[0]['Venda']['valor'], 2, ',', '.') . '</td>';
105			$html .= ' </tr>';
106			$html .= ' <tr style="background-color: #ccc;">';
107			$html .= ' <td>Valor a Pagar: </td>';
108			$html .= ' <td>R$ ' . number_format($dadosVenda[0]['Venda']['valor'], 2, ',', '.') . '</td>';
109			$html .= ' </tr>';
110			$html .= ' </table>';
111			$html .= ' <br>';
112			$html .= ' <table width="100%" valign="center" align="center">';
113			$html .= ' <tr style="background-color: #cacaca;" align="center">';
114			$html .= ' <td>';
115			$html .= ' <h2>Produtos</h2>';
116			$html .= ' </td>';
117			$html .= ' </tr> ';
118			$html .= ' </table>';
119			$html .= ' <br>';
120			$html .= ' <table width="100%" valign="center" align="center">';
121			$html .= ' <tr>';
122			$html .= ' <td>';
123			$html .= ' <table width="100%" valign="center" align="center">';
124			$html .= ' <tr style="background-color: #cacaca;">';
125			$html .= ' <td>Nome Produto</td>';
126			$html .= ' <td>Quantidade</td>';
127			$html .= ' <td>Valor</td>';
128			$html .= ' </tr>';
129			$html .= '';
130			$desconto = 0;
131			foreach ($produtosVenda as $i => $produto) {
132			$produtoInfos = $this->getInfoProdutos($produto['VendaItensProduto']['produto_id']);
133
134			$total = $produtoInfos['Produto']['preco'] * $produto['VendaItensProduto']['quantidade_produto'];
135			$total = number_format($total, 2, ',', '.');
136
137			$html .= ' <tr>';
138			$html .= ' <td>' . $produtoInfos['Produto']['nome'] . '</td>';
139			$html .= ' <td>' . $produto['VendaItensProduto']['quantidade_produto'] . '</td>';
140			$html .= ' <td>R$ ' . $total . '</td>';
141			$html .= ' </tr>';
142			}
143			$html .= ' </table>';
144			$html .= ' </td>';
145			$html .= ' </tr>';
146			$html .= ' </table>';
147			$html .= ' <br>';
148			/* $html .= ' <table width="100%" valign="center" align="center">';
149			$html .= ' <tr style="background-color: #ccc;">';
150			$html .= ' <td>Total: </td>';
151			$html .= ' <td>R$ ' . number_format($desconto, 2, ',', '.') . '</td>';
152			$html .= ' </tr>';
153			$html .= ' </table>'; */
154			$html .= '';
155			$html .= '</body>';
156			$html .= '</html>';
157
158			return $html;
159			}
160
161			public function getInfoProdutos($produtoId)
162			{
163			$this->loadModel('Produto');
164
165			$response = $this->Produto->find('first',
166			array('conditions' => array(
167			'Produto.id' => $produtoId
168			)
169			)
170			);
171
172			return $response;
173			}
174
175			}

reginaldojunior / winners

OrcamentoController::pegar_venda_como_html() B last analyzed 2017-12-09 17:38 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

OrcamentoController::pegar_venda_como_html() B
last analyzed 2017-12-09 17:38 UTC