HieraquiaController::adicionar_hieraquia()   A
last analyzed

Complexity

Conditions 1
Paths 1

Size

Total Lines 4
Code Lines 3

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 1
eloc 3
c 0
b 0
f 0
nc 1
nop 0
dl 0
loc 4
rs 10
1
<?php
2
3
class HieraquiaController extends AppController {
4
5 View Code Duplication
	public function listar_cadastros() {
6
		$this->loadModel('Hieraquia');
7
		$dados = $this->Hieraquia->find('all',
8
			array('conditions' => 
9
				array('ativo' => 1,
10
					  'id_usuario' => $this->instancia
11
				)
12
			)
13
		);
14
15
		$this->set('hieraquias', $dados);
16
		$this->layout = 'wadmin';
17
	}
18
19
	public function adicionar_hieraquia() {
20
		$this->layout = 'wadmin';
21
		$this->set('modulos', $this->modulos);
22
	}
23
24
	public function s_adicionar_hieraquia() {
25
		$this->loadModel('Hieraquia');
26
		$dados = $this->request->data('dados');
27
		$hieraquia['nome'] = $dados['nome'];
0 ignored issues
show
Coding Style Comprehensibility introduced by
$hieraquia was never initialized. Although not strictly required by PHP, it is generally a good practice to add $hieraquia = array(); before regardless.

Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code.

Let’s take a look at an example:

foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}

As you can see in this example, the array $myArray is initialized the first time when the foreach loop is entered. You can also see that the value of the bar key is only written conditionally; thus, its value might result from a previous iteration.

This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization $myArray = array() either outside or inside the foreach loop.

Loading history...
28
		$hieraquia['id_usuario'] = $this->instancia;
29
		$hieraquia['ativo'] = 1;
30
31
		if ($this->Hieraquia->save($dados)) {
32
			$this->Session->setFlash('Hieraquia salva com sucesso!');
33
            return $this->redirect('/hieraquia/listar_cadastros');
34
		} else {
35
			$this->Session->setFlash('Ocorreu um erro ao salva o produto!');
36
            return $this->redirect('/hieraquia/listar_cadastros');
37
		}
38
	}
39
	
40
	public function listar_subusuarios() {
41
		$this->layout = 'wadmin';
42
	}
43
44
}