Http - Code Metrics - Inspection of "fix route class" - refatalsakka/framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (3a7ffd)

by refat

created 2020-09-17 08:31 UTC

Http A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	0

Importance

Changes

Metric	Value
dl	0
loc	81
rs	10
c	0
b	0
f	0
wmc	16
lcom	2
cbo	0

6 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	requestProtocol()	4	2
A	isSecure()	7	4
A	checkHttp()	7	3
A	checkHttpXforwardedProto()	7	3
A	checkHttpXforwardedSsl()	7	3

<?php

namespace System\Http;

use System\Application;

class Http
{
    /**
     * Application Object
     *
     * @var \System\Application
     */
    private $app;

    /**
     * Constructor
     *
     * @param \System\Application $app
     */
    public function __construct(Application $app)
    {
        $this->app = $app;
    }

    /**
     * Return https or http
     *
     * @return string
     */
    public function requestProtocol()
    {
        return $this->app->http->isSecure() ? 'https' : 'http';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Check if the website is secure
     *
     * @return bool
     */
    private function isSecure()

    {
        if ($this->checkHttp() || $this->checkHttpXforwardedProto() || $this->checkHttpXforwardedSsl()) {
            return true;
        }
        return false;
    }

    /**
     * Check if HTTPS is 'on'
     *
     * @return bool
     */
    private function checkHttp()
    {
        if (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') {
            return true;
        }
        return false;
    }

    /**
     * Check if HTTP_X_FORWARDED_PROTO is not empty or 'https'
     *
     * @return bool
     */
    private function checkHttpXforwardedProto()
    {
        if (!empty($_SERVER['HTTP_X_FORWARDED_PROTO']) && $_SERVER['HTTP_X_FORWARDED_PROTO'] == 'https') {
            return true;
        }
        return false;
    }

    /**
     * Check if HTTP_X_FORWARDED_SSL is 'on'
     *
     * @return bool
     */
    private function checkHttpXforwardedSsl()
    {
        if (!empty($_SERVER['HTTP_X_FORWARDED_SSL']) && $_SERVER['HTTP_X_FORWARDED_SSL'] == 'on') {
            return true;
        }
        return false;
    }
}


1			<?php
2
3			namespace System\Http;
4
5			use System\Application;
6
7			class Http
8			{
9			/**
10			* Application Object
11			*
12			* @var \System\Application
13			*/
14			private $app;
15
16			/**
17			* Constructor
18			*
19			* @param \System\Application $app
20			*/
21			public function __construct(Application $app)
22			{
23			$this->app = $app;
24			}
25
26			/**
27			* Return https or http
28			*
29			* @return string
30			*/
31			public function requestProtocol()
32			{
33			return $this->app->http->isSecure() ? 'https' : 'http';
			0 ignored issues – show Documentation introduced 2020-09-17 08:35 UTC by Report Bug Copy Issue Report The property `http` does not exist on `object<System\Application>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
34			}
35
36			/**
37			* Check if the website is secure
38			*
39			* @return bool
40			*/
41			private function isSecure()
			0 ignored issues – show Unused Code introduced 2020-09-17 08:35 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history...
42			{
43			if ($this->checkHttp() \|\| $this->checkHttpXforwardedProto() \|\| $this->checkHttpXforwardedSsl()) {
44			return true;
45			}
46			return false;
47			}
48
49			/**
50			* Check if HTTPS is 'on'
51			*
52			* @return bool
53			*/
54			private function checkHttp()
55			{
56			if (isset($_SERVER['HTTPS']) && $_SERVER['HTTPS'] == 'on') {
57			return true;
58			}
59			return false;
60			}
61
62			/**
63			* Check if HTTP_X_FORWARDED_PROTO is not empty or 'https'
64			*
65			* @return bool
66			*/
67			private function checkHttpXforwardedProto()
68			{
69			if (!empty($_SERVER['HTTP_X_FORWARDED_PROTO']) && $_SERVER['HTTP_X_FORWARDED_PROTO'] == 'https') {
70			return true;
71			}
72			return false;
73			}
74
75			/**
76			* Check if HTTP_X_FORWARDED_SSL is 'on'
77			*
78			* @return bool
79			*/
80			private function checkHttpXforwardedSsl()
81			{
82			if (!empty($_SERVER['HTTP_X_FORWARDED_SSL']) && $_SERVER['HTTP_X_FORWARDED_SSL'] == 'on') {
83			return true;
84			}
85			return false;
86			}
87			}
88

refatalsakka / framework

Branch — master (3a7ffd)

Http A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

Duplication Side-by-Side

Filter issues like