Search::search() - Code Metrics - Inspection of "fix" - refatalsakka/framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (7ef48c)

by refat

created 2020-01-31 11:28 UTC

Search::search() A

↳ Parent: Search

Complexity

Conditions	4
Paths	4

Size

Total Lines	53
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	1

Metric	Value
cc	4
eloc	40
c	2
b	1
f	1
nc	4
nop	0
dl	0
loc	53
rs	9.28

How to fix Long Method

<?php

namespace App\Controllers\Admin\User\Traits;

trait Search
{
  public function search()
  {
    $gets = $this->request->gets();

    if (empty($gets)) {
      $users = $this->load->model('User')->users();
      $usersformatted = $this->formatUsers($users);
      $usersformatted = $this->formatUsers($users);
      return json_encode($usersformatted);
    }

    $gender = $gets['gender'] ?? null;
    $zip = $gets['zip'] ?? null;
    $country = $gets['country'] ?? null;
    $registration_from = $gets['registration_from'] ?? null;
    $registration_to = $gets['registration_to'] ?? null;
    $active = $gets['active'] ?? null;
    $pending = $gets['pending'] ?? null;
    $inactive = $gets['inactive'] ?? null;
    $online = $gets['online'] ?? null;
    $offline = $gets['offline'] ?? null;

    $sql = '';
    $wheres = [];

    list($sql, $wheres) = $this->active($active, $sql, $wheres);
    list($sql, $wheres) = $this->pending($pending, $sql, $wheres);
    list($sql, $wheres) = $this->inactive($inactive, $sql, $wheres);
    $sql = $this->formatStatus($sql);
    list($sql, $wheres) = $this->online($online, $sql, $wheres);
    list($sql, $wheres) = $this->offline($offline, $sql, $wheres);
    $sql = $this->formatLogin($sql);
    list($sql, $wheres) = $this->gender($gender, $sql, $wheres);
    list($sql, $wheres) = $this->zip($zip, $sql, $wheres);
    list($sql, $wheres) = $this->country($country, $sql, $wheres);
    list($sql, $wheres) = $this->registration($registration_from, $registration_to, $sql, $wheres);

    $sql = $this->formatSql($sql);

    if ($sql == '') {
      $users = $this->load->model('User')->users();
      $usersformatted = $this->formatUsers($users);
      return json_encode($usersformatted);
    }

    $users = $this->load->model('User')->filter($sql, $wheres);

    $msg = null;
    if (!$users) {
      $msg = 'no users';
      return json_encode($msg);
    }
    $msg = $this->formatUsers($users);
    return json_encode($msg);
  }

  private function active($active, $sql, $wheres)
  {
    if ($active && $active == '1') {
      $sql .= 'status = ? AND ';
      array_push($wheres, '2');
    }
    return [$sql, $wheres];
  }

  private function pending($pending, $sql, $wheres)
  {
    if ($pending && $pending == '1') {
      $sql .= 'status = ? AND ';
      array_push($wheres, '1');
    }
    return [$sql, $wheres];
  }

  private function inactive($inactive, $sql, $wheres)
  {
    if ($inactive && $inactive == '1') {
      $sql .= 'status = ? AND ';
      array_push($wheres, '0');
    }
    return [$sql, $wheres];
  }

  private function formatStatus($sql)
  {
    $count_status = substr_count($sql, 'status = ?');

    if ($count_status > 1) {
      $sql = str_replace('status = ? AND', 'status = ? OR', $sql);
      $sql = rtrim($sql, 'OR ');
      $sql = "( $sql )";
      $sql .= ' AND ';
    }
    return $sql;
  }

  private function online($online, $sql, $wheres)
  {
    if ($online && $online == '1') {
      $sql .= 'is_login = ? AND ';
      array_push($wheres, '1');
    }
    return [$sql, $wheres];
  }

  private function offline($offline, $sql, $wheres)
  {
    if ($offline && $offline == '1') {
      $sql .= 'is_login = ? AND ';
      array_push($wheres, '0');
    }
    return [$sql, $wheres];
  }

  private function formatLogin($sql)
  {
    $count_is_login = substr_count($sql, 'is_login = ?');

    if ($count_is_login > 1) {
      $sql = str_replace('is_login = ? AND', 'is_login = ? OR', $sql);
      $sql = rtrim($sql, 'OR ');
      $sql = "( $sql )";
      $sql .= ' AND ';
    }
    return $sql;
  }

  private function gender($gender, $sql, $wheres) {
    if ($gender) {
      $sql .= 'gender = ? AND ';
      array_push($wheres, $gender);
    }
    return [$sql, $wheres];
  }

  private function zip($zip, $sql, $wheres) {
    if ($zip) {
      $sql .= 'zip = ? AND ';
      array_push($wheres, $zip);
    }
    return [$sql, $wheres];
  }

  private function country($country, $sql, $wheres) {
    if ($country) {
      $sql .= 'country = ? AND ';
      array_push($wheres, $country);
    }
    return [$sql, $wheres];
  }

  private function registration($registration_from, $registration_to, $sql, $wheres) {
    if ($registration_from) {
      $registration_from = date("Y-m-d", strtotime($registration_from));

      if (!$registration_to) {
        $sql .= 'registration >= ? AND ';
        array_push($wheres, $registration_from);
      } else {
        $registration_to = date("Y-m-d", strtotime($registration_to));

        $sql .= 'registration BETWEEN ? AND ? AND ';
        array_push($wheres, $registration_from);
        array_push($wheres, $registration_to);
      }
    }
    return [$sql, $wheres];
  }

  private function formatSql($sql)
  {
    return $sql ? substr($sql, 0, -4) : $sql;
  }
}


refatalsakka / framework

Branch — master (7ef48c)

Search::search() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like