SupportHandler - Code Metrics - Inspection of "Merge pull request #320 from PROCERGS/issue#841" - redelivre/login-cidadao - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1d2904...e25fdf )

by Guilherme

created 2019-02-07 18:51 UTC

SupportHandler A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	110
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
eloc	45
dl	0
loc	110
ccs	45
cts	45
cp	1
rs	10
c	0
b	0
f	0
wmc	14

7 Methods

Rating	Name	Size	Complexity
A	__construct()	10	1
A	getSupportPerson()	8	2
A	getInitialMessage()	6	1
A	getThirdPartyConnections()	17	3
A	getPhoneMetadata()	14	2
A	getValidationMap()	7	1
A	personalDataToValidationArray()	13	4

<?php
/**
 * This file is part of the login-cidadao project or it's bundles.
 *
 * (c) Guilherme Donato <guilhermednt on github>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace LoginCidadao\SupportBundle\Service;

use libphonenumber\PhoneNumber;
use LoginCidadao\CoreBundle\Entity\PersonRepository;
use LoginCidadao\CoreBundle\Entity\SentEmail;
use LoginCidadao\CoreBundle\Entity\SentEmailRepository;
use LoginCidadao\CoreBundle\Model\IdentifiablePersonInterface;
use LoginCidadao\CoreBundle\Model\PersonInterface;
use LoginCidadao\PhoneVerificationBundle\Service\PhoneVerificationServiceInterface;
use LoginCidadao\SupportBundle\Exception\PersonNotFoundException;
use LoginCidadao\SupportBundle\Model\PersonalData;
use LoginCidadao\SupportBundle\Model\SupportPerson;
use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;

class SupportHandler
{
    /** @var AuthorizationCheckerInterface */
    private $authChecker;

    /** @var PhoneVerificationServiceInterface */
    private $phoneVerificationService;

    /** @var PersonRepository */
    private $personRepository;

    /** @var SentEmailRepository */
    private $sentEmailRepository;

    /**
     * SupportHandler constructor.
     * @param AuthorizationCheckerInterface $authChecker
     * @param PhoneVerificationServiceInterface $phoneVerificationService
     * @param PersonRepository $personRepository
     * @param SentEmailRepository $sentEmailRepository
     */
    public function __construct(
        AuthorizationCheckerInterface $authChecker,
        PhoneVerificationServiceInterface $phoneVerificationService,
        PersonRepository $personRepository,
        SentEmailRepository $sentEmailRepository
    ) {
        $this->authChecker = $authChecker;
        $this->phoneVerificationService = $phoneVerificationService;
        $this->personRepository = $personRepository;
        $this->sentEmailRepository = $sentEmailRepository;
    }

    public function getSupportPerson($id): SupportPerson
    {
        $person = $this->personRepository->find($id);
        if (!$person instanceof PersonInterface) {
            throw new PersonNotFoundException();
        }

        return new SupportPerson($person, $this->authChecker);
    }

    public function getThirdPartyConnections(IdentifiablePersonInterface $person): array
    {
        $connections = [];
        if (!$person instanceof PersonInterface) {
            /** @var PersonInterface $person */
            $person = $this->personRepository->find($person->getId());
        }

        if ($person instanceof PersonInterface) {

            $connections = [
                'facebook' => $person->getFacebookId() !== null,
                'google' => $person->getGoogleId() !== null,
                'twitter' => $person->getTwitterId() !== null,
            ];
        }

        return $connections;
    }

    public function getPhoneMetadata(IdentifiablePersonInterface $person): array
    {
        /** @var PersonInterface $person */
        $person = $this->personRepository->find($person->getId());
        $phone = $person->getMobile();

        if ($phone instanceof PhoneNumber) {
            $samePhoneCount = $this->personRepository->countByPhone($phone);
            $phoneVerification = $this->phoneVerificationService->getPhoneVerification($person, $phone);
        }

        return [
            'samePhoneCount' => $samePhoneCount ?? 0,
            'verification' => $phoneVerification ?? null,
        ];
    }

    public function getInitialMessage($ticket): ?SentEmail
    {
        /** @var SentEmail $sentEmail */
        $sentEmail = $this->sentEmailRepository->findOneBy(['supportTicket' => $ticket]);

        return $sentEmail;
    }

    public function getValidationMap(SupportPerson $person): array
    {
        return array_filter([
            'cpf' => $this->personalDataToValidationArray($person->getCpf(), true),
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            'birthday' => $this->personalDataToValidationArray($person->getBirthday(), true),
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            'email' => $this->personalDataToValidationArray($person->getEmail(), true),
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
            'phoneNumber' => $this->personalDataToValidationArray($person->getPhoneNumber(), true),
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {
        ]);
    }

    private function personalDataToValidationArray(PersonalData $data, bool $skipIfValueSet = false): ?array
    {
        if (false === $data->isValueFilled()) {
            return null;
        }
        if ($skipIfValueSet && $data->getValue() !== null) {
            return null;
        }

        return [
            'name' => $data->getName(),
            'hash' => $data->getHash(),
            'challenge' => $data->getChallenge(),
        ];
    }
}


1		<?php
2		/**
3		* This file is part of the login-cidadao project or it's bundles.
4		*
5		* (c) Guilherme Donato <guilhermednt on github>
6		*
7		* For the full copyright and license information, please view the LICENSE
8		* file that was distributed with this source code.
9		*/
10
11		namespace LoginCidadao\SupportBundle\Service;
12
13		use libphonenumber\PhoneNumber;
14		use LoginCidadao\CoreBundle\Entity\PersonRepository;
15		use LoginCidadao\CoreBundle\Entity\SentEmail;
16		use LoginCidadao\CoreBundle\Entity\SentEmailRepository;
17		use LoginCidadao\CoreBundle\Model\IdentifiablePersonInterface;
18		use LoginCidadao\CoreBundle\Model\PersonInterface;
19		use LoginCidadao\PhoneVerificationBundle\Service\PhoneVerificationServiceInterface;
20		use LoginCidadao\SupportBundle\Exception\PersonNotFoundException;
21		use LoginCidadao\SupportBundle\Model\PersonalData;
22		use LoginCidadao\SupportBundle\Model\SupportPerson;
23		use Symfony\Component\Security\Core\Authorization\AuthorizationCheckerInterface;
24
25		class SupportHandler
26		{
27		/** @var AuthorizationCheckerInterface */
28		private $authChecker;
29
30		/** @var PhoneVerificationServiceInterface */
31		private $phoneVerificationService;
32
33		/** @var PersonRepository */
34		private $personRepository;
35
36		/** @var SentEmailRepository */
37		private $sentEmailRepository;
38
39		/**
40		* SupportHandler constructor.
41		* @param AuthorizationCheckerInterface $authChecker
42		* @param PhoneVerificationServiceInterface $phoneVerificationService
43		* @param PersonRepository $personRepository
44		* @param SentEmailRepository $sentEmailRepository
45		*/
46	10	public function __construct(
47		AuthorizationCheckerInterface $authChecker,
48		PhoneVerificationServiceInterface $phoneVerificationService,
49		PersonRepository $personRepository,
50		SentEmailRepository $sentEmailRepository
51		) {
52	10	$this->authChecker = $authChecker;
53	10	$this->phoneVerificationService = $phoneVerificationService;
54	10	$this->personRepository = $personRepository;
55	10	$this->sentEmailRepository = $sentEmailRepository;
56	10	}
57
58	2	public function getSupportPerson($id): SupportPerson
59		{
60	2	$person = $this->personRepository->find($id);
61	2	if (!$person instanceof PersonInterface) {
62	1	throw new PersonNotFoundException();
63		}
64
65	1	return new SupportPerson($person, $this->authChecker);
66		}
67
68	3	public function getThirdPartyConnections(IdentifiablePersonInterface $person): array
69		{
70	3	$connections = [];
71	3	if (!$person instanceof PersonInterface) {
72		/** @var PersonInterface $person */
73	2	$person = $this->personRepository->find($person->getId());
74		}
75
76	3	if ($person instanceof PersonInterface) {
		0 ignored issues – show introduced 2019-02-07 18:48 UTC by Report Bug Copy Issue Report `$person` is always a sub-type of `LoginCidadao\CoreBundle\Model\PersonInterface`. Loading history...
77		$connections = [
78	2	'facebook' => $person->getFacebookId() !== null,
79	2	'google' => $person->getGoogleId() !== null,
80	2	'twitter' => $person->getTwitterId() !== null,
81		];
82		}
83
84	3	return $connections;
85		}
86
87	3	public function getPhoneMetadata(IdentifiablePersonInterface $person): array
88		{
89		/** @var PersonInterface $person */
90	3	$person = $this->personRepository->find($person->getId());
91	3	$phone = $person->getMobile();
92
93	3	if ($phone instanceof PhoneNumber) {
94	2	$samePhoneCount = $this->personRepository->countByPhone($phone);
95	2	$phoneVerification = $this->phoneVerificationService->getPhoneVerification($person, $phone);
96		}
97
98		return [
99	3	'samePhoneCount' => $samePhoneCount ?? 0,
100	3	'verification' => $phoneVerification ?? null,
101		];
102		}
103
104	1	public function getInitialMessage($ticket): ?SentEmail
105		{
106		/** @var SentEmail $sentEmail */
107	1	$sentEmail = $this->sentEmailRepository->findOneBy(['supportTicket' => $ticket]);
108
109	1	return $sentEmail;
110		}
111
112	1	public function getValidationMap(SupportPerson $person): array
113		{
114	1	return array_filter([
115	1	'cpf' => $this->personalDataToValidationArray($person->getCpf(), true),
		0 ignored issues – show Bug introduced 2019-02-06 17:24 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->personalDataToVal...person->getCpf(), true)` targeting `LoginCidadao\SupportBund...DataToValidationArray()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
116	1	'birthday' => $this->personalDataToValidationArray($person->getBirthday(), true),
		0 ignored issues – show Bug introduced 2019-02-06 17:24 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->personalDataToVal...n->getBirthday(), true)` targeting `LoginCidadao\SupportBund...DataToValidationArray()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
117	1	'email' => $this->personalDataToValidationArray($person->getEmail(), true),
		0 ignored issues – show Bug introduced 2019-02-06 17:24 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->personalDataToVal...rson->getEmail(), true)` targeting `LoginCidadao\SupportBund...DataToValidationArray()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
118	1	'phoneNumber' => $this->personalDataToValidationArray($person->getPhoneNumber(), true),
		0 ignored issues – show Bug introduced 2019-02-06 17:24 UTC by Report Bug Copy Issue Report Are you sure the usage of `$this->personalDataToVal...getPhoneNumber(), true)` targeting `LoginCidadao\SupportBund...DataToValidationArray()` seems to always return null. This check looks for function or method calls that always return null and whose return value is used. class A { function getObject() { return null; } } $a = new A(); if ($a->getObject()) { The method `getObject()` can return nothing but null, so it makes no sense to use the return value. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
119		]);
120		}
121
122	1	private function personalDataToValidationArray(PersonalData $data, bool $skipIfValueSet = false): ?array
123		{
124	1	if (false === $data->isValueFilled()) {
125	1	return null;
126		}
127	1	if ($skipIfValueSet && $data->getValue() !== null) {
128	1	return null;
129		}
130
131		return [
132	1	'name' => $data->getName(),
133	1	'hash' => $data->getHash(),
134	1	'challenge' => $data->getChallenge(),
135		];
136		}
137		}
138

redelivre / login-cidadao

Push — master ( 1d2904...e25fdf )

SupportHandler A

Complexity

Size/Duplication

Test Coverage

Importance

7 Methods

Duplication Side-by-Side

Filter issues like