AdminBlocklistController::newAction() - Code Metrics - Inspection of "Created phone blocklist" - redelivre/login-cidadao - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — master (#317)

by Guilherme
created 2019-01-30 13:00 UTC
AdminBlocklistController::newAction() A

↳ Parent: AdminBlocklistController
Complexity

Conditions	4
Paths	3
Size

Total Lines	28
Code Lines	17
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	4
eloc	17
nc	3
nop	1
dl	0
loc	28
rs	9.7
c	0
b	0
f	0
<?php
/**
 * This file is part of the login-cidadao project or it's bundles.
 *
 * (c) Guilherme Donato <guilhermednt on github>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace LoginCidadao\PhoneVerificationBundle\Controller;

use libphonenumber\NumberParseException;
use libphonenumber\PhoneNumber;
use libphonenumber\PhoneNumberType;
use libphonenumber\PhoneNumberUtil;
use LoginCidadao\CoreBundle\Entity\PersonRepository;
use LoginCidadao\CoreBundle\Helper\GridHelper;
use LoginCidadao\PhoneVerificationBundle\Entity\BlockedPhoneNumber;
use LoginCidadao\PhoneVerificationBundle\Entity\BlockedPhoneNumberRepository;
use LoginCidadao\PhoneVerificationBundle\Form\BlockPhoneFormType;
use LoginCidadao\PhoneVerificationBundle\Form\SearchPhoneNumberType;
use LoginCidadao\PhoneVerificationBundle\Model\BlockedPhoneNumberInterface;
use LoginCidadao\PhoneVerificationBundle\Model\BlockPhoneNumberRequest;
use LoginCidadao\PhoneVerificationBundle\Service\BlocklistInterface;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Session\Session;
use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
use Symfony\Component\Routing\Annotation\Route;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;

/**
 * Class AdminBlocklistController
 * @package LoginCidadao\PhoneVerificationBundle\Controller
 *
 * @Security("has_role('ROLE_EDIT_BLOCKED_PHONES')")
 * @codeCoverageIgnore
 */
class AdminBlocklistController extends Controller
{
    /**
     * @Route("/admin/phones/blocklist", name="phone_blocklist_list")
     * @Template()
     */
    public function listAction(Request $request)
    {
        $form = $this->createForm(SearchPhoneNumberType::class);

        $form->handleRequest($request);
        if ($form->isSubmitted() && $form->isValid()) {
            $data = $form->getData();

            $grid = new GridHelper();
            $grid->setId('person-grid');
            $grid->setPerPage(5);
            $grid->setMaxResult(5);
            $grid->setInfiniteGrid(true);
            $grid->setRoute('lc_admin_person_grid');
            $grid->setRouteParams([$form->getName()]);

            if ($data['phone']) {
                /** @var BlockedPhoneNumberRepository $blockedPhoneRepo */
                $blockedPhoneRepo = $this->getDoctrine()->getRepository(BlockedPhoneNumber::class);
                $query = $blockedPhoneRepo->getSearchByPartialPhoneQuery($data['phone']);
                $grid->setQueryBuilder($query);
                /** @scrutinizer ignore-deprecated */ $grid->setQueryBuilder($query);
            }

            $gridView = $grid->createView($request);
        }

        return [
            'form' => $form->createView(),
            'grid' => $gridView ?? null,
        ];
    }

    /**
     * @Route("/admin/phones/blocklist/new", name="phone_blocklist_new")
     * @Template()
     */
    public function newAction(Request $request)
    {
        $blockRequest = new BlockPhoneNumberRequest($this->getUser());
        $blockRequest = new BlockPhoneNumberRequest(/** @scrutinizer ignore-type */ $this->getUser());

        $blockedPhones = [];
        $form = $this->createForm(BlockPhoneFormType::class, $blockRequest);

        $form->handleRequest($request);
        if ($form->isSubmitted() && $form->isValid()) {
            $phoneNumber = $blockRequest->phoneNumber;

            $blocklist = $this->getBlocklistService();
            $blockedPhoneNumber = $blocklist->addBlockedPhoneNumber($phoneNumber, $blockRequest->getBlockedBy());
            $blockedPhones = $blocklist->checkPhoneNumber($blockedPhoneNumber->getPhoneNumber());

            /** @var Session $session */
            $session = $request->getSession();
            $session->getFlashBag()->add('success', "Phone number successfully banned.");
            if (($count = count($blockedPhones)) > 0) {
                $session->getFlashBag()->add('success', "{$count} accounts were blocked blocked.");
            }

            return $this->redirectToRoute('phone_blocklist_list');
        }

        return [
            'form' => $form->createView(),
            'blockedPhones' => $blockedPhones,
        ];
    }

    /**
     * @Route("/admin/phones/blocklist/{phone}", name="phone_blocklist_details", requirements={"phone": "[0-9+]+"})
     * @Template()
     */
    public function detailsAction(Request $request, string $phone)
    {
        $phoneNumber = $this->parsePhone($phone);
        $blockedPhone = $this->getOr404($phoneNumber);

        return [
            'blockedPhone' => $blockedPhone,
            'grid' => $this->getUsersByPhoneGrid($request, $phoneNumber),
        ];
    }

    /**
     * @return BlocklistInterface
     */
    private function getBlocklistService(): BlocklistInterface
    {
        /** @var BlocklistInterface $blocklistService */
        $blocklistService = $this->get('phone_verification.blocklist');

        return $blocklistService;
    }

    private function parsePhone($phone): PhoneNumber
    {
        $phoneUtils = PhoneNumberUtil::getInstance();
        try {
            return $phoneUtils->parse($phone);
        } catch (NumberParseException $e) {
            throw new BadRequestHttpException("Invalid phone number");
        }
    }

    private function getOr404(PhoneNumber $phoneNumber): BlockedPhoneNumberInterface
    {
        $blocklistService = $this->getBlocklistService();
        $blockedPhone = $blocklistService->getBlockedPhoneNumberByPhone($phoneNumber);

        if (null === $blockedPhone) {
            throw new NotFoundHttpException("Blocked Phone Number not found");
        }

        return $blockedPhone;
    }

    private function getUsersByPhoneGrid(Request $request, PhoneNumber $phoneNumber)
    {
        $grid = new GridHelper();
        $grid->setId('person-grid');
        $grid->setPerPage(5);
        $grid->setMaxResult(5);
        $grid->setInfiniteGrid(true);
        $grid->setRoute('phone_blocklist_details');
        $grid->setRouteParams(['phone']);

        /** @var PersonRepository $repo */
        $repo = $this->getDoctrine()->getRepository('LoginCidadaoCoreBundle:Person');
        $query = $repo->getPhoneSearchQuery($phoneNumber);
        $grid->setQueryBuilder($query);
        /** @scrutinizer ignore-deprecated */ $grid->setQueryBuilder($query);

        return $grid->createView($request);
    }
}

redelivre / login-cidadao

Pull Request — master (#317)

AdminBlocklistController::newAction() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like
