Zip_Manager::createDir() - Code Metrics - Inspection of "Merge pull request #16 from PROCERGS/community" - redelivre/login-cidadao - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (ca1420)

by Guilherme

created 2016-02-26 20:35 UTC

Zip_Manager::createDir() A

↳ Parent: Zip_Manager

Complexity

Conditions	3
Paths	3

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	8
rs	9.4285
cc	3
eloc	4
nc	3
nop	1

<?php
class Zip_Manager extends \ZipArchive
namespace YourVendor;

class YourClass { }
{

    const CHMOD = 0755;

    public function filteredExtractTo($directory, array $filters = null)

    {
        if (count($filters) === 0) {
            return $this->extractTo($directory);
        }

        $this->createDir($directory);

        $copySource = 'zip://' . $this->filename . '#';
        for ($i = 0; $i < $this->numFiles; $i ++) {
            $entry = $this->getNameIndex($i);
            $filename = basename($entry);

            if ($this->matchFileToFilter($filename, $filters)) {
                $base = dirname($entry);
                $newPath = $directory . DIRECTORY_SEPARATOR . $base . DIRECTORY_SEPARATOR;
                $this->createDir($newPath);

                // extract file
                copy($copySource . $entry, $newPath . $filename);
            }
        }
    }

    protected function createDir($path)
    {
        if (! is_dir($path)) {
            if (! mkdir($path, self::CHMOD, true)) {
                throw new Exception('unable to create path ' . $path);
            }
        }
    }

    protected function matchFileToFilter($filename, array $filters)

    {
        $ext = strtolower(pathinfo($filename, PATHINFO_EXTENSION));
        if (in_array($ext, array_map('strtolower', $filters))) {


            return true;
        }

        foreach ($filters as $i => $filter) {


            if (! ctype_alnum($filter[0]) && preg_match($filter, $filename)) {
                return true;
            }
        }
        return false;
    }
}

function getTempNam($prefix = "php")
{
    $tmp = getenv('TMPDIR');
    if ($tmp && @is_writable($tmp)) {
        $tmpDir = $tmp;
    } elseif (function_exists('sys_get_temp_dir') && @is_writable(sys_get_temp_dir())) {
        $tmpDir = sys_get_temp_dir();
    }
    return tempnam($tmpDir, $prefix);
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
}

function file_get_contents_curl($url, $file, $referer = null)

{
    $ch = curl_init();
    // curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
    $f = fopen($file, 'wb');
    if (! $f) {
        return false;
    }
    curl_setopt($ch, CURLOPT_FILE, $f);
    curl_setopt($ch, CURLOPT_HEADER, 0);
    curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
    curl_setopt($ch, CURLOPT_ENCODING, '');
    curl_setopt($ch, CURLOPT_URL, $url);
    if ($referer) {
        curl_setopt($ch, CURLOPT_REFERER, $referer);
    }
    $result = curl_exec($ch);
    if (!$result) {
        echo curl_error ($ch );

    }
    curl_close($ch);
    fclose($f);
    return $result;
}

function getPDOConnection($config)
{
    $db_driver = $config['database_driver'];

    $db_host = $config['database_host'];

    $db_name = $config['database_name'];

    $db_user = $config['database_user'];

    $db_pass = $config['database_password'];

    $db_port = $config['database_port'];

    $pdo = new PDO("$db_driver:host=$db_host;port=$db_port;dbname=$db_name", $db_user, $db_pass);

    $pdo->setAttribute(PDO::ATTR_DEFAULT_FETCH_MODE, PDO::FETCH_ASSOC);
    $pdo->query("SET NAMES 'UTF8'");
    return $pdo;
}
function trim2($s)
{
    $s = trim($s, " \t\n\r\0\x0B-");
    if ('' === $s) {
        return null;
    } else {
        return $s;
    }
}
function utf8_encode_recursivo($in)

{
    if (is_array($in)) {
        foreach ($in as $key => $value) {
            $out[utf8_encode_recursivo($key)] = utf8_encode_recursivo($value);
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        }
    } elseif(is_string($in)) {

        if(!mb_check_encoding($in, 'UTF-8')

            OR !($in === mb_convert_encoding(mb_convert_encoding($in, 'UTF-32', 'UTF-8' ), 'UTF-8', 'UTF-32'))) {

                $in = mb_convert_encoding($in, 'UTF-8');
            }

            return $in;
    } else {
        return $in;
    }
    return $out;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
}


1			<?php
2			class Zip_Manager extends \ZipArchive
			0 ignored issues – show Coding Style introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report `Zip_Manager` does not seem to conform to the naming convention (`^[A-Z][a-zA-Z0-9]$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history... Coding Style Compatibility introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history... Coding Style introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report This class is not in CamelCase format. Classes in PHP are usually named in CamelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. The whole name starts with a capital letter as well. Thus the name database provider* becomes `DatabaseProvider`. Loading history...
3			{
4
5			const CHMOD = 0755;
6
7			public function filteredExtractTo($directory, array $filters = null)
			0 ignored issues – show Documentation introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
8			{
9			if (count($filters) === 0) {
10			return $this->extractTo($directory);
11			}
12
13			$this->createDir($directory);
14
15			$copySource = 'zip://' . $this->filename . '#';
16			for ($i = 0; $i < $this->numFiles; $i ++) {
17			$entry = $this->getNameIndex($i);
18			$filename = basename($entry);
19
20			if ($this->matchFileToFilter($filename, $filters)) {
21			$base = dirname($entry);
22			$newPath = $directory . DIRECTORY_SEPARATOR . $base . DIRECTORY_SEPARATOR;
23			$this->createDir($newPath);
24
25			// extract file
26			copy($copySource . $entry, $newPath . $filename);
27			}
28			}
29			}
30
31			protected function createDir($path)
32			{
33			if (! is_dir($path)) {
34			if (! mkdir($path, self::CHMOD, true)) {
35			throw new Exception('unable to create path ' . $path);
36			}
37			}
38			}
39
40			protected function matchFileToFilter($filename, array $filters)
			0 ignored issues – show Coding Style introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report `function matchFileToFilter()` does not seem to conform to the naming convention (`^(?:is\|has\|should\|may\|supports)`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
41			{
42			$ext = strtolower(pathinfo($filename, PATHINFO_EXTENSION));
43			if (in_array($ext, array_map('strtolower', $filters))) {
			0 ignored issues – show Coding Style introduced 2016-02-26 19:07 UTC by Report Bug Copy Issue Report Blank line found at start of control structure Loading history...
44
45			return true;
46			}
47
48			foreach ($filters as $i => $filter) {
			0 ignored issues – show Coding Style introduced 2016-02-26 19:07 UTC by Report Bug Copy Issue Report Blank line found at start of control structure Loading history...
49
50			if (! ctype_alnum($filter[0]) && preg_match($filter, $filename)) {
51			return true;
52			}
53			}
54			return false;
55			}
56			}
57
58			function getTempNam($prefix = "php")
59			{
60			$tmp = getenv('TMPDIR');
61			if ($tmp && @is_writable($tmp)) {
62			$tmpDir = $tmp;
63			} elseif (function_exists('sys_get_temp_dir') && @is_writable(sys_get_temp_dir())) {
64			$tmpDir = sys_get_temp_dir();
65			}
66			return tempnam($tmpDir, $prefix);
			0 ignored issues – show Bug introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report The variable `$tmpDir` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
67			}
68
69			function file_get_contents_curl($url, $file, $referer = null)
			0 ignored issues – show Coding Style introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report `function file_get_contents_curl()` does not seem to conform to the naming convention (`^(?:[a-z]\|__)[a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
70			{
71			$ch = curl_init();
72			// curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
73			$f = fopen($file, 'wb');
74			if (! $f) {
75			return false;
76			}
77			curl_setopt($ch, CURLOPT_FILE, $f);
78			curl_setopt($ch, CURLOPT_HEADER, 0);
79			curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
80			curl_setopt($ch, CURLOPT_ENCODING, '');
81			curl_setopt($ch, CURLOPT_URL, $url);
82			if ($referer) {
83			curl_setopt($ch, CURLOPT_REFERER, $referer);
84			}
85			$result = curl_exec($ch);
86			if (!$result) {
87			echo curl_error ($ch );
			0 ignored issues – show Coding Style introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report Space before opening parenthesis of function call prohibited Loading history...
88			}
89			curl_close($ch);
90			fclose($f);
91			return $result;
92			}
93
94			function getPDOConnection($config)
95			{
96			$db_driver = $config['database_driver'];
			0 ignored issues – show Coding Style introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report `$db_driver` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
97			$db_host = $config['database_host'];
			0 ignored issues – show Coding Style introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report `$db_host` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
98			$db_name = $config['database_name'];
			0 ignored issues – show Coding Style introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report `$db_name` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
99			$db_user = $config['database_user'];
			0 ignored issues – show Coding Style introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report `$db_user` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
100			$db_pass = $config['database_password'];
			0 ignored issues – show Coding Style introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report `$db_pass` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
101			$db_port = $config['database_port'];
			0 ignored issues – show Coding Style introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report `$db_port` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
102			$pdo = new PDO("$db_driver:host=$db_host;port=$db_port;dbname=$db_name", $db_user, $db_pass);
			0 ignored issues – show Coding Style introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report `$db_driver` does not seem to conform to the naming convention (`^[a-z][a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history...
103			$pdo->setAttribute(PDO::ATTR_DEFAULT_FETCH_MODE, PDO::FETCH_ASSOC);
104			$pdo->query("SET NAMES 'UTF8'");
105			return $pdo;
106			}
107			function trim2($s)
108			{
109			$s = trim($s, " \t\n\r\0\x0B-");
110			if ('' === $s) {
111			return null;
112			} else {
113			return $s;
114			}
115			}
116			function utf8_encode_recursivo($in)
			0 ignored issues – show Coding Style introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report `function utf8_encode_recursivo()` does not seem to conform to the naming convention (`^(?:[a-z]\|__)[a-zA-Z0-9]*$`). This check examines a number of code elements and verifies that they conform to the given naming conventions. You can set conventions for local variables, abstract classes, utility classes, constant, properties, methods, parameters, interfaces, classes, exceptions and special methods. Loading history... Documentation introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
117			{
118			if (is_array($in)) {
119			foreach ($in as $key => $value) {
120			$out[utf8_encode_recursivo($key)] = utf8_encode_recursivo($value);
			0 ignored issues – show Coding Style Comprehensibility introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report `$out` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$out = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
121			}
122			} elseif(is_string($in)) {
			0 ignored issues – show Coding Style introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report Expected 1 space after ELSEIF keyword; 0 found Loading history...
123			if(!mb_check_encoding($in, 'UTF-8')
			0 ignored issues – show Coding Style introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report Expected 1 space after IF keyword; 0 found Loading history...
124			OR !($in === mb_convert_encoding(mb_convert_encoding($in, 'UTF-32', 'UTF-8' ), 'UTF-8', 'UTF-32'))) {
			0 ignored issues – show Coding Style introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report As per coding-style, PHP keywords should be in lowercase; expected `or`, but found `OR`. Loading history...
125			$in = mb_convert_encoding($in, 'UTF-8');
126			}
			1 ignored issue – show Coding Style introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report Line indented incorrectly; expected 8 spaces, found 12 Loading history... Coding Style introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report Closing brace indented incorrectly; expected 8 spaces, found 12 Loading history...
127			return $in;
128			} else {
129			return $in;
130			}
131			return $out;
			0 ignored issues – show Bug introduced 2016-02-25 11:49 UTC by Report Bug Copy Issue Report The variable `$out` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
132			}
133

redelivre / login-cidadao

Branch — master (ca1420)

Zip_Manager::createDir() A

Complexity

Size

Duplication

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like