Issues in AbstractCommand.php (master) - Issues in master - reddogs-at/reddogs-doctrine-migrations - Measure and Improve Code Quality continuously with Scrutinizer

Issues (18)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/AbstractCommand.php (1 issue)

Labels

Bug 1

Severity

Major 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Reddogs (https://github.com/reddogs-at)
 *
 * @see https://github.com/reddogs-at/reddogs-doctrine-migrations for the canonical source repository
 * @license https://github.com/reddogs-at/reddogs-doctrine-migrations/blob/master/LICENSE MIT License
 */
namespace Reddogs\Doctrine\Migrations;

use Symfony\Component\Console\Application;
use Doctrine\DBAL\Migrations\Tools\Console\Command\AbstractCommand as MigrationsCommand;
use Doctrine\DBAL\Migrations\Configuration\Configuration;
use ZF\Console\Route;
use Zend\Console\Adapter\AdapterInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Input\StringInput;

abstract class AbstractCommand
{

    /**
     * Application
     *
     * @var Application
     */
    private $application;

    /**
     * Migrations command
     *
     * @var MigrationsCommand
     */
    private $migrationsCommand;

    /**
     * Configuration
     *
     * @var Configuration
     */
    private $configuration;

    /**
     * Output
     *
     * @var OutputInterface
     */
    private $output;

    /**
     * Migrations config
     *
     * @var array
     */
    private $migrationsConfig;

    /**
     * Constructor
     *
     * @param Application $application
     * @param MigrationsCommand $migrationsCommand
     * @param Configuration $configuration
     * @param OutputInterface $output
     * @param array $migrationsConfig
     */
    public function __construct(
        Application $application, MigrationsCommand $migrationsCommand, Configuration $configuration,
        OutputInterface $output, array $migrationsConfig)
    {
        $this->application = $application;
        $this->migrationsCommand = $migrationsCommand;
        $this->configuration = $configuration;
        $this->output = $output;
        $this->migrationsConfig = $migrationsConfig;
    }

    public function __invoke(Route $route, AdapterInterface $console)
    {
        $migrationsConfig = $this->getMigrationsConfig();
        $moduleName = $route->getMatchedParam('moduleName');

        $params = $migrationsConfig[$moduleName];

        $configuration = $this->getConfiguration();
        $configuration->setMigrationsNamespace($params['namespace']);
        $configuration->setMigrationsDirectory($params['directory']);
        $configuration->setMigrationsTableName($params['table_name']);
        $configuration->registerMigrationsFromDirectory($params['directory']);

        $migrationsCommand = $this->getMigrationsCommand();
        $migrationsCommand->setMigrationConfiguration($configuration);

        $application = $this->getApplication();
        $application->add($migrationsCommand);

        $input = new StringInput($this->getInputCommand($route));
        $application->run($input, $this->getOutput());
    }

    /**
     * Get input command
     *
     * @param Route $route
     * @return string
     */
    abstract public function getInputCommand(Route $route);

    /**
     * Apply boolean params
     *
     * @param array $params
     * @param array $matches
     * @return array
     */
    protected function applyBooleanParams(array $params, array $matches)
    {
        foreach ($this->booleanParams as $booleanParam) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            if (true === $matches[ltrim($booleanParam, '-')]) {
                $params[] = $booleanParam;
            }
        }
        return $params;
    }

    /**
     * Get application
     *
     * @return Application
     */
    public function getApplication()
    {
        return $this->application;
    }

    /**
     * Get migrations command
     *
     * @return MigrationsCommand
     */
    public function getMigrationsCommand()
    {
        return $this->migrationsCommand;
    }

    /**
     * Get configuration
     *
     * @return Configuration
     */
    public function getConfiguration()
    {
        return $this->configuration;
    }

    /**
     * Get migrations config
     *
     * @return the array
     */
    public function getMigrationsConfig()
    {
        return $this->migrationsConfig;
    }

    /**
     * Get output
     *
     * @return OutputInterface
     */
    public function getOutput()
    {
        return $this->output;
    }
}

1			<?php
2			/**
3			* Reddogs (https://github.com/reddogs-at)
4			*
5			* @see https://github.com/reddogs-at/reddogs-doctrine-migrations for the canonical source repository
6			* @license https://github.com/reddogs-at/reddogs-doctrine-migrations/blob/master/LICENSE MIT License
7			*/
8			namespace Reddogs\Doctrine\Migrations;
9
10			use Symfony\Component\Console\Application;
11			use Doctrine\DBAL\Migrations\Tools\Console\Command\AbstractCommand as MigrationsCommand;
12			use Doctrine\DBAL\Migrations\Configuration\Configuration;
13			use ZF\Console\Route;
14			use Zend\Console\Adapter\AdapterInterface;
15			use Symfony\Component\Console\Output\OutputInterface;
16			use Symfony\Component\Console\Input\StringInput;
17
18			abstract class AbstractCommand
19			{
20
21			/**
22			* Application
23			*
24			* @var Application
25			*/
26			private $application;
27
28			/**
29			* Migrations command
30			*
31			* @var MigrationsCommand
32			*/
33			private $migrationsCommand;
34
35			/**
36			* Configuration
37			*
38			* @var Configuration
39			*/
40			private $configuration;
41
42			/**
43			* Output
44			*
45			* @var OutputInterface
46			*/
47			private $output;
48
49			/**
50			* Migrations config
51			*
52			* @var array
53			*/
54			private $migrationsConfig;
55
56			/**
57			* Constructor
58			*
59			* @param Application $application
60			* @param MigrationsCommand $migrationsCommand
61			* @param Configuration $configuration
62			* @param OutputInterface $output
63			* @param array $migrationsConfig
64			*/
65			public function __construct(
66			Application $application, MigrationsCommand $migrationsCommand, Configuration $configuration,
67			OutputInterface $output, array $migrationsConfig)
68			{
69			$this->application = $application;
70			$this->migrationsCommand = $migrationsCommand;
71			$this->configuration = $configuration;
72			$this->output = $output;
73			$this->migrationsConfig = $migrationsConfig;
74			}
75
76			public function __invoke(Route $route, AdapterInterface $console)
77			{
78			$migrationsConfig = $this->getMigrationsConfig();
79			$moduleName = $route->getMatchedParam('moduleName');
80
81			$params = $migrationsConfig[$moduleName];
82
83			$configuration = $this->getConfiguration();
84			$configuration->setMigrationsNamespace($params['namespace']);
85			$configuration->setMigrationsDirectory($params['directory']);
86			$configuration->setMigrationsTableName($params['table_name']);
87			$configuration->registerMigrationsFromDirectory($params['directory']);
88
89			$migrationsCommand = $this->getMigrationsCommand();
90			$migrationsCommand->setMigrationConfiguration($configuration);
91
92			$application = $this->getApplication();
93			$application->add($migrationsCommand);
94
95			$input = new StringInput($this->getInputCommand($route));
96			$application->run($input, $this->getOutput());
97			}
98
99			/**
100			* Get input command
101			*
102			* @param Route $route
103			* @return string
104			*/
105			abstract public function getInputCommand(Route $route);
106
107			/**
108			* Apply boolean params
109			*
110			* @param array $params
111			* @param array $matches
112			* @return array
113			*/
114			protected function applyBooleanParams(array $params, array $matches)
115			{
116			foreach ($this->booleanParams as $booleanParam) {
			0 ignored issues – show Bug introduced 2016-10-07 05:35 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `booleanParams` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
117			if (true === $matches[ltrim($booleanParam, '-')]) {
118			$params[] = $booleanParam;
119			}
120			}
121			return $params;
122			}
123
124			/**
125			* Get application
126			*
127			* @return Application
128			*/
129			public function getApplication()
130			{
131			return $this->application;
132			}
133
134			/**
135			* Get migrations command
136			*
137			* @return MigrationsCommand
138			*/
139			public function getMigrationsCommand()
140			{
141			return $this->migrationsCommand;
142			}
143
144			/**
145			* Get configuration
146			*
147			* @return Configuration
148			*/
149			public function getConfiguration()
150			{
151			return $this->configuration;
152			}
153
154			/**
155			* Get migrations config
156			*
157			* @return the array
158			*/
159			public function getMigrationsConfig()
160			{
161			return $this->migrationsConfig;
162			}
163
164			/**
165			* Get output
166			*
167			* @return OutputInterface
168			*/
169			public function getOutput()
170			{
171			return $this->output;
172			}
173			}

reddogs-at / reddogs-doctrine-migrations

Issues (18)

Security Analysis no request data

src/AbstractCommand.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like