Inspection of "Merge pull request #802 from shandak/translationIm..." - redCOMPONENT-COM/redCORE - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — develop (d6f62e)

by Tito

created 2017-11-09 09:25 UTC

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

@@ -43,15 +43,15 @@
 block discarded – undo
 					<ul>
 						<?php foreach ($scopeList as $scope) :?>
 							<li><?php echo $scope['scopeDisplayName']; ?></li>
-						<?php endforeach;?>
+						<?php endforeach; ?>
 					</ul>
 				</div>
 			</div>
-			<?php if ((++$column) % 3 == 0 ) : ?>
+			<?php if ((++$column) % 3 == 0) : ?>
 				</div>
 				<div class="container-fluid">
 			<?php endif; ?>
-		<?php endforeach;?>
+		<?php endforeach; ?>
 		</div>
 	<?php endif; ?>
 

Please login to merge, or discard this patch.

extensions/libraries/redcore/layouts/component/admin.php 1 patch

Braces +10 added lines, -4 removed lines patch added patch discarded remove patch

@@ -211,21 +211,27 @@
 block discarded – undo
 		</div>
 	</div>
 <?php
-else : ?>
+else {
+	: ?>
 	<div class="redcore">
 		<div class="container-fluid">
 			<?php if ($displayTopbar) : ?>
 				<?php echo RLayoutHelper::render($topbarLayout, $topbarData) ?>
-			<?php endif; ?>
+			<?php endif;
+}
+?>
 			<div class="row-fluid">
 				<?php if ($displaySidebar) : ?>
 					<div class="span2 sidebar">
 						<?php echo RLayoutHelper::render($sidebarLayout, $sidebarData) ?>
 					</div>
 					<div class="span10 content">
-				<?php else : ?>
+				<?php else {
+	: ?>
 					<div class="span12 content">
-				<?php endif; ?>
+				<?php endif;
+}
+?>
 						<section id="component">
 							<div class="row-fluid">
 								<h1><?php echo $view->getTitle() ?></h1>

Please login to merge, or discard this patch.

extensions/libraries/redcore/layouts/component/site.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -91,8 +91,7 @@
 block discarded – undo
 if (method_exists($view, 'getToolbar'))
 {
 	$toolbar = $view->getToolbar();
-}
-else
+} else
 {
 	$toolbar = null;
 }

Please login to merge, or discard this patch.

extensions/libraries/redcore/layouts/component/admin.bs3.php 1 patch

Braces +8 added lines, -4 removed lines patch added patch discarded remove patch

@@ -219,7 +219,7 @@  discard block
 block discarded – undo
 		</div>
 	</div>
 <?php
-else
+else {
 
 :
 	?>
@@ -229,7 +229,9 @@  discard block
 block discarded – undo
 			:
 	?>
 				<?php echo RLayoutHelper::render($topbarLayout, $topbarData) ?>
-			<?php endif; ?>
+			<?php endif;
+}
+?>
 			<div class="row">
 				<?php if ($displaySidebar)
 				:
@@ -238,12 +240,14 @@  discard block
 block discarded – undo
 						<?php echo RLayoutHelper::render($sidebarLayout, $sidebarData) ?>
 					</div>
 					<div class="col-md-10 col-sm-9 content">
-				<?php else
+				<?php else {
 
 	:
 	?>
 					<div class="col-md-12 content">
-				<?php endif; ?>
+				<?php endif;
+}
+?>
 						<section id="component">
 							<h1 class="sub-header"><?php echo $view->getTitle() ?></h1>
 							<?php if ($toolbar instanceof RToolbar)

Please login to merge, or discard this patch.

extensions/libraries/redcore/layouts/component/extensioninfo.php 1 patch

Braces +50 added lines, -20 removed lines patch added patch discarded remove patch

@@ -60,9 +60,12 @@  discard block
 block discarded – undo
 					<td>
 						<?php if ($requirement['status']) : ?>
 						<span class="badge badge-success">
-							<?php else : ?>
+							<?php else {
+	: ?>
 							<span class="badge badge-important">
-							<?php endif; ?>
+							<?php endif;
+}
+?>
 
 							<?php echo $requirement['current']; ?>
 							</span>
@@ -81,8 +84,11 @@  discard block
 block discarded – undo
 						<td>
 							<?php if ($extension['status']) : ?>
 								<span class="badge badge-success"><?php echo JText::_('JYES'); ?></span>
-							<?php else : ?>
-								<span class="badge badge-important"><?php echo JText::_('JNO'); ?></span>
+							<?php else {
+	: ?>
+								<span class="badge badge-important"><?php echo JText::_('JNO');
+}
+?></span>
 							<?php endif; ?>
 						</td>
 					</tr>
@@ -103,14 +109,20 @@  discard block
 block discarded – undo
 					<td>
 						<?php if (@!is_dir(JPATH_SITE . '/media/' . $xml->media['destination'])) : ?>
 							<span class="badge badge-important"><?php echo JText::_('JGLOBAL_CREATED') . ' (' . JText::_('JNO') . ')'; ?></span>
-						<?php else : ?>
-							<span class="badge badge-success"><?php echo JText::_('JGLOBAL_CREATED') . ' (' . JText::_('JYES') . ')'; ?></span>
+						<?php else {
+	: ?>
+							<span class="badge badge-success"><?php echo JText::_('JGLOBAL_CREATED') . ' (' . JText::_('JYES') . ')';
+}
+?></span>
 						<?php endif; ?>
 						/
 						<?php if (@!is_writeable(JPATH_SITE . '/media/' . $xml->media['destination'])) : ?>
 							<span class="badge badge-important"><?php echo JText::_('COM_REDCORE_CONFIG_WRITABLE') . ' (' . JText::_('JNO') . ')'; ?></span>
-						<?php else : ?>
-							<span class="badge badge-success"><?php echo JText::_('COM_REDCORE_CONFIG_WRITABLE') . ' (' . JText::_('JYES') . ')'; ?></span>
+						<?php else {
+	: ?>
+							<span class="badge badge-success"><?php echo JText::_('COM_REDCORE_CONFIG_WRITABLE') . ' (' . JText::_('JYES') . ')';
+}
+?></span>
 						<?php endif; ?>
 					</td>
 				</tr>
@@ -153,24 +165,33 @@  discard block
 block discarded – undo
 						<td>
 							<?php if ($fromExtension) : ?>
 							<span class="badge badge-success"><?php echo JText::_('JYES'); ?>
-								<?php else : ?>
-								<span class="badge badge-warning"><?php echo JText::_('JNO'); ?>
+								<?php else {
+	: ?>
+								<span class="badge badge-warning"><?php echo JText::_('JNO');
+}
+?>
 									<?php endif; ?>
 							</span>
 						</td>
 						<td>
 							<?php if ($module->enabled == 1) : ?>
 								<span class="badge badge-success"><?php echo JText::_('JENABLED'); ?></span>
-							<?php else : ?>
-								<span class="badge badge-important"><?php echo JText::_('JDISABLED'); ?></span>
+							<?php else {
+	: ?>
+								<span class="badge badge-important"><?php echo JText::_('JDISABLED');
+}
+?></span>
 							<?php endif; ?>
 						</td>
 					</tr>
 				<?php endforeach; ?>
-			<?php else: ?>
+			<?php else {
+	: ?>
 				<tr>
 					<td colspan="3">
-						<?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
+						<?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS');
+}
+?>
 					</td>
 				</tr>
 			<?php endif; ?>
@@ -208,24 +229,33 @@  discard block
 block discarded – undo
 						<td>
 							<?php if ($fromExtension) : ?>
 							<span class="badge badge-success"><?php echo JText::_('JYES'); ?>
-								<?php else : ?>
-								<span class="badge badge-warning"><?php echo JText::_('JNO'); ?>
+								<?php else {
+	: ?>
+								<span class="badge badge-warning"><?php echo JText::_('JNO');
+}
+?>
 									<?php endif; ?>
 							</span>
 						</td>
 						<td>
 							<?php if ($plugin->enabled == 1) : ?>
 								<span class="badge badge-success"><?php echo JText::_('JENABLED'); ?></span>
-							<?php else : ?>
-								<span class="badge badge-important"><?php echo JText::_('JDISABLED'); ?></span>
+							<?php else {
+	: ?>
+								<span class="badge badge-important"><?php echo JText::_('JDISABLED');
+}
+?></span>
 							<?php endif; ?>
 						</td>
 					</tr>
 				<?php endforeach; ?>
-			<?php else: ?>
+			<?php else {
+	: ?>
 				<tr>
 					<td colspan="3">
-						<?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
+						<?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS');
+}
+?>
 					</td>
 				</tr>
 			<?php endif; ?>

Please login to merge, or discard this patch.

extensions/libraries/redcore/layouts/component/site.bs3.php 1 patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

@@ -91,8 +91,7 @@
 block discarded – undo
 if (method_exists($view, 'getToolbar'))
 {
 	$toolbar = $view->getToolbar();
-}
-else
+} else
 {
 	$toolbar = null;
 }

Please login to merge, or discard this patch.

extensions/libraries/redcore/layouts/component/extensioninfo.bs3.php 1 patch

Braces +50 added lines, -20 removed lines patch added patch discarded remove patch

@@ -59,9 +59,12 @@  discard block
 block discarded – undo
 					<td>
 						<?php if ($requirement['status']) : ?>
 						<span class="label label-success">
-							<?php else : ?>
+							<?php else {
+	: ?>
 							<span class="label label-danger">
-							<?php endif; ?>
+							<?php endif;
+}
+?>
 
 							<?php echo $requirement['current']; ?>
 							</span>
@@ -80,8 +83,11 @@  discard block
 block discarded – undo
 						<td>
 							<?php if ($extension['status']) : ?>
 								<span class="label label-success"><?php echo JText::_('JYES'); ?></span>
-							<?php else : ?>
-								<span class="label label-danger"><?php echo JText::_('JNO'); ?></span>
+							<?php else {
+	: ?>
+								<span class="label label-danger"><?php echo JText::_('JNO');
+}
+?></span>
 							<?php endif; ?>
 						</td>
 					</tr>
@@ -102,14 +108,20 @@  discard block
 block discarded – undo
 					<td>
 						<?php if (@!is_dir(JPATH_SITE . '/' . $xml->media['folder'])) : ?>
 							<span class="label label-danger"><?php echo JText::_('JGLOBAL_CREATED') . ' (' . JText::_('JNO') . ')'; ?></span>
-						<?php else : ?>
-							<span class="label label-success"><?php echo JText::_('JGLOBAL_CREATED') . ' (' . JText::_('JYES') . ')'; ?></span>
+						<?php else {
+	: ?>
+							<span class="label label-success"><?php echo JText::_('JGLOBAL_CREATED') . ' (' . JText::_('JYES') . ')';
+}
+?></span>
 						<?php endif; ?>
 						/
 						<?php if (@!is_writeable(JPATH_SITE . '/' . $xml->media['folder'])) : ?>
 							<span class="label label-danger"><?php echo JText::_('COM_REDCORE_CONFIG_WRITABLE') . ' (' . JText::_('JNO') . ')'; ?></span>
-						<?php else : ?>
-							<span class="label label-success"><?php echo JText::_('COM_REDCORE_CONFIG_WRITABLE') . ' (' . JText::_('JYES') . ')'; ?></span>
+						<?php else {
+	: ?>
+							<span class="label label-success"><?php echo JText::_('COM_REDCORE_CONFIG_WRITABLE') . ' (' . JText::_('JYES') . ')';
+}
+?></span>
 						<?php endif; ?>
 					</td>
 				</tr>
@@ -154,23 +166,32 @@  discard block
 block discarded – undo
 								<td>
 									<?php if ($fromExtension) : ?>
 										<span class="label label-success"><i class="icon icon-check"></i>&nbsp;<?php echo JText::_('JYES'); ?></span>
-									<?php else : ?>
-										<span class="label label-warning"><i class="icon icon-remove"></i>&nbsp;<?php echo JText::_('JNO'); ?></span>
+									<?php else {
+	: ?>
+										<span class="label label-warning"><i class="icon icon-remove"></i>&nbsp;<?php echo JText::_('JNO');
+}
+?></span>
 									<?php endif; ?>
 								</td>
 								<td>
 									<?php if ($module->enabled == 1) : ?>
 										<span class="label label-success"><i class="icon icon-check"></i>&nbsp;<?php echo JText::_('JENABLED'); ?></span>
-									<?php else : ?>
-										<span class="label label-danger"><i class="icon icon-remove"></i>&nbsp;<?php echo JText::_('JDISABLED'); ?></span>
+									<?php else {
+	: ?>
+										<span class="label label-danger"><i class="icon icon-remove"></i>&nbsp;<?php echo JText::_('JDISABLED');
+}
+?></span>
 									<?php endif; ?>
 								</td>
 							</tr>
 						<?php endforeach; ?>
-					<?php else: ?>
+					<?php else {
+	: ?>
 						<tr>
 							<td colspan="3">
-								<?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
+								<?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS');
+}
+?>
 							</td>
 						</tr>
 					<?php endif; ?>
@@ -212,23 +233,32 @@  discard block
 block discarded – undo
 									<td>
 										<?php if ($fromExtension) : ?>
 											<span class="label label-success"><i class="icon icon-check"></i>&nbsp;<?php echo JText::_('JYES'); ?></span>
-										<?php else : ?>
+										<?php else {
+	: ?>
 											<span class="label label-warning"><i class="icon icon-remove"></i>&nbsp;<?php echo JText::_('JNO') ?></span>
-										<?php endif; ?>
+										<?php endif;
+}
+?>
 									</td>
 									<td>
 										<?php if ($plugin->enabled == 1) : ?>
 											<span class="label label-success"><i class="icon icon-check"></i>&nbsp;<?php echo JText::_('JENABLED'); ?></span>
-										<?php else : ?>
-											<span class="label label-danger"><i class="icon icon-remove"></i>&nbsp;<?php echo JText::_('JDISABLED'); ?></span>
+										<?php else {
+	: ?>
+											<span class="label label-danger"><i class="icon icon-remove"></i>&nbsp;<?php echo JText::_('JDISABLED');
+}
+?></span>
 										<?php endif; ?>
 									</td>
 								</tr>
 							<?php endforeach; ?>
-						<?php else: ?>
+						<?php else {
+	: ?>
 							<tr>
 								<td colspan="3">
-									<?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
+									<?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS');
+}
+?>
 								</td>
 							</tr>
 						<?php endif; ?>

Please login to merge, or discard this patch.

extensions/libraries/redcore/layouts/toolbar/toolbar.php 2 patches

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -53,12 +53,12 @@  discard block
 block discarded – undo
 			}
 		?>
 		<?php if ($group->isMenu()):?>
-			<div class="<?php echo $groupClass;?>">
+			<div class="<?php echo $groupClass; ?>">
 				<a class="btn dropdown-toggle btn-primary" data-toggle="dropdown" href="#">
 					<?php if (!empty($iconClass)):?>
-						<i class="<?php echo $iconClass;?>"></i>
-					<?php endif;?>
-					<?php echo $group->getTitle();?>
+						<i class="<?php echo $iconClass; ?>"></i>
+					<?php endif; ?>
+					<?php echo $group->getTitle(); ?>
 				</a>
 				<ul class="dropdown-menu">
 					<?php
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
 				}
 				?>
 			</div>
-		<?php endif;?>
+		<?php endif; ?>
 		<?php endforeach; ?>
 	</div>
 <?php endif;

Please login to merge, or discard this patch.

Braces +5 added lines, -7 removed lines patch added patch discarded remove patch

@@ -25,9 +25,7 @@  discard block
 block discarded – undo
 if (empty($toolBarClass))
 {
 	$toolBarClass = 'btn-toolbar';
-}
-
-else
+} else
 {
 	$toolBarClass = 'btn-toolbar ' . $toolBarClass;
 }
@@ -45,9 +43,7 @@  discard block
 block discarded – undo
 			if (empty($groupClass))
 			{
 				$groupClass = 'btn-group';
-			}
-
-			else
+			} else
 			{
 				$groupClass = 'btn-group ' . $groupClass;
 			}
@@ -69,12 +65,14 @@  discard block
 block discarded – undo
 					?>
 				</ul>
 			</div>
-		<?php else: ?>
+		<?php else {
+	: ?>
 			<div class="<?php echo $groupClass ?>">
 				<?php
 				foreach ($group->getButtons() as $button)
 				{
 					echo $button->render();
+}
 				}
 				?>
 			</div>

Please login to merge, or discard this patch.

extensions/libraries/redcore/layouts/toolbar/button/standard.php 2 patches

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

		@@ -65,4 +65,4 @@
		block discarded – undo
65	65	<?php endif; ?>
66	66	<?php echo $text ?>
67	67	</button>
68		-<?php endif;?>
	68	+<?php endif; ?>

Please login to merge, or discard this patch.

Braces +6 added lines, -4 removed lines patch added patch discarded remove patch

@@ -34,8 +34,7 @@  discard block
 block discarded – undo
 if ($isList)
 {
 	$cmd = "if (document.adminForm.boxchecked.value==0){alert('$message');}else{ Joomla.submitbutton('$task')}";
-}
-else
+} else
 {
 	$cmd = "Joomla.submitbutton('$task')";
 }
@@ -58,11 +57,14 @@  discard block
 block discarded – undo
 			<?php echo $text ?>
 		</a>
 	</li>
-<?php else:?>
+<?php else {
+	:?>
 	<button onclick="<?php echo $cmd ?>" class="<?php echo $btnClass ?>">
 		<?php if (!empty($iconClass)) : ?>
 			<i class="<?php echo $iconClass ?>"></i>
-		<?php endif; ?>
+		<?php endif;
+}
+?>
 		<?php echo $text ?>
 	</button>
 <?php endif;?>

Please login to merge, or discard this patch.

		@@ -91,8 +91,7 @@
		block discarded – undo
91	91	if (method_exists($view, 'getToolbar'))
92	92	{
93	93	$toolbar = $view->getToolbar();
94		-}
95		-else
	94	+} else
96	95	{
97	96	$toolbar = null;
98	97	}

		@@ -219,7 +219,7 @@ discard block
		block discarded – undo
219	219	</div>
220	220	</div>
221	221	<?php
222		-else
	222	+else {
223	223
224	224	:
225	225	?>
		@@ -229,7 +229,9 @@ discard block
		block discarded – undo
229	229	:
230	230	?>
231	231	<?php echo RLayoutHelper::render($topbarLayout, $topbarData) ?>
232		- <?php endif; ?>
	232	+ <?php endif;
	233	+}
	234	+?>
233	235	<div class="row">
234	236	<?php if ($displaySidebar)
235	237	:
		@@ -238,12 +240,14 @@ discard block
		block discarded – undo
238	240	<?php echo RLayoutHelper::render($sidebarLayout, $sidebarData) ?>
239	241	</div>
240	242	<div class="col-md-10 col-sm-9 content">
241		- <?php else
	243	+ <?php else {
242	244
243	245	:
244	246	?>
245	247	<div class="col-md-12 content">
246		- <?php endif; ?>
	248	+ <?php endif;
	249	+}
	250	+?>
247	251	<section id="component">
248	252	<h1 class="sub-header"><?php echo $view->getTitle() ?></h1>
249	253	<?php if ($toolbar instanceof RToolbar)

		@@ -91,8 +91,7 @@
		block discarded – undo
91	91	if (method_exists($view, 'getToolbar'))
92	92	{
93	93	$toolbar = $view->getToolbar();
94		-}
95		-else
	94	+} else
96	95	{
97	96	$toolbar = null;
98	97	}

		@@ -43,15 +43,15 @@
		block discarded – undo
43	43	<ul>
44	44	<?php foreach ($scopeList as $scope) :?>
45	45	<li><?php echo $scope['scopeDisplayName']; ?></li>
46		- <?php endforeach;?>
	46	+ <?php endforeach; ?>
47	47	</ul>
48	48	</div>
49	49	</div>
50		- <?php if ((++$column) % 3 == 0 ) : ?>
	50	+ <?php if ((++$column) % 3 == 0) : ?>
51	51	</div>
52	52	<div class="container-fluid">
53	53	<?php endif; ?>
54		- <?php endforeach;?>
	54	+ <?php endforeach; ?>
55	55	</div>
56	56	<?php endif; ?>
57	57

		@@ -211,21 +211,27 @@
		block discarded – undo
211	211	</div>
212	212	</div>
213	213	<?php
214		-else : ?>
	214	+else {
	215	+ : ?>
215	216	<div class="redcore">
216	217	<div class="container-fluid">
217	218	<?php if ($displayTopbar) : ?>
218	219	<?php echo RLayoutHelper::render($topbarLayout, $topbarData) ?>
219		- <?php endif; ?>
	220	+ <?php endif;
	221	+}
	222	+?>
220	223	<div class="row-fluid">
221	224	<?php if ($displaySidebar) : ?>
222	225	<div class="span2 sidebar">
223	226	<?php echo RLayoutHelper::render($sidebarLayout, $sidebarData) ?>
224	227	</div>
225	228	<div class="span10 content">
226		- <?php else : ?>
	229	+ <?php else {
	230	+ : ?>
227	231	<div class="span12 content">
228		- <?php endif; ?>
	232	+ <?php endif;
	233	+}
	234	+?>
229	235	<section id="component">
230	236	<div class="row-fluid">
231	237	<h1><?php echo $view->getTitle() ?></h1>

		@@ -60,9 +60,12 @@ discard block
		block discarded – undo
60	60	<td>
61	61	<?php if ($requirement['status']) : ?>
62	62	<span class="badge badge-success">
63		- <?php else : ?>
	63	+ <?php else {
	64	+ : ?>
64	65	<span class="badge badge-important">
65		- <?php endif; ?>
	66	+ <?php endif;
	67	+}
	68	+?>
66	69
67	70	<?php echo $requirement['current']; ?>
68	71	</span>
		@@ -81,8 +84,11 @@ discard block
		block discarded – undo
81	84	<td>
82	85	<?php if ($extension['status']) : ?>
83	86	<span class="badge badge-success"><?php echo JText::_('JYES'); ?></span>
84		- <?php else : ?>
85		- <span class="badge badge-important"><?php echo JText::_('JNO'); ?></span>
	87	+ <?php else {
	88	+ : ?>
	89	+ <span class="badge badge-important"><?php echo JText::_('JNO');
	90	+}
	91	+?></span>
86	92	<?php endif; ?>
87	93	</td>
88	94	</tr>
		@@ -103,14 +109,20 @@ discard block
		block discarded – undo
103	109	<td>
104	110	<?php if (@!is_dir(JPATH_SITE . '/media/' . $xml->media['destination'])) : ?>
105	111	<span class="badge badge-important"><?php echo JText::_('JGLOBAL_CREATED') . ' (' . JText::_('JNO') . ')'; ?></span>
106		- <?php else : ?>
107		- <span class="badge badge-success"><?php echo JText::_('JGLOBAL_CREATED') . ' (' . JText::_('JYES') . ')'; ?></span>
	112	+ <?php else {
	113	+ : ?>
	114	+ <span class="badge badge-success"><?php echo JText::_('JGLOBAL_CREATED') . ' (' . JText::_('JYES') . ')';
	115	+}
	116	+?></span>
108	117	<?php endif; ?>
109	118	/
110	119	<?php if (@!is_writeable(JPATH_SITE . '/media/' . $xml->media['destination'])) : ?>
111	120	<span class="badge badge-important"><?php echo JText::_('COM_REDCORE_CONFIG_WRITABLE') . ' (' . JText::_('JNO') . ')'; ?></span>
112		- <?php else : ?>
113		- <span class="badge badge-success"><?php echo JText::_('COM_REDCORE_CONFIG_WRITABLE') . ' (' . JText::_('JYES') . ')'; ?></span>
	121	+ <?php else {
	122	+ : ?>
	123	+ <span class="badge badge-success"><?php echo JText::_('COM_REDCORE_CONFIG_WRITABLE') . ' (' . JText::_('JYES') . ')';
	124	+}
	125	+?></span>
114	126	<?php endif; ?>
115	127	</td>
116	128	</tr>
		@@ -153,24 +165,33 @@ discard block
		block discarded – undo
153	165	<td>
154	166	<?php if ($fromExtension) : ?>
155	167	<span class="badge badge-success"><?php echo JText::_('JYES'); ?>
156		- <?php else : ?>
157		- <span class="badge badge-warning"><?php echo JText::_('JNO'); ?>
	168	+ <?php else {
	169	+ : ?>
	170	+ <span class="badge badge-warning"><?php echo JText::_('JNO');
	171	+}
	172	+?>
158	173	<?php endif; ?>
159	174	</span>
160	175	</td>
161	176	<td>
162	177	<?php if ($module->enabled == 1) : ?>
163	178	<span class="badge badge-success"><?php echo JText::_('JENABLED'); ?></span>
164		- <?php else : ?>
165		- <span class="badge badge-important"><?php echo JText::_('JDISABLED'); ?></span>
	179	+ <?php else {
	180	+ : ?>
	181	+ <span class="badge badge-important"><?php echo JText::_('JDISABLED');
	182	+}
	183	+?></span>
166	184	<?php endif; ?>
167	185	</td>
168	186	</tr>
169	187	<?php endforeach; ?>
170		- <?php else: ?>
	188	+ <?php else {
	189	+ : ?>
171	190	<tr>
172	191	<td colspan="3">
173		- <?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
	192	+ <?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS');
	193	+}
	194	+?>
174	195	</td>
175	196	</tr>
176	197	<?php endif; ?>
		@@ -208,24 +229,33 @@ discard block
		block discarded – undo
208	229	<td>
209	230	<?php if ($fromExtension) : ?>
210	231	<span class="badge badge-success"><?php echo JText::_('JYES'); ?>
211		- <?php else : ?>
212		- <span class="badge badge-warning"><?php echo JText::_('JNO'); ?>
	232	+ <?php else {
	233	+ : ?>
	234	+ <span class="badge badge-warning"><?php echo JText::_('JNO');
	235	+}
	236	+?>
213	237	<?php endif; ?>
214	238	</span>
215	239	</td>
216	240	<td>
217	241	<?php if ($plugin->enabled == 1) : ?>
218	242	<span class="badge badge-success"><?php echo JText::_('JENABLED'); ?></span>
219		- <?php else : ?>
220		- <span class="badge badge-important"><?php echo JText::_('JDISABLED'); ?></span>
	243	+ <?php else {
	244	+ : ?>
	245	+ <span class="badge badge-important"><?php echo JText::_('JDISABLED');
	246	+}
	247	+?></span>
221	248	<?php endif; ?>
222	249	</td>
223	250	</tr>
224	251	<?php endforeach; ?>
225		- <?php else: ?>
	252	+ <?php else {
	253	+ : ?>
226	254	<tr>
227	255	<td colspan="3">
228		- <?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
	256	+ <?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS');
	257	+}
	258	+?>
229	259	</td>
230	260	</tr>
231	261	<?php endif; ?>

		@@ -59,9 +59,12 @@ discard block
		block discarded – undo
59	59	<td>
60	60	<?php if ($requirement['status']) : ?>
61	61	<span class="label label-success">
62		- <?php else : ?>
	62	+ <?php else {
	63	+ : ?>
63	64	<span class="label label-danger">
64		- <?php endif; ?>
	65	+ <?php endif;
	66	+}
	67	+?>
65	68
66	69	<?php echo $requirement['current']; ?>
67	70	</span>
		@@ -80,8 +83,11 @@ discard block
		block discarded – undo
80	83	<td>
81	84	<?php if ($extension['status']) : ?>
82	85	<span class="label label-success"><?php echo JText::_('JYES'); ?></span>
83		- <?php else : ?>
84		- <span class="label label-danger"><?php echo JText::_('JNO'); ?></span>
	86	+ <?php else {
	87	+ : ?>
	88	+ <span class="label label-danger"><?php echo JText::_('JNO');
	89	+}
	90	+?></span>
85	91	<?php endif; ?>
86	92	</td>
87	93	</tr>
		@@ -102,14 +108,20 @@ discard block
		block discarded – undo
102	108	<td>
103	109	<?php if (@!is_dir(JPATH_SITE . '/' . $xml->media['folder'])) : ?>
104	110	<span class="label label-danger"><?php echo JText::_('JGLOBAL_CREATED') . ' (' . JText::_('JNO') . ')'; ?></span>
105		- <?php else : ?>
106		- <span class="label label-success"><?php echo JText::_('JGLOBAL_CREATED') . ' (' . JText::_('JYES') . ')'; ?></span>
	111	+ <?php else {
	112	+ : ?>
	113	+ <span class="label label-success"><?php echo JText::_('JGLOBAL_CREATED') . ' (' . JText::_('JYES') . ')';
	114	+}
	115	+?></span>
107	116	<?php endif; ?>
108	117	/
109	118	<?php if (@!is_writeable(JPATH_SITE . '/' . $xml->media['folder'])) : ?>
110	119	<span class="label label-danger"><?php echo JText::_('COM_REDCORE_CONFIG_WRITABLE') . ' (' . JText::_('JNO') . ')'; ?></span>
111		- <?php else : ?>
112		- <span class="label label-success"><?php echo JText::_('COM_REDCORE_CONFIG_WRITABLE') . ' (' . JText::_('JYES') . ')'; ?></span>
	120	+ <?php else {
	121	+ : ?>
	122	+ <span class="label label-success"><?php echo JText::_('COM_REDCORE_CONFIG_WRITABLE') . ' (' . JText::_('JYES') . ')';
	123	+}
	124	+?></span>
113	125	<?php endif; ?>
114	126	</td>
115	127	</tr>
		@@ -154,23 +166,32 @@ discard block
		block discarded – undo
154	166	<td>
155	167	<?php if ($fromExtension) : ?>
156	168	<span class="label label-success"><i class="icon icon-check"></i> <?php echo JText::_('JYES'); ?></span>
157		- <?php else : ?>
158		- <span class="label label-warning"><i class="icon icon-remove"></i> <?php echo JText::_('JNO'); ?></span>
	169	+ <?php else {
	170	+ : ?>
	171	+ <span class="label label-warning"><i class="icon icon-remove"></i> <?php echo JText::_('JNO');
	172	+}
	173	+?></span>
159	174	<?php endif; ?>
160	175	</td>
161	176	<td>
162	177	<?php if ($module->enabled == 1) : ?>
163	178	<span class="label label-success"><i class="icon icon-check"></i> <?php echo JText::_('JENABLED'); ?></span>
164		- <?php else : ?>
165		- <span class="label label-danger"><i class="icon icon-remove"></i> <?php echo JText::_('JDISABLED'); ?></span>
	179	+ <?php else {
	180	+ : ?>
	181	+ <span class="label label-danger"><i class="icon icon-remove"></i> <?php echo JText::_('JDISABLED');
	182	+}
	183	+?></span>
166	184	<?php endif; ?>
167	185	</td>
168	186	</tr>
169	187	<?php endforeach; ?>
170		- <?php else: ?>
	188	+ <?php else {
	189	+ : ?>
171	190	<tr>
172	191	<td colspan="3">
173		- <?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
	192	+ <?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS');
	193	+}
	194	+?>
174	195	</td>
175	196	</tr>
176	197	<?php endif; ?>
		@@ -212,23 +233,32 @@ discard block
		block discarded – undo
212	233	<td>
213	234	<?php if ($fromExtension) : ?>
214	235	<span class="label label-success"><i class="icon icon-check"></i> <?php echo JText::_('JYES'); ?></span>
215		- <?php else : ?>
	236	+ <?php else {
	237	+ : ?>
216	238	<span class="label label-warning"><i class="icon icon-remove"></i> <?php echo JText::_('JNO') ?></span>
217		- <?php endif; ?>
	239	+ <?php endif;
	240	+}
	241	+?>
218	242	</td>
219	243	<td>
220	244	<?php if ($plugin->enabled == 1) : ?>
221	245	<span class="label label-success"><i class="icon icon-check"></i> <?php echo JText::_('JENABLED'); ?></span>
222		- <?php else : ?>
223		- <span class="label label-danger"><i class="icon icon-remove"></i> <?php echo JText::_('JDISABLED'); ?></span>
	246	+ <?php else {
	247	+ : ?>
	248	+ <span class="label label-danger"><i class="icon icon-remove"></i> <?php echo JText::_('JDISABLED');
	249	+}
	250	+?></span>
224	251	<?php endif; ?>
225	252	</td>
226	253	</tr>
227	254	<?php endforeach; ?>
228		- <?php else: ?>
	255	+ <?php else {
	256	+ : ?>
229	257	<tr>
230	258	<td colspan="3">
231		- <?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS'); ?>
	259	+ <?php echo JText::_('JGLOBAL_NO_MATCHING_RESULTS');
	260	+}
	261	+?>
232	262	</td>
233	263	</tr>
234	264	<?php endif; ?>

		@@ -53,12 +53,12 @@ discard block
		block discarded – undo
53	53	}
54	54	?>
55	55	<?php if ($group->isMenu()):?>
56		- <div class="<?php echo $groupClass;?>">
	56	+ <div class="<?php echo $groupClass; ?>">
57	57	<a class="btn dropdown-toggle btn-primary" data-toggle="dropdown" href="#">
58	58	<?php if (!empty($iconClass)):?>
59		- <i class="<?php echo $iconClass;?>"></i>
60		- <?php endif;?>
61		- <?php echo $group->getTitle();?>
	59	+ <i class="<?php echo $iconClass; ?>"></i>
	60	+ <?php endif; ?>
	61	+ <?php echo $group->getTitle(); ?>
62	62	</a>
63	63	<ul class="dropdown-menu">
64	64	<?php
		@@ -78,7 +78,7 @@ discard block
		block discarded – undo
78	78	}
79	79	?>
80	80	</div>
81		- <?php endif;?>
	81	+ <?php endif; ?>
82	82	<?php endforeach; ?>
83	83	</div>
84	84	<?php endif;

		@@ -25,9 +25,7 @@ discard block
		block discarded – undo
25	25	if (empty($toolBarClass))
26	26	{
27	27	$toolBarClass = 'btn-toolbar';
28		-}
29		-
30		-else
	28	+} else
31	29	{
32	30	$toolBarClass = 'btn-toolbar ' . $toolBarClass;
33	31	}
		@@ -45,9 +43,7 @@ discard block
		block discarded – undo
45	43	if (empty($groupClass))
46	44	{
47	45	$groupClass = 'btn-group';
48		- }
49		-
50		- else
	46	+ } else
51	47	{
52	48	$groupClass = 'btn-group ' . $groupClass;
53	49	}
		@@ -69,12 +65,14 @@ discard block
		block discarded – undo
69	65	?>
70	66	</ul>
71	67	</div>
72		- <?php else: ?>
	68	+ <?php else {
	69	+ : ?>
73	70	<div class="<?php echo $groupClass ?>">
74	71	<?php
75	72	foreach ($group->getButtons() as $button)
76	73	{
77	74	echo $button->render();
	75	+}
78	76	}
79	77	?>
80	78	</div>

		@@ -34,8 +34,7 @@ discard block
		block discarded – undo
34	34	if ($isList)
35	35	{
36	36	$cmd = "if (document.adminForm.boxchecked.value==0){alert('$message');}else{ Joomla.submitbutton('$task')}";
37		-}
38		-else
	37	+} else
39	38	{
40	39	$cmd = "Joomla.submitbutton('$task')";
41	40	}
		@@ -58,11 +57,14 @@ discard block
		block discarded – undo
58	57	<?php echo $text ?>
59	58	</a>
60	59	</li>
61		-<?php else:?>
	60	+<?php else {
	61	+ :?>
62	62	<button onclick="<?php echo $cmd ?>" class="<?php echo $btnClass ?>">
63	63	<?php if (!empty($iconClass)) : ?>
64	64	<i class="<?php echo $iconClass ?>"></i>
65		- <?php endif; ?>
	65	+ <?php endif;
	66	+}
	67	+?>
66	68	<?php echo $text ?>
67	69	</button>
68	70	<?php endif;?>

redCOMPONENT-COM / redCORE

Branch — develop (d6f62e)

Category

Spacing +3 added lines, -3 removed lines patch added patch discarded remove patch

Braces +10 added lines, -4 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +8 added lines, -4 removed lines patch added patch discarded remove patch

Braces +50 added lines, -20 removed lines patch added patch discarded remove patch

Braces +1 added lines, -2 removed lines patch added patch discarded remove patch

Braces +50 added lines, -20 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Braces +5 added lines, -7 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Braces +6 added lines, -4 removed lines patch added patch discarded remove patch