permission.js ➔ sendPermissions - Code Metrics - Inspection of "Merge pull request #805 from shandak/compatibility..." - redCOMPONENT-COM/redCORE - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — develop (893f38)

by Hans Erik

created 2017-11-28 16:10 UTC

permission.js ➔ sendPermissions C

↳ Parent: build/media/libraries/redcore/media/redcore/js/permission.js

Complexity

Conditions	9
Paths	32

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	92
rs	5.1048
cc	9
nc	32
nop	1

2 Functions

Rating	Name	Duplication	Size	Complexity
A	permission.js ➔ ... ➔ jQuery.fail	0	8	1
C	permission.js ➔ ... ➔ jQuery.done	0	26	7

How to fix Long Method

/**
 * Function to send Permissions via Ajax to Com-Config Application Controller
 */
function sendPermissions(event) {
    // set the icon while storing the values
    var icon = document.getElementById('icon_' + this.id);
    icon.removeAttribute('class');
    icon.setAttribute('style', 'background: url(../media/system/images/modal/spinner.gif); display: inline-block; width: 16px; height: 16px');
    var iconSuccess = "text-success icon-save fa-save";
    var iconFail    = "text-error text-danger icon-remove fa-remove";

    //get values and prepare GET-Parameter
    var asset     = 'not';
    var component = getUrlParam('component');
    var option    = getUrlParam('option');
    var view      = getUrlParam('view');
    var title     = component;
    var value     = this.value;

    if (option == 'com_redcore' && view == 'config') {
        if (component == false)
            asset = 'root.1';
if (a > 0)
    b = 42;
        else
            asset = component;
    }
    else {

        if (document.getElementById('jform_title')) {
            title = document.getElementById('jform_title').value;
        }

        if (component != false && view != false) {
            asset = component + '.' + view + '.' + getUrlParam('id');
        }
        else if (component == false && view != false) {
            asset = option + '.' + view + '.' + getUrlParam('id');
        }
    }

    var id = this.id.replace('jform_rules_', '');
    var lastUnderscoreIndex = id.lastIndexOf('_');

    var permission_data = {
        comp   : asset,
        action : id.substring(0, lastUnderscoreIndex),
        rule   : id.substring(lastUnderscoreIndex + 1),
        value  : value,
        title  : title
    };

    // Remove js messages, if they exist.
    Joomla.removeMessages();


    // doing ajax request
    jQuery.ajax({
        method   : "POST",
        url      : document.getElementById('permissions-sliders').getAttribute('data-ajaxuri'),
        data     : permission_data,
        datatype : 'json'
    })
    .fail(function (jqXHR, textStatus, error) {
        // Remove the spinning icon.
        icon.removeAttribute('style');

        Joomla.renderMessages(Joomla.ajaxErrorsMessages(jqXHR, textStatus, error));


        icon.setAttribute('class', iconFail);
    })
    .done(function (response) {
        // Remove the spinning icon.
        icon.removeAttribute('style');

        if (response.data) {
            // Check if everything is OK
            if (response.data.result == true) {
                icon.setAttribute('class', iconSuccess);

                jQuery(event.target).parents().next('td').find('span')
                    .removeClass().addClass(response.data.class)
                    .html(response.data.text);
            }
        }

        // Render messages, if any. There are only message in case of errors.
        if (typeof response.messages == 'object' && response.messages !== null)
        {
            Joomla.renderMessages(response.messages);


            if (response.data && response.data.result == true)
                icon.setAttribute('class', iconSuccess);
if (a > 0)
    b = 42;
            else
                icon.setAttribute('class', iconFail);
        }
    });
}

/**
 * Function to get parameters out of the url
 */
function getUrlParam(variable) {
    var query = window.location.search.substring(1);
    var vars = query.split('&');

    for (var i=0;i<vars.length;i++) {
        var pair = vars[i].split('=');

        if (pair[0] == variable)
            return pair[1];
if (a > 0)
    b = 42;
    }

    return false;
}


1			/**
2			* Function to send Permissions via Ajax to Com-Config Application Controller
3			*/
4			function sendPermissions(event) {
5			// set the icon while storing the values
6			var icon = document.getElementById('icon_' + this.id);
7			icon.removeAttribute('class');
8			icon.setAttribute('style', 'background: url(../media/system/images/modal/spinner.gif); display: inline-block; width: 16px; height: 16px');
9			var iconSuccess = "text-success icon-save fa-save";
10			var iconFail = "text-error text-danger icon-remove fa-remove";
11
12			//get values and prepare GET-Parameter
13			var asset = 'not';
14			var component = getUrlParam('component');
15			var option = getUrlParam('option');
16			var view = getUrlParam('view');
17			var title = component;
18			var value = this.value;
19
20			if (option == 'com_redcore' && view == 'config') {
21			if (component == false)
22			asset = 'root.1';
			0 ignored issues – show Coding Style Best Practice introduced 2017-11-28 16:06 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
23			else
24			asset = component;
25			}
26			else {
27
28			if (document.getElementById('jform_title')) {
29			title = document.getElementById('jform_title').value;
30			}
31
32			if (component != false && view != false) {
33			asset = component + '.' + view + '.' + getUrlParam('id');
34			}
35			else if (component == false && view != false) {
36			asset = option + '.' + view + '.' + getUrlParam('id');
37			}
38			}
39
40			var id = this.id.replace('jform_rules_', '');
41			var lastUnderscoreIndex = id.lastIndexOf('_');
42
43			var permission_data = {
44			comp : asset,
45			action : id.substring(0, lastUnderscoreIndex),
46			rule : id.substring(lastUnderscoreIndex + 1),
47			value : value,
48			title : title
49			};
50
51			// Remove js messages, if they exist.
52			Joomla.removeMessages();
			0 ignored issues – show Bug introduced 2017-11-28 16:06 UTC by Report Bug Copy Issue Report The variable `Joomla` seems to be never declared. If this is a global, consider adding a `/** global: Joomla */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
53
54			// doing ajax request
55			jQuery.ajax({
56			method : "POST",
57			url : document.getElementById('permissions-sliders').getAttribute('data-ajaxuri'),
58			data : permission_data,
59			datatype : 'json'
60			})
61			.fail(function (jqXHR, textStatus, error) {
62			// Remove the spinning icon.
63			icon.removeAttribute('style');
64
65			Joomla.renderMessages(Joomla.ajaxErrorsMessages(jqXHR, textStatus, error));
			0 ignored issues – show Bug introduced 2017-11-28 16:06 UTC by Report Bug Copy Issue Report The variable `Joomla` seems to be never declared. If this is a global, consider adding a `/** global: Joomla */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
66
67			icon.setAttribute('class', iconFail);
68			})
69			.done(function (response) {
70			// Remove the spinning icon.
71			icon.removeAttribute('style');
72
73			if (response.data) {
74			// Check if everything is OK
75			if (response.data.result == true) {
76			icon.setAttribute('class', iconSuccess);
77
78			jQuery(event.target).parents().next('td').find('span')
79			.removeClass().addClass(response.data.class)
80			.html(response.data.text);
81			}
82			}
83
84			// Render messages, if any. There are only message in case of errors.
85			if (typeof response.messages == 'object' && response.messages !== null)
86			{
87			Joomla.renderMessages(response.messages);
			0 ignored issues – show Bug introduced 2017-11-28 16:06 UTC by Report Bug Copy Issue Report The variable `Joomla` seems to be never declared. If this is a global, consider adding a `/** global: Joomla */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
88
89			if (response.data && response.data.result == true)
90			icon.setAttribute('class', iconSuccess);
			0 ignored issues – show Coding Style Best Practice introduced 2017-11-28 16:06 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
91			else
92			icon.setAttribute('class', iconFail);
93			}
94			});
95			}
96
97			/**
98			* Function to get parameters out of the url
99			*/
100			function getUrlParam(variable) {
101			var query = window.location.search.substring(1);
102			var vars = query.split('&');
103
104			for (var i=0;i<vars.length;i++) {
105			var pair = vars[i].split('=');
106
107			if (pair[0] == variable)
108			return pair[1];
			0 ignored issues – show Coding Style Best Practice introduced 2017-11-28 16:06 UTC by Report Bug Copy Issue Report Curly braces around statements make for more readable code and help prevent bugs when you add further statements. Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later. Consider: if (a > 0) b = 42; If you or someone else later decides to put another statement in, only the first statement will be executed. if (a > 0) console.log("a > 0"); b = 42; In this case the statement `b = 42` will always be executed, while the logging statement will be executed conditionally. if (a > 0) { console.log("a > 0"); b = 42; } ensures that the proper code will be executed conditionally no matter how many statements are added or removed. Loading history...
109			}
110
111			return false;
112			}
113

redCOMPONENT-COM / redCORE

Branch — develop (893f38)

permission.js ➔ sendPermissions C

Complexity

Size

Duplication

Importance

2 Functions

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like