Api::storagePath() - Code Metrics - Inspection of "ChunkFile" - recca0120/upload - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 40400a...73c84a )

by recca

created 2017-04-10 20:39 UTC

Api::storagePath() A

↳ Parent: Api

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	3
cts	3
cp	1
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	0
crap	1

<?php

namespace Recca0120\Upload;

use Illuminate\Http\Request;
use Illuminate\Http\JsonResponse;
use Recca0120\Upload\Contracts\Api as ApiContract;
use Symfony\Component\HttpFoundation\File\UploadedFile;

abstract class Api implements ApiContract
{
    /**
     * $request.
     *
     * @var \Illuminate\Http\Request
     */
    public $request;

    /**
     * $filesystem.
     *
     * @var \Recca0120\Upload\Filesystem
     */
    public $filesystem;

    /**
     * $config.
     *
     * @var array
     */
    protected $config;

    /**
     * __construct.
     *
     * @param array $config
     * @param \Illuminate\Http\Request $request
     * @param \Recca0120\Upload\Filesystem $filesystem
     */
    public function __construct($config = [], Request $request = null, Filesystem $filesystem = null, ChunkFile $chunkFile = null)
    {
        $this->request = $request ?: Request::capture();
        $this->filesystem = $filesystem ?: new Filesystem();
        $this->chunkFile = $chunkFile ?: new ChunkFile($this->filesystem);
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $this->config = array_merge([
            'chunks' => sys_get_temp_dir().'/chunks',
            'storage' => 'storage/temp',
            'domain' => $this->request->root(),
            'path' => 'storage/temp',
        ], $config);
    }

    /**
     * domain.
     *
     * @return string
     */
    public function domain()
    {
        return rtrim($this->config['domain'], '/').'/';
    }

    /**
     * path.
     *
     * @return string
     */
    public function path()
    {
        return rtrim($this->config['path'], '/').'/';
    }

    /**
     * makeDirectory.
     *
     * @return $this
     */
    public function makeDirectory($path)
    {
        if ($this->filesystem->isDirectory($path) === false) {
            $this->filesystem->makeDirectory($path, 0777, true, true);
        }

        return $this;
    }

    /**
     * cleanDirectory.
     */
    public function cleanDirectory($path)
    {
        $time = time();
        $maxFileAge = 3600;
        $files = (array) $this->filesystem->files($path);
        foreach ($files as $file) {
            if ($this->filesystem->isFile($file) === true &&
                $this->filesystem->lastModified($file) < ($time - $maxFileAge)
            ) {
                $this->filesystem->delete($file);
            }
        }
    }

    /**
     * receive.
     *
     * @param string $inputName
     * @return \Symfony\Component\HttpFoundation\File\UploadedFile
     *
     * @throws \Recca0120\Upload\Exceptions\ChunkedResponseException
     */
    abstract public function receive($inputName);

    /**
     * deleteUploadedFile.
     *
     * @param \Symfony\Component\HttpFoundation\File\UploadedFile
     * @return $this
     */
    public function deleteUploadedFile(UploadedFile $uploadedFile)
    {
        $file = $uploadedFile->getPathname();
        if ($this->filesystem->isFile($file) === true) {
            $this->filesystem->delete($file);
        }
        $this->cleanDirectory($this->config['chunks']);

        return $this;
    }

    /**
     * completedResponse.
     *
     * @param \Illuminate\Http\JsonResponse $response
     * @return \Illuminate\Http\JsonResponse
     */
    public function completedResponse(JsonResponse $response)
    {
        return $response;
    }

    /**
     * chunkPath.
     *
     * @return string
     */
    protected function chunkPath()
    {
        $this->makeDirectory($this->config['chunks']);

        return rtrim($this->config['chunks'], '/').'/';
    }

    /**
     * storagePath.
     *
     * @return string
     */
    protected function storagePath()
    {
        $this->makeDirectory($this->config['storage']);

        return rtrim($this->config['storage'], '/').'/';
    }
}


1		<?php
2
3		namespace Recca0120\Upload;
4
5		use Illuminate\Http\Request;
6		use Illuminate\Http\JsonResponse;
7		use Recca0120\Upload\Contracts\Api as ApiContract;
8		use Symfony\Component\HttpFoundation\File\UploadedFile;
9
10		abstract class Api implements ApiContract
11		{
12		/**
13		* $request.
14		*
15		* @var \Illuminate\Http\Request
16		*/
17		public $request;
18
19		/**
20		* $filesystem.
21		*
22		* @var \Recca0120\Upload\Filesystem
23		*/
24		public $filesystem;
25
26		/**
27		* $config.
28		*
29		* @var array
30		*/
31		protected $config;
32
33		/**
34		* __construct.
35		*
36		* @param array $config
37		* @param \Illuminate\Http\Request $request
38		* @param \Recca0120\Upload\Filesystem $filesystem
39		*/
40	17	public function __construct($config = [], Request $request = null, Filesystem $filesystem = null, ChunkFile $chunkFile = null)
41		{
42	17	$this->request = $request ?: Request::capture();
43	17	$this->filesystem = $filesystem ?: new Filesystem();
44	17	$this->chunkFile = $chunkFile ?: new ChunkFile($this->filesystem);
		0 ignored issues – show Bug introduced 2017-04-10 20:42 UTC by Report Bug Copy Issue Report The property `chunkFile` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
45	17	$this->config = array_merge([
46	17	'chunks' => sys_get_temp_dir().'/chunks',
47	17	'storage' => 'storage/temp',
48	17	'domain' => $this->request->root(),
49	17	'path' => 'storage/temp',
50	17	], $config);
51	17	}
52
53		/**
54		* domain.
55		*
56		* @return string
57		*/
58	1	public function domain()
59		{
60	1	return rtrim($this->config['domain'], '/').'/';
61		}
62
63		/**
64		* path.
65		*
66		* @return string
67		*/
68	1	public function path()
69		{
70	1	return rtrim($this->config['path'], '/').'/';
71		}
72
73		/**
74		* makeDirectory.
75		*
76		* @return $this
77		*/
78	6	public function makeDirectory($path)
79		{
80	6	if ($this->filesystem->isDirectory($path) === false) {
81	1	$this->filesystem->makeDirectory($path, 0777, true, true);
82	1	}
83
84	6	return $this;
85		}
86
87		/**
88		* cleanDirectory.
89		*/
90	2	public function cleanDirectory($path)
91		{
92	2	$time = time();
93	2	$maxFileAge = 3600;
94	2	$files = (array) $this->filesystem->files($path);
95	2	foreach ($files as $file) {
96	1	if ($this->filesystem->isFile($file) === true &&
97	1	$this->filesystem->lastModified($file) < ($time - $maxFileAge)
98	1	) {
99	1	$this->filesystem->delete($file);
100	1	}
101	2	}
102	2	}
103
104		/**
105		* receive.
106		*
107		* @param string $inputName
108		* @return \Symfony\Component\HttpFoundation\File\UploadedFile
109		*
110		* @throws \Recca0120\Upload\Exceptions\ChunkedResponseException
111		*/
112		abstract public function receive($inputName);
113
114		/**
115		* deleteUploadedFile.
116		*
117		* @param \Symfony\Component\HttpFoundation\File\UploadedFile
118		* @return $this
119		*/
120	1	public function deleteUploadedFile(UploadedFile $uploadedFile)
121		{
122	1	$file = $uploadedFile->getPathname();
123	1	if ($this->filesystem->isFile($file) === true) {
124	1	$this->filesystem->delete($file);
125	1	}
126	1	$this->cleanDirectory($this->config['chunks']);
127
128	1	return $this;
129		}
130
131		/**
132		* completedResponse.
133		*
134		* @param \Illuminate\Http\JsonResponse $response
135		* @return \Illuminate\Http\JsonResponse
136		*/
137	1	public function completedResponse(JsonResponse $response)
138		{
139	1	return $response;
140		}
141
142		/**
143		* chunkPath.
144		*
145		* @return string
146		*/
147	5	protected function chunkPath()
148		{
149	5	$this->makeDirectory($this->config['chunks']);
150
151	5	return rtrim($this->config['chunks'], '/').'/';
152		}
153
154		/**
155		* storagePath.
156		*
157		* @return string
158		*/
159	5	protected function storagePath()
160		{
161	5	$this->makeDirectory($this->config['storage']);
162
163	5	return rtrim($this->config['storage'], '/').'/';
164		}
165		}
166

recca0120 / upload

Push — master ( 40400a...73c84a )

Api::storagePath() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like