Recca0120\Twzipcode\Rules

Complexity

Total Complexity

6

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

91.67%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	2
A	match()	0	15	4

<?php

namespace Recca0120\Twzipcode;

use Recca0120\Twzipcode\Storages\File;
use Recca0120\Twzipcode\Contracts\Storage;

class Rules
{
    /**
     * $storage.
     *
     * @var \Recca0120\Twzipcode\Contracts\Storage
     */
    protected $storage;

    /**
     * __construct.
     *
     * @param \Recca0120\Twzipcode\Contracts\Storage $storage
     */
    public function __construct(Storage $storage = null)
    {
        $this->storage = $storage ?: new File();
    }

    /**
     * match.
     *
     * @param string $address
     * @return string
     */
    public function match($address)
    {
        $address = is_a($address, Address::class) === true ? $address : new Address($address);
        $zip3 = $this->storage->zip3($address);

It seems like $address defined by is_a($address, \Recca0120\Twzipcode\Address::class) === true ? $address : new \Recca0120\Twzipcode\Address($address) on line 35 can also be of type string; however, Recca0120\Twzipcode\Contracts\Storage::zip3() does only seem to accept object<Recca0120\Twzipcode\Address>, maybe add an additional type check?

        if (empty($zip3) === true) {
            return;
        }

        $rule = $this->storage->rules($zip3)->find(function ($rule) use ($address) {

The method find cannot be called on $this->storage->rules($zip3) (of type string).

            return $rule->match($address);
        });

        return is_null($rule) === false ? $rule->zip5() : $zip3;
    }
}