CreateTransactionAction::execute() - Code Metrics - Inspection of "fix" - recca0120/payum-mypay - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 891ec6...52a9d3 )

by recca

created 2017-03-06 18:23 UTC

CreateTransactionAction::execute() A

↳ Parent: CreateTransactionAction

Complexity

Conditions	4
Paths	2

Size

Total Lines	20
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	12
CRAP Score	4

Importance

Changes

Metric	Value
dl	0
loc	20
ccs	12
cts	12
cp	1
rs	9.2
c	0
b	0
f	0
cc	4
eloc	12
nc	2
nop	1
crap	4

<?php

namespace PayumTW\Mypay\Action\Api;

use LogicException;
use Payum\Core\Reply\HttpRedirect;
use Payum\Core\Bridge\Spl\ArrayObject;
use PayumTW\Mypay\Request\Api\CreateTransaction;
use Payum\Core\Exception\RequestNotSupportedException;

class CreateTransactionAction extends BaseApiAwareAction
{
    /**
     * {@inheritdoc}
     *
     * @param $request CreateTransaction
     */
    public function execute($request)
    {
        RequestNotSupportedException::assertSupports($this, $request);

        $details = ArrayObject::ensureArrayObject($request->getModel());

        $params = $this->api->createTransaction((array) $details);

        $details->replace($params);

        if (isset($params['url']) === false) {
            throw new LogicException("Response content is not valid json: \n\n".urldecode(json_encode(array_map(function ($data) {
                return is_string($data) === true ? urlencode($data) : $data;
            }, $params))));
        } else {
            throw new HttpRedirect($params['url'].'?locale='.$this->locale(
                isset($details['locale']) === true ? $details['locale'] : 'zh-TW'
            ));
        }
    }

    /**
     * locale.
     *
     * @param string $locale
     * @return string
     */
    protected function locale($locale)
    {
        $map = [
            'zh-tw' => 'zh-TW',
            'tw' => 'zh-TW',
            'zh-cn' => 'zh-CN',
            'cn' => 'zh-CN',
            'en-us' => 'en',
            'en' => 'en',
        ];
        $locale = strtolower($locale);

        return isset($map[$locale]) === true ? $map[$locale] : 'zh-TW';
    }

    /**
     * {@inheritdoc}
     */
    public function supports($request)
    {
        return
            $request instanceof CreateTransaction &&
            $request->getModel() instanceof \ArrayAccess;
    }
}


1		<?php
2
3		namespace PayumTW\Mypay\Action\Api;
4
5		use LogicException;
6		use Payum\Core\Reply\HttpRedirect;
7		use Payum\Core\Bridge\Spl\ArrayObject;
8		use PayumTW\Mypay\Request\Api\CreateTransaction;
9		use Payum\Core\Exception\RequestNotSupportedException;
10
11		class CreateTransactionAction extends BaseApiAwareAction
12		{
13		/**
14		* {@inheritdoc}
15		*
16		* @param $request CreateTransaction
17		*/
18	2	public function execute($request)
19		{
20	2	RequestNotSupportedException::assertSupports($this, $request);
21
22	2	$details = ArrayObject::ensureArrayObject($request->getModel());
23
24	2	$params = $this->api->createTransaction((array) $details);
25
26	2	$details->replace($params);
27
28	2	if (isset($params['url']) === false) {
29	1	throw new LogicException("Response content is not valid json: \n\n".urldecode(json_encode(array_map(function ($data) {
30	1	return is_string($data) === true ? urlencode($data) : $data;
31	1	}, $params))));
32		} else {
33	1	throw new HttpRedirect($params['url'].'?locale='.$this->locale(
34	1	isset($details['locale']) === true ? $details['locale'] : 'zh-TW'
35	1	));
36		}
37		}
38
39		/**
40		* locale.
41		*
42		* @param string $locale
43		* @return string
44		*/
45	1	protected function locale($locale)
46		{
47		$map = [
48	1	'zh-tw' => 'zh-TW',
49	1	'tw' => 'zh-TW',
50	1	'zh-cn' => 'zh-CN',
51	1	'cn' => 'zh-CN',
52	1	'en-us' => 'en',
53	1	'en' => 'en',
54	1	];
55	1	$locale = strtolower($locale);
56
57	1	return isset($map[$locale]) === true ? $map[$locale] : 'zh-TW';
58		}
59
60		/**
61		* {@inheritdoc}
62		*/
63	2	public function supports($request)
64		{
65		return
66	2	$request instanceof CreateTransaction &&
67	2	$request->getModel() instanceof \ArrayAccess;
68		}
69		}
70

recca0120 / payum-mypay

Push — master ( 891ec6...52a9d3 )

CreateTransactionAction::execute() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like