PayumTW\Ips\Action\Api\BaseApiAwareAction

Complexity

Total Complexity

2

Size/Duplication

Total Lines	19
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

80%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	setApi()	0	8	2

<?php

namespace PayumTW\Ips\Action\Api;

use PayumTW\Ips\Api;
use Payum\Core\ApiAwareInterface;
use Payum\Core\Action\ActionInterface;
use Payum\Core\Exception\UnsupportedApiException;

abstract class BaseApiAwareAction implements ActionInterface, ApiAwareInterface
{
    /**
     * @var \Payum\Ips\Api
     */
    protected $api;

    /**
     * {@inheritdoc}
     */
    public function setApi($api)
    {
        if (false == $api instanceof Api) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            throw new UnsupportedApiException('Not supported.');
        }

        $this->api = $api;

It seems like $api of type object<PayumTW\Ips\Api> is incompatible with the declared type object<Payum\Ips\Api> of property $api.

    }
}