Issues in EcpayApi.php (master) - Issues in master - recca0120/payum-ecpay - Measure and Improve Code Quality continuously with Scrutinizer

Issues (305)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/EcpayApi.php (8 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace PayumTW\Ecpay;

use ECPay_DeviceType;
use ECPay_InvoiceState;
use PayumTW\Ecpay\Sdk\AllInOne;
use Http\Message\MessageFactory;
use Payum\Core\HttpClientInterface;

class EcpayApi extends Api
{
    /**
     * $client.
     *
     * @var \Payum\Core\HttpClientInterface
     */
    protected $client;

    /**
     * MessageFactory.
     *
     * @var \Http\Message\MessageFactory
     */
    protected $messageFactory;

    /**
     * $options.
     *
     * @var array
     */
    protected $options = [];

    /**
     * $sdk.
     *
     * @var \PayumTW\Ecpay\Sdk\AllInOne
     */
    protected $sdk;

    /**
     * @param array $options
     * @param \Payum\Core\HttpClientInterface $client
     * @param \Http\Message\MessageFactory $messageFactory
     * @param \PayumTW\Ecpay\Sdk\AllInOne $sdk
     *
     * @throws \Payum\Core\Exception\InvalidArgumentException if an option is invalid
     */
    public function __construct(array $options, HttpClientInterface $client, MessageFactory $messageFactory, AllInOne $sdk = null)

    {
        $this->options = $options;
        $this->client = $client;
        $this->messageFactory = $messageFactory;
        $this->sdk = $sdk ?: new AllInOne();
        $this->sdk->HashKey = $this->options['HashKey'];
        $this->sdk->HashIV = $this->options['HashIV'];
        $this->sdk->MerchantID = $this->options['MerchantID'];
    }

    /**
     * getApiEndpoint.
     *
     * @return string
     */
    public function getApiEndpoint($name = 'AioCheckOut')
    {
        $map = [
            'AioCheckOut' => 'https://payment.ecpay.com.tw/Cashier/AioCheckOut/V2 ',
            'QueryTradeInfo' => 'https://payment.ecpay.com.tw/Cashier/QueryTradeInfo/V2',
            'QueryPeriodCreditCardTradeInfo' => 'https://payment.ecpay.com.tw/Cashier/QueryCreditCardPeriodInfo',
            'DoAction' => 'https://payment.ecpay.com.tw/CreditDetail/DoAction',
            'AioChargeback' => 'https://payment.ecpay.com.tw/Cashier/AioChargeback',
        ];

        if ($this->options['sandbox'] === true) {
            $map = [
                'AioCheckOut' => 'https://payment-stage.ecpay.com.tw/Cashier/AioCheckOut/V2',
                'QueryTradeInfo' => 'https://payment-stage.ecpay.com.tw/Cashier/QueryTradeInfo/V2',
                'QueryPeriodCreditCardTradeInfo' => 'https://payment-stage.ecpay.com.tw/Cashier/QueryCreditCardPeriodInfo',
                'DoAction' => null,
                'AioChargeback' => 'https://payment-stage.ecpay.com.tw/Cashier/AioChargeback',
            ];
        }

        return $map[$name];
    }

    /**
     * createTransaction.
     *
     * @param array $params
     * @return array
     */
    public function createTransaction(array $params)
    {
        $this->sdk->ServiceURL = $this->getApiEndpoint('AioCheckOut');
        $this->sdk->Send['MerchantTradeDate'] = date('Y/m/d H:i:s');
        $this->sdk->Send['DeviceSource'] = $this->isMobile() ? ECPay_DeviceType::Mobile : ECPay_DeviceType::PC;
        $this->sdk->Send = array_replace(

            $this->sdk->Send,
            array_intersect_key($params, $this->sdk->Send)
        );

        /*

         * 電子發票參數
         * $sdk->Send['InvoiceMark'] = ECPay_InvoiceState::Yes;
         * $sdk->SendExtend['RelateNumber'] = $MerchantTradeNo;
         * $sdk->SendExtend['CustomerEmail'] = '[email protected]';
         * $sdk->SendExtend['CustomerPhone'] = '0911222333';
         * $sdk->SendExtend['TaxType'] = TaxType::Dutiable;
         * $sdk->SendExtend['CustomerAddr'] = '台北市南港區三重路19-2號5樓D棟';
         * $sdk->SendExtend['InvoiceItems'] = array();
         * 將商品加入電子發票商品列表陣列
         * foreach ($sdk->Send['Items'] as $info) {
         *     array_push($sdk->SendExtend['InvoiceItems'],array('Name' => $info['Name'],'Count' =>
         *         $info['Quantity'],'Word' => '個','Price' => $info['Price'],'TaxType' => TaxType::Dutiable));
         * }
         * $sdk->SendExtend['InvoiceRemark'] = '測試發票備註';
         * $sdk->SendExtend['DelayDay'] = '0';
         * $sdk->SendExtend['InvType'] = InvType::General;
         */

        return $this->sdk->formToArray(
            $this->sdk->CheckOutString()
        );
    }

    /**
     * cancelTransaction.
     *
     * @param array $params
     * @return array
     */
    public function cancelTransaction($params)

    {
        $this->sdk->ServiceURL = $this->getApiEndpoint('DoAction');
        $this->sdk->Action = array_replace(

            $this->sdk->Action,
            array_intersect_key($params, $this->sdk->Action)
        );

        return $this->sdk->DoAction();
    }

    /**
     * refundTransaction.
     *
     * @param array $params
     * @return array
     */
    public function refundTransaction($params)

    {
        $this->sdk->ServiceURL = $this->getApiEndpoint('AioChargeback');
        $this->sdk->ChargeBack = array_replace(

            $this->sdk->ChargeBack,
            array_intersect_key($params, $this->sdk->ChargeBack)
        );

        return $this->sdk->AioChargeback();

    }

    /**
     * getTransactionData.
     *
     * @param mixed $params
     * @return array
     */
    public function getTransactionData($params)
    {
        $this->sdk->ServiceURL = $this->getApiEndpoint('QueryTradeInfo');
        $this->sdk->Query['MerchantTradeNo'] = $params['MerchantTradeNo'];
        $details = $this->sdk->QueryTradeInfo();
        $details['RtnCode'] = $details['TradeStatus'] === '1' ? '1' : '2';

        return $details;
    }
}


1			<?php
2
3			namespace PayumTW\Ecpay;
4
5			use ECPay_DeviceType;
6			use ECPay_InvoiceState;
7			use PayumTW\Ecpay\Sdk\AllInOne;
8			use Http\Message\MessageFactory;
9			use Payum\Core\HttpClientInterface;
10
11			class EcpayApi extends Api
12			{
13			/**
14			* $client.
15			*
16			* @var \Payum\Core\HttpClientInterface
17			*/
18			protected $client;
19
20			/**
21			* MessageFactory.
22			*
23			* @var \Http\Message\MessageFactory
24			*/
25			protected $messageFactory;
26
27			/**
28			* $options.
29			*
30			* @var array
31			*/
32			protected $options = [];
33
34			/**
35			* $sdk.
36			*
37			* @var \PayumTW\Ecpay\Sdk\AllInOne
38			*/
39			protected $sdk;
40
41			/**
42			* @param array $options
43			* @param \Payum\Core\HttpClientInterface $client
44			* @param \Http\Message\MessageFactory $messageFactory
45			* @param \PayumTW\Ecpay\Sdk\AllInOne $sdk
46			*
47			* @throws \Payum\Core\Exception\InvalidArgumentException if an option is invalid
48			*/
49	5	View Code Duplication	public function __construct(array $options, HttpClientInterface $client, MessageFactory $messageFactory, AllInOne $sdk = null)
			0 ignored issues – show Duplication introduced 2017-03-05 12:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50			{
51	5		$this->options = $options;
52	5		$this->client = $client;
53	5		$this->messageFactory = $messageFactory;
54	5		$this->sdk = $sdk ?: new AllInOne();
55	5		$this->sdk->HashKey = $this->options['HashKey'];
56	5		$this->sdk->HashIV = $this->options['HashIV'];
57	5		$this->sdk->MerchantID = $this->options['MerchantID'];
58	5		}
59
60			/**
61			* getApiEndpoint.
62			*
63			* @return string
64			*/
65	4		public function getApiEndpoint($name = 'AioCheckOut')
66			{
67			$map = [
68	4		'AioCheckOut' => 'https://payment.ecpay.com.tw/Cashier/AioCheckOut/V2 ',
69	4		'QueryTradeInfo' => 'https://payment.ecpay.com.tw/Cashier/QueryTradeInfo/V2',
70	4		'QueryPeriodCreditCardTradeInfo' => 'https://payment.ecpay.com.tw/Cashier/QueryCreditCardPeriodInfo',
71	4		'DoAction' => 'https://payment.ecpay.com.tw/CreditDetail/DoAction',
72	4		'AioChargeback' => 'https://payment.ecpay.com.tw/Cashier/AioChargeback',
73	4		];
74
75	4		if ($this->options['sandbox'] === true) {
76			$map = [
77			'AioCheckOut' => 'https://payment-stage.ecpay.com.tw/Cashier/AioCheckOut/V2',
78			'QueryTradeInfo' => 'https://payment-stage.ecpay.com.tw/Cashier/QueryTradeInfo/V2',
79			'QueryPeriodCreditCardTradeInfo' => 'https://payment-stage.ecpay.com.tw/Cashier/QueryCreditCardPeriodInfo',
80			'DoAction' => null,
81			'AioChargeback' => 'https://payment-stage.ecpay.com.tw/Cashier/AioChargeback',
82			];
83			}
84
85	4		return $map[$name];
86			}
87
88			/**
89			* createTransaction.
90			*
91			* @param array $params
92			* @return array
93			*/
94	1		public function createTransaction(array $params)
95			{
96	1		$this->sdk->ServiceURL = $this->getApiEndpoint('AioCheckOut');
97	1		$this->sdk->Send['MerchantTradeDate'] = date('Y/m/d H:i:s');
98	1		$this->sdk->Send['DeviceSource'] = $this->isMobile() ? ECPay_DeviceType::Mobile : ECPay_DeviceType::PC;
99	1		$this->sdk->Send = array_replace(
			0 ignored issues – show Documentation Bug introduced 2017-03-05 12:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `array_replace($this->sdk...ams, $this->sdk->Send))` of type `array` is incompatible with the declared type `string` of property `$Send`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
100	1		$this->sdk->Send,
101	1		array_intersect_key($params, $this->sdk->Send)
102	1		);
103
104			/*
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-03-05 12:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
105			* 電子發票參數
106			* $sdk->Send['InvoiceMark'] = ECPay_InvoiceState::Yes;
107			* $sdk->SendExtend['RelateNumber'] = $MerchantTradeNo;
108			* $sdk->SendExtend['CustomerEmail'] = '[email protected]';
109			* $sdk->SendExtend['CustomerPhone'] = '0911222333';
110			* $sdk->SendExtend['TaxType'] = TaxType::Dutiable;
111			* $sdk->SendExtend['CustomerAddr'] = '台北市南港區三重路19-2號5樓D棟';
112			* $sdk->SendExtend['InvoiceItems'] = array();
113			* 將商品加入電子發票商品列表陣列
114			* foreach ($sdk->Send['Items'] as $info) {
115			* array_push($sdk->SendExtend['InvoiceItems'],array('Name' => $info['Name'],'Count' =>
116			* $info['Quantity'],'Word' => '個','Price' => $info['Price'],'TaxType' => TaxType::Dutiable));
117			* }
118			* $sdk->SendExtend['InvoiceRemark'] = '測試發票備註';
119			* $sdk->SendExtend['DelayDay'] = '0';
120			* $sdk->SendExtend['InvType'] = InvType::General;
121			*/
122
123	1		return $this->sdk->formToArray(
124	1		$this->sdk->CheckOutString()
125	1		);
126			}
127
128			/**
129			* cancelTransaction.
130			*
131			* @param array $params
132			* @return array
133			*/
134	1	View Code Duplication	public function cancelTransaction($params)
			0 ignored issues – show Duplication introduced 2017-09-26 18:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
135			{
136	1		$this->sdk->ServiceURL = $this->getApiEndpoint('DoAction');
137	1		$this->sdk->Action = array_replace(
			0 ignored issues – show Documentation Bug introduced 2017-03-05 12:27 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `array_replace($this->sdk...s, $this->sdk->Action))` of type `array` is incompatible with the declared type `string` of property `$Action`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
138	1		$this->sdk->Action,
139	1		array_intersect_key($params, $this->sdk->Action)
140	1		);
141
142	1		return $this->sdk->DoAction();
143			}
144
145			/**
146			* refundTransaction.
147			*
148			* @param array $params
149			* @return array
150			*/
151	1	View Code Duplication	public function refundTransaction($params)
			0 ignored issues – show Duplication introduced 2017-09-26 18:56 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
152			{
153	1		$this->sdk->ServiceURL = $this->getApiEndpoint('AioChargeback');
154	1		$this->sdk->ChargeBack = array_replace(
			0 ignored issues – show Bug introduced 2017-09-27 02:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `ChargeBack` does not seem to exist in `PayumTW\Ecpay\Sdk\AllInOne`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
155	1		$this->sdk->ChargeBack,
156	1		array_intersect_key($params, $this->sdk->ChargeBack)
157	1		);
158
159	1		return $this->sdk->AioChargeback();
			0 ignored issues – show Bug introduced 2017-09-27 02:00 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `AioChargeback()` does not seem to exist on `object<PayumTW\Ecpay\Sdk\AllInOne>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
160			}
161
162			/**
163			* getTransactionData.
164			*
165			* @param mixed $params
166			* @return array
167			*/
168	1		public function getTransactionData($params)
169			{
170	1		$this->sdk->ServiceURL = $this->getApiEndpoint('QueryTradeInfo');
171	1		$this->sdk->Query['MerchantTradeNo'] = $params['MerchantTradeNo'];
172	1		$details = $this->sdk->QueryTradeInfo();
173	1		$details['RtnCode'] = $details['TradeStatus'] === '1' ? '1' : '2';
174
175	1		return $details;
176			}
177			}
178

recca0120 / payum-ecpay

Issues (305)

Security Analysis not enabled

src/EcpayApi.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like