PayumTW\Ecpay\EcpayApi

Complexity

Total Complexity

10

Size/Duplication

Total Lines	167
Duplicated Lines	17.96 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

87.5%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	10	10	2
A	getApiEndpoint()	0	22	2
B	createTransaction()	0	33	2
A	cancelTransaction()	10	10	1
A	refundTransaction()	10	10	1
A	getTransactionData()	0	9	2

<?php

namespace PayumTW\Ecpay;

use ECPay_DeviceType;
use ECPay_InvoiceState;
use PayumTW\Ecpay\Sdk\AllInOne;
use Http\Message\MessageFactory;
use Payum\Core\HttpClientInterface;

class EcpayApi extends Api
{
    /**
     * $client.
     *
     * @var \Payum\Core\HttpClientInterface
     */
    protected $client;

    /**
     * MessageFactory.
     *
     * @var \Http\Message\MessageFactory
     */
    protected $messageFactory;

    /**
     * $options.
     *
     * @var array
     */
    protected $options = [];

    /**
     * $sdk.
     *
     * @var \PayumTW\Ecpay\Sdk\AllInOne
     */
    protected $sdk;

    /**
     * @param array $options
     * @param \Payum\Core\HttpClientInterface $client
     * @param \Http\Message\MessageFactory $messageFactory
     * @param \PayumTW\Ecpay\Sdk\AllInOne $sdk
     *
     * @throws \Payum\Core\Exception\InvalidArgumentException if an option is invalid
     */
    public function __construct(array $options, HttpClientInterface $client, MessageFactory $messageFactory, AllInOne $sdk = null)

This method seems to be duplicated in your project.

    {
        $this->options = $options;
        $this->client = $client;
        $this->messageFactory = $messageFactory;
        $this->sdk = $sdk ?: new AllInOne();
        $this->sdk->HashKey = $this->options['HashKey'];
        $this->sdk->HashIV = $this->options['HashIV'];
        $this->sdk->MerchantID = $this->options['MerchantID'];
    }

    /**
     * getApiEndpoint.
     *
     * @return string
     */
    public function getApiEndpoint($name = 'AioCheckOut')
    {
        $map = [
            'AioCheckOut' => 'https://payment.ecpay.com.tw/Cashier/AioCheckOut/V2 ',
            'QueryTradeInfo' => 'https://payment.ecpay.com.tw/Cashier/QueryTradeInfo/V2',
            'QueryPeriodCreditCardTradeInfo' => 'https://payment.ecpay.com.tw/Cashier/QueryCreditCardPeriodInfo',
            'DoAction' => 'https://payment.ecpay.com.tw/CreditDetail/DoAction',
            'AioChargeback' => 'https://payment.ecpay.com.tw/Cashier/AioChargeback',
        ];

        if ($this->options['sandbox'] === true) {
            $map = [
                'AioCheckOut' => 'https://payment-stage.ecpay.com.tw/Cashier/AioCheckOut/V2',
                'QueryTradeInfo' => 'https://payment-stage.ecpay.com.tw/Cashier/QueryTradeInfo/V2',
                'QueryPeriodCreditCardTradeInfo' => 'https://payment-stage.ecpay.com.tw/Cashier/QueryCreditCardPeriodInfo',
                'DoAction' => null,
                'AioChargeback' => 'https://payment-stage.ecpay.com.tw/Cashier/AioChargeback',
            ];
        }

        return $map[$name];
    }

    /**
     * createTransaction.
     *
     * @param array $params
     * @return array
     */
    public function createTransaction(array $params)
    {
        $this->sdk->ServiceURL = $this->getApiEndpoint('AioCheckOut');
        $this->sdk->Send['MerchantTradeDate'] = date('Y/m/d H:i:s');
        $this->sdk->Send['DeviceSource'] = $this->isMobile() ? ECPay_DeviceType::Mobile : ECPay_DeviceType::PC;
        $this->sdk->Send = array_replace(

It seems like array_replace($this->sdk->Send, array_intersect_key($params, $this->sdk->Send)) of type array is incompatible with the declared type string of property $Send.

            $this->sdk->Send,
            array_intersect_key($params, $this->sdk->Send)
        );

        /*

56% of this comment could be valid code. Did you maybe forget this after debugging?

         * 電子發票參數
         * $sdk->Send['InvoiceMark'] = ECPay_InvoiceState::Yes;
         * $sdk->SendExtend['RelateNumber'] = $MerchantTradeNo;
         * $sdk->SendExtend['CustomerEmail'] = 'test@ecpay.com.tw';
         * $sdk->SendExtend['CustomerPhone'] = '0911222333';
         * $sdk->SendExtend['TaxType'] = TaxType::Dutiable;
         * $sdk->SendExtend['CustomerAddr'] = '台北市南港區三重路19-2號5樓D棟';
         * $sdk->SendExtend['InvoiceItems'] = array();
         * 將商品加入電子發票商品列表陣列
         * foreach ($sdk->Send['Items'] as $info) {
         *     array_push($sdk->SendExtend['InvoiceItems'],array('Name' => $info['Name'],'Count' =>
         *         $info['Quantity'],'Word' => '個','Price' => $info['Price'],'TaxType' => TaxType::Dutiable));
         * }
         * $sdk->SendExtend['InvoiceRemark'] = '測試發票備註';
         * $sdk->SendExtend['DelayDay'] = '0';
         * $sdk->SendExtend['InvType'] = InvType::General;
         */

        return $this->sdk->formToArray(
            $this->sdk->CheckOutString()
        );
    }

    /**
     * cancelTransaction.
     *
     * @param array $params
     * @return array
     */
    public function cancelTransaction($params)

This method seems to be duplicated in your project.

    {
        $this->sdk->ServiceURL = $this->getApiEndpoint('DoAction');
        $this->sdk->Action = array_replace(

It seems like array_replace($this->sdk->Action, array_intersect_key($params, $this->sdk->Action)) of type array is incompatible with the declared type string of property $Action.

            $this->sdk->Action,
            array_intersect_key($params, $this->sdk->Action)
        );

        return $this->sdk->DoAction();
    }

    /**
     * refundTransaction.
     *
     * @param array $params
     * @return array
     */
    public function refundTransaction($params)

This method seems to be duplicated in your project.

    {
        $this->sdk->ServiceURL = $this->getApiEndpoint('AioChargeback');
        $this->sdk->ChargeBack = array_replace(

The property ChargeBack does not seem to exist in PayumTW\Ecpay\Sdk\AllInOne.

            $this->sdk->ChargeBack,
            array_intersect_key($params, $this->sdk->ChargeBack)
        );

        return $this->sdk->AioChargeback();

The method AioChargeback() does not seem to exist on object<PayumTW\Ecpay\Sdk\AllInOne>.

    }

    /**
     * getTransactionData.
     *
     * @param mixed $params
     * @return array
     */
    public function getTransactionData($params)
    {
        $this->sdk->ServiceURL = $this->getApiEndpoint('QueryTradeInfo');
        $this->sdk->Query['MerchantTradeNo'] = $params['MerchantTradeNo'];
        $details = $this->sdk->QueryTradeInfo();
        $details['RtnCode'] = $details['TradeStatus'] === '1' ? '1' : '2';

        return $details;
    }
}